Re: [Intel-gfx] [PATCH 4/4] drm/i915: Prevent fence-reuse stalls

[Daniel Vetter]

On Fri, Mar 18, 2011 at 10:35:19PM +, Chris Wilson wrote:
 With the last bug preventing fence pipelining fixed (or at least the
 last known bug), re-enable pipelining to avoid stalling on fence
 acquisition between batches.

\o/ ... the cleaned-up get_fence code is definitely much less scary, so
I'm all for a new round lets-try-to-upset-gen3-gpus.

Acked-by: Daniel Vetter daniel.vet...@ffwll.ch
-- 
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 4/4] drm/i915: Prevent fence-reuse stalls

[Chris Wilson]

With the last bug preventing fence pipelining fixed (or at least the
last known bug), re-enable pipelining to avoid stalling on fence
acquisition between batches.

Cc: Andy Whitcroft a...@canonical.com
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
 drivers/gpu/drm/i915/i915_gem.c |3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 2dbf8f7..78dba7a 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2575,9 +2575,6 @@ i915_gem_object_get_fence(struct drm_i915_gem_object *obj,
struct drm_i915_fence_reg *reg;
int ret;
 
-   /* XXX disable pipelining. There are bugs. Shocking. */
-   pipelined = NULL;
-
/* Just update our place in the LRU if our fence is getting reused. */
if (obj-fence_reg != I915_FENCE_REG_NONE) {
reg = dev_priv-fence_regs[obj-fence_reg];
-- 
1.7.2.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx