Re: [Intel-gfx] [PATCH 4/8] drm/i915/selftests: Remove redundant set-to-gtt-domain

[Matthew Auld]

On Mon, 25 Jan 2021 at 14:18, Chris Wilson  wrote:
>
> Since the vma's backing store is flushed upon first creation, remove the
> manual calls to set-to-gtt-domain.
>
> Signed-off-by: Chris Wilson 
Reviewed-by: Matthew Auld 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 4/8] drm/i915/selftests: Remove redundant set-to-gtt-domain

[Chris Wilson]

Since the vma's backing store is flushed upon first creation, remove the
manual calls to set-to-gtt-domain.

Signed-off-by: Chris Wilson 
---
 .../gpu/drm/i915/gem/selftests/i915_gem_mman.c   | 16 
 drivers/gpu/drm/i915/selftests/i915_vma.c|  6 --
 2 files changed, 22 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c 
b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
index d429c7643ff2..39293d98f34d 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
@@ -104,14 +104,6 @@ static int check_partial_mapping(struct 
drm_i915_gem_object *obj,
GEM_BUG_ON(i915_gem_object_get_tiling(obj) != tile->tiling);
GEM_BUG_ON(i915_gem_object_get_stride(obj) != tile->stride);
 
-   i915_gem_object_lock(obj, NULL);
-   err = i915_gem_object_set_to_gtt_domain(obj, true);
-   i915_gem_object_unlock(obj);
-   if (err) {
-   pr_err("Failed to flush to GTT write domain; err=%d\n", err);
-   return err;
-   }
-
page = i915_prandom_u32_max_state(npages, prng);
view = compute_partial_view(obj, page, MIN_CHUNK_PAGES);
 
@@ -189,14 +181,6 @@ static int check_partial_mappings(struct 
drm_i915_gem_object *obj,
GEM_BUG_ON(i915_gem_object_get_tiling(obj) != tile->tiling);
GEM_BUG_ON(i915_gem_object_get_stride(obj) != tile->stride);
 
-   i915_gem_object_lock(obj, NULL);
-   err = i915_gem_object_set_to_gtt_domain(obj, true);
-   i915_gem_object_unlock(obj);
-   if (err) {
-   pr_err("Failed to flush to GTT write domain; err=%d\n", err);
-   return err;
-   }
-
for_each_prime_number_from(page, 1, npages) {
struct i915_ggtt_view view =
compute_partial_view(obj, page, MIN_CHUNK_PAGES);
diff --git a/drivers/gpu/drm/i915/selftests/i915_vma.c 
b/drivers/gpu/drm/i915/selftests/i915_vma.c
index 1b6125e4c1ac..065a9d82ad5c 100644
--- a/drivers/gpu/drm/i915/selftests/i915_vma.c
+++ b/drivers/gpu/drm/i915/selftests/i915_vma.c
@@ -892,12 +892,6 @@ static int igt_vma_remapped_gtt(void *arg)
unsigned int x, y;
int err;
 
-   i915_gem_object_lock(obj, NULL);
-   err = i915_gem_object_set_to_gtt_domain(obj, true);
-   i915_gem_object_unlock(obj);
-   if (err)
-   goto out;
-
vma = i915_gem_object_ggtt_pin(obj, &view, 0, 0, 
PIN_MAPPABLE);
if (IS_ERR(vma)) {
err = PTR_ERR(vma);
-- 
2.20.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx