Re: [Intel-gfx] [PATCH 5/5] drm/i915: Forcibly flush unwanted requests in drop-caches

2018-09-03 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-09-03 11:33:37)
> Add a mode to debugfs/drop-caches to flush unwanted requests off the GPU
> (by wedging the device and resetting). This is very useful if a test
> terminated leaving a long queue of hanging batches that would ordinarily
> require a round trip through hangcheck for each.
> 
> It reduces the inter-test operation to just a write into drop-caches to
> reset driver/GPU state between tests.
> 
> Signed-off-by: Chris Wilson 

Reviewed-by: Joonas Lahtinen 

Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 5/5] drm/i915: Forcibly flush unwanted requests in drop-caches

2018-09-03 Thread Chris Wilson
Add a mode to debugfs/drop-caches to flush unwanted requests off the GPU
(by wedging the device and resetting). This is very useful if a test
terminated leaving a long queue of hanging batches that would ordinarily
require a round trip through hangcheck for each.

It reduces the inter-test operation to just a write into drop-caches to
reset driver/GPU state between tests.

Signed-off-by: Chris Wilson 
---
 drivers/gpu/drm/i915/i915_debugfs.c | 52 -
 1 file changed, 36 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c 
b/drivers/gpu/drm/i915/i915_debugfs.c
index a5265c236a33..4ad0e2ed8610 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -4131,13 +4131,17 @@ DEFINE_SIMPLE_ATTRIBUTE(i915_ring_test_irq_fops,
 #define DROP_FREED BIT(4)
 #define DROP_SHRINK_ALLBIT(5)
 #define DROP_IDLE  BIT(6)
+#define DROP_RESET_ACTIVE  BIT(7)
+#define DROP_RESET_SEQNO   BIT(8)
 #define DROP_ALL (DROP_UNBOUND | \
  DROP_BOUND| \
  DROP_RETIRE   | \
  DROP_ACTIVE   | \
  DROP_FREED| \
  DROP_SHRINK_ALL |\
- DROP_IDLE)
+ DROP_IDLE | \
+ DROP_RESET_ACTIVE | \
+ DROP_RESET_SEQNO)
 static int
 i915_drop_caches_get(void *data, u64 *val)
 {
@@ -4149,53 +4153,69 @@ i915_drop_caches_get(void *data, u64 *val)
 static int
 i915_drop_caches_set(void *data, u64 val)
 {
-   struct drm_i915_private *dev_priv = data;
-   struct drm_device *dev = _priv->drm;
+   struct drm_i915_private *i915 = data;
int ret = 0;
 
DRM_DEBUG("Dropping caches: 0x%08llx [0x%08llx]\n",
  val, val & DROP_ALL);
 
+   if (val & DROP_RESET_ACTIVE && !intel_engines_are_idle(i915))
+   i915_gem_set_wedged(i915);
+
/* No need to check and wait for gpu resets, only libdrm auto-restarts
 * on ioctls on -EAGAIN. */
-   if (val & (DROP_ACTIVE | DROP_RETIRE)) {
-   ret = mutex_lock_interruptible(>struct_mutex);
+   if (val & (DROP_ACTIVE | DROP_RETIRE | DROP_RESET_SEQNO)) {
+   ret = mutex_lock_interruptible(>drm.struct_mutex);
if (ret)
return ret;
 
if (val & DROP_ACTIVE)
-   ret = i915_gem_wait_for_idle(dev_priv,
+   ret = i915_gem_wait_for_idle(i915,
 I915_WAIT_INTERRUPTIBLE |
 I915_WAIT_LOCKED,
 MAX_SCHEDULE_TIMEOUT);
 
+   if (val & DROP_RESET_SEQNO) {
+   intel_runtime_pm_get(i915);
+   ret = i915_gem_set_global_seqno(>drm, 1);
+   intel_runtime_pm_put(i915);
+   }
+
if (val & DROP_RETIRE)
-   i915_retire_requests(dev_priv);
+   i915_retire_requests(i915);
 
-   mutex_unlock(>struct_mutex);
+   mutex_unlock(>drm.struct_mutex);
+   }
+
+   if (val & DROP_RESET_ACTIVE &&
+   i915_terminally_wedged(>gpu_error)) {
+   i915_handle_error(i915, ALL_ENGINES, 0, NULL);
+   wait_on_bit(>gpu_error.flags,
+   I915_RESET_HANDOFF,
+   TASK_UNINTERRUPTIBLE);
}
 
fs_reclaim_acquire(GFP_KERNEL);
if (val & DROP_BOUND)
-   i915_gem_shrink(dev_priv, LONG_MAX, NULL, I915_SHRINK_BOUND);
+   i915_gem_shrink(i915, LONG_MAX, NULL, I915_SHRINK_BOUND);
 
if (val & DROP_UNBOUND)
-   i915_gem_shrink(dev_priv, LONG_MAX, NULL, I915_SHRINK_UNBOUND);
+   i915_gem_shrink(i915, LONG_MAX, NULL, I915_SHRINK_UNBOUND);
 
if (val & DROP_SHRINK_ALL)
-   i915_gem_shrink_all(dev_priv);
+   i915_gem_shrink_all(i915);
fs_reclaim_release(GFP_KERNEL);
 
if (val & DROP_IDLE) {
do {
-   if (READ_ONCE(dev_priv->gt.active_requests))
-   flush_delayed_work(_priv->gt.retire_work);
-   drain_delayed_work(_priv->gt.idle_work);
-   } while (READ_ONCE(dev_priv->gt.awake));
+   if (READ_ONCE(i915->gt.active_requests))
+   flush_delayed_work(>gt.retire_work);
+   drain_delayed_work(>gt.idle_work);
+   } while (READ_ONCE(i915->gt.awake));
}
 
if (val & DROP_FREED)
-   i915_gem_drain_freed_objects(dev_priv);
+   i915_gem_drain_freed_objects(i915);
 
return ret;
 }
-- 
2.19.0.rc1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org