Re: [Intel-gfx] [PATCH 5/7] drm/i915: Limit Wa_22010178259 to affected platforms

2021-07-09 Thread Matt Roper
On Thu, Jul 08, 2021 at 02:18:25PM -0700, José Roberto de Souza wrote:
> This workaround is not needed for platforms with display 13.
> 
> Cc: Gwan-gyeong Mun 
> Signed-off-by: José Roberto de Souza 

Reviewed-by: Matt Roper 

> ---
>  drivers/gpu/drm/i915/display/intel_display_power.c | 9 +
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c 
> b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 285380079aab2..6fc766da66054 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -5822,10 +5822,11 @@ static void tgl_bw_buddy_init(struct drm_i915_private 
> *dev_priv)
>   intel_de_write(dev_priv, BW_BUDDY_PAGE_MASK(i),
>  table[config].page_mask);
>  
> - /* Wa_22010178259:tgl,rkl */
> - intel_de_rmw(dev_priv, BW_BUDDY_CTL(i),
> -  BW_BUDDY_TLB_REQ_TIMER_MASK,
> -  BW_BUDDY_TLB_REQ_TIMER(0x8));
> + /* Wa_22010178259:tgl,dg1,rkl,adl-s */
> + if (DISPLAY_VER(dev_priv) == 12)
> + intel_de_rmw(dev_priv, BW_BUDDY_CTL(i),
> +  BW_BUDDY_TLB_REQ_TIMER_MASK,
> +  BW_BUDDY_TLB_REQ_TIMER(0x8));
>   }
>   }
>  }
> -- 
> 2.32.0
> 
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 5/7] drm/i915: Limit Wa_22010178259 to affected platforms

2021-07-08 Thread José Roberto de Souza
This workaround is not needed for platforms with display 13.

Cc: Gwan-gyeong Mun 
Signed-off-by: José Roberto de Souza 
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c 
b/drivers/gpu/drm/i915/display/intel_display_power.c
index 285380079aab2..6fc766da66054 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -5822,10 +5822,11 @@ static void tgl_bw_buddy_init(struct drm_i915_private 
*dev_priv)
intel_de_write(dev_priv, BW_BUDDY_PAGE_MASK(i),
   table[config].page_mask);
 
-   /* Wa_22010178259:tgl,rkl */
-   intel_de_rmw(dev_priv, BW_BUDDY_CTL(i),
-BW_BUDDY_TLB_REQ_TIMER_MASK,
-BW_BUDDY_TLB_REQ_TIMER(0x8));
+   /* Wa_22010178259:tgl,dg1,rkl,adl-s */
+   if (DISPLAY_VER(dev_priv) == 12)
+   intel_de_rmw(dev_priv, BW_BUDDY_CTL(i),
+BW_BUDDY_TLB_REQ_TIMER_MASK,
+BW_BUDDY_TLB_REQ_TIMER(0x8));
}
}
 }
-- 
2.32.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx