Re: [Intel-gfx] [PATCH 6/6] drm/i915: Include active flag when describing objects in debugfs
On 03/19/2015 09:05 PM, Chris Wilson wrote: On Thu, Mar 19, 2015 at 05:41:26PM +, Tvrtko Ursulin wrote: On 03/09/2015 09:55 AM, Chris Wilson wrote: Since we use obj-active as a hint in many places throughout the code, knowing its state in debugfs is extremely useful. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 042ad2fec484..809f6eadc10c 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -123,8 +123,9 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj) struct i915_vma *vma; int pin_count = 0; - seq_printf(m, %pK: %s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s, + seq_printf(m, %pK: %s%s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s, obj-base, + obj-active ? * : , %c etc would maybe be more compact code? (Hey I have to earn my bike-shedding badge somehow! ;) Anyway, The rationale for the empty flags to use was to keep the fields aligned. I'm still about 60:40 whether that was a good idea in terms of formatting the debugfs files. Doesn't matter really, my joke was only about two chars being smaller than two one-char strings, weak joke yes. :) Regards, Tvrtko ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 6/6] drm/i915: Include active flag when describing objects in debugfs
On 03/09/2015 09:55 AM, Chris Wilson wrote: Since we use obj-active as a hint in many places throughout the code, knowing its state in debugfs is extremely useful. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 042ad2fec484..809f6eadc10c 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -123,8 +123,9 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj) struct i915_vma *vma; int pin_count = 0; - seq_printf(m, %pK: %s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s, + seq_printf(m, %pK: %s%s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s, obj-base, + obj-active ? * : , %c etc would maybe be more compact code? (Hey I have to earn my bike-shedding badge somehow! ;) Anyway, Reviewed-by: Tvrtko Ursulin tvrtko.ursu...@intel.com This now completes the series apart from I think two respins - rebase for possible extra unpin and missing lrc destructor. Regards, Tvrtko ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 6/6] drm/i915: Include active flag when describing objects in debugfs
On Thu, Mar 19, 2015 at 05:41:26PM +, Tvrtko Ursulin wrote: On 03/09/2015 09:55 AM, Chris Wilson wrote: Since we use obj-active as a hint in many places throughout the code, knowing its state in debugfs is extremely useful. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 042ad2fec484..809f6eadc10c 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -123,8 +123,9 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj) struct i915_vma *vma; int pin_count = 0; -seq_printf(m, %pK: %s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s, +seq_printf(m, %pK: %s%s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s, obj-base, + obj-active ? * : , %c etc would maybe be more compact code? (Hey I have to earn my bike-shedding badge somehow! ;) Anyway, The rationale for the empty flags to use was to keep the fields aligned. I'm still about 60:40 whether that was a good idea in terms of formatting the debugfs files. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 6/6] drm/i915: Include active flag when describing objects in debugfs
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5916 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -2 282/282 280/282 ILK 308/308 308/308 SNB 307/307 307/307 IVB -2 375/375 373/375 BYT -2 294/294 292/294 HSW -3 385/385 382/385 BDW 315/315 315/315 -Detailed- Platform Testdrm-intel-nightly Series Applied *PNV igt_drv_debugfs_reader PASS(2) DMESG_WARN(1)PASS(1) *PNV igt_drv_hangman_error-state-sysfs-entry PASS(2) TIMEOUT(1)PASS(1) *IVB igt_gem_flink_race_flink_close PASS(2) FAIL(2) *IVB igt_prime_self_import_reimport-vs-gem_close-race PASS(2) FAIL(2) *BYT igt_gem_flink_race_flink_close PASS(2) FAIL(2) *BYT igt_prime_self_import_reimport-vs-gem_close-race PASS(2) FAIL(2) *HSW igt_gem_flink_race_flink_close PASS(2) FAIL(2) *HSW igt_gem_storedw_loop_bsd PASS(2) DMESG_WARN(1)PASS(1) *HSW igt_prime_self_import_reimport-vs-gem_close-race PASS(2) FAIL(2) Note: You need to pay more attention to line start with '*' ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 6/6] drm/i915: Include active flag when describing objects in debugfs
Since we use obj-active as a hint in many places throughout the code, knowing its state in debugfs is extremely useful. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 042ad2fec484..809f6eadc10c 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -123,8 +123,9 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj) struct i915_vma *vma; int pin_count = 0; - seq_printf(m, %pK: %s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s, + seq_printf(m, %pK: %s%s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s, obj-base, + obj-active ? * : , get_pin_flag(obj), get_tiling_flag(obj), get_global_flag(obj), -- 2.1.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 6/6] drm/i915: Include active flag when describing objects in debugfs
Since we use obj-active as a hint in many places throughout the code, knowing its state in debugfs is extremely useful. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 40eb3ec1a4b7..14f4f5f976be 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -123,8 +123,9 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj) struct i915_vma *vma; int pin_count = 0; - seq_printf(m, %pK: %s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s, + seq_printf(m, %pK: %s%s%s%s %8zdKiB %02x %02x %x %x %x%s%s%s, obj-base, + obj-active ? * : , get_pin_flag(obj), get_tiling_flag(obj), get_global_flag(obj), -- 2.1.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
