Re: [Intel-gfx] [PATCH i-g-t] lib/igt_kms.c: Unconditionally include poll.h

[Rhys Kidd]

On 9 January 2018 at 05:11, Petri Latvala  wrote:

> Commit 98c64b33a793 ("lib/igt_kms: Drop all stale events on first
> commit.") added a use of poll() to igt_kms.c, but that file only
> includes poll.h when HAVE_UDEV is defined. Move the include outside
> the UDEV conditional.
>
> Fixes: 98c64b33a793 ("lib/igt_kms: Drop all stale events on first commit.")
> Signed-off-by: Petri Latvala 
> Cc: Maarten Lankhorst 
> Cc: Chris Wilson 
>

I have also hit this issue, and spun up locally the equivalent patch fix,
so also gets my:

Reviewed-by: Rhys Kidd 


> ---
>  lib/igt_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index ec3b7167..069752ec 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -40,8 +40,8 @@
>  #endif
>  #ifdef HAVE_UDEV
>  #include 
> -#include 
>  #endif
> +#include 
>  #include 
>  #include 
>
> --
> 2.14.1
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_kms.c: Unconditionally include poll.h

[Chris Wilson]

Quoting Petri Latvala (2018-01-09 10:11:24)
> Commit 98c64b33a793 ("lib/igt_kms: Drop all stale events on first
> commit.") added a use of poll() to igt_kms.c, but that file only
> includes poll.h when HAVE_UDEV is defined. Move the include outside
> the UDEV conditional.
> 
> Fixes: 98c64b33a793 ("lib/igt_kms: Drop all stale events on first commit.")
> Signed-off-by: Petri Latvala 
> Cc: Maarten Lankhorst 
> Cc: Chris Wilson 
Reviewed-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_kms.c: Unconditionally include poll.h

[Chris Wilson]

Quoting Petri Latvala (2018-01-09 10:11:24)
> Commit 98c64b33a793 ("lib/igt_kms: Drop all stale events on first
> commit.") added a use of poll() to igt_kms.c, but that file only
> includes poll.h when HAVE_UDEV is defined. Move the include outside
> the UDEV conditional.

We should probably stop making udev conditional. We rely on udev for
uevent detection, in particular for detecting GPU hangs.
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] lib/igt_kms.c: Unconditionally include poll.h

[Petri Latvala]

Commit 98c64b33a793 ("lib/igt_kms: Drop all stale events on first
commit.") added a use of poll() to igt_kms.c, but that file only
includes poll.h when HAVE_UDEV is defined. Move the include outside
the UDEV conditional.

Fixes: 98c64b33a793 ("lib/igt_kms: Drop all stale events on first commit.")
Signed-off-by: Petri Latvala 
Cc: Maarten Lankhorst 
Cc: Chris Wilson 
---
 lib/igt_kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index ec3b7167..069752ec 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -40,8 +40,8 @@
 #endif
 #ifdef HAVE_UDEV
 #include 
-#include 
 #endif
+#include 
 #include 
 #include 
 
-- 
2.14.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx