Re: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup() for psr_basic

[Lofstedt, Marta]

Doesn't look like it is needed for the psr_drrs

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_744/all.html

From: Lofstedt, Marta
Sent: Thursday, January 04, 2018 1:37 PM
To: Latvala, Petri
Cc: intel-gfx@lists.freedesktop.org
Subject: RE: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test 
test_cleanup() for psr_basic

> -Original Message-
> From: Latvala, Petri
> Sent: Thursday, January 4, 2018 2:11 PM
> To: Lofstedt, Marta <marta.lofst...@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test
> test_cleanup() for psr_basic
>
> On Thu, Jan 04, 2018 at 12:54:34PM +0200, Marta Lofstedt wrote:
> > The "*ERROR* Potential atomic update failure on pipe A"
> > started to occure on some BAT machines with IGT_4063.
> > Looking at the dmesgs the ERROR print come when the subtest is
> > exiting. So, this is just a longshot to test if we may need to do the
> > cleanup on this subtest as well.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260
> >
> > Signed-off-by: Marta Lofstedt <marta.lofst...@intel.com>
> > ---
> >  tests/kms_psr_sink_crc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index
> > 83a69f0b..7ee4c2f4 100644
> > --- a/tests/kms_psr_sink_crc.c
> > +++ b/tests/kms_psr_sink_crc.c
> > @@ -532,6 +532,7 @@ int main(int argc, char *argv[])
> > igt_subtest("psr_basic") {
> > setup_test_plane();
> > igt_assert(wait_psr_entry());
> > +   test_cleanup();
> > }
>
>
> This looks correct indeed.
>
>
> >
> > igt_subtest("psr_drrs") {
>
>
> But the same is required here, isn't it?

Probably, but it is green on GLK-shards which is the only machine currently 
running it. By the way it's the only green PSR related tests on GLK-shards...
I guess I could do a fastfeedback.testlist hack to BAT to see if it fails there 
on some machine.

>
>
>
> --
> Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup() for psr_basic

[Lofstedt, Marta]

> -Original Message-
> From: Latvala, Petri
> Sent: Thursday, January 4, 2018 2:11 PM
> To: Lofstedt, Marta <marta.lofst...@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test
> test_cleanup() for psr_basic
> 
> On Thu, Jan 04, 2018 at 12:54:34PM +0200, Marta Lofstedt wrote:
> > The "*ERROR* Potential atomic update failure on pipe A"
> > started to occure on some BAT machines with IGT_4063.
> > Looking at the dmesgs the ERROR print come when the subtest is
> > exiting. So, this is just a longshot to test if we may need to do the
> > cleanup on this subtest as well.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260
> >
> > Signed-off-by: Marta Lofstedt <marta.lofst...@intel.com>
> > ---
> >  tests/kms_psr_sink_crc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index
> > 83a69f0b..7ee4c2f4 100644
> > --- a/tests/kms_psr_sink_crc.c
> > +++ b/tests/kms_psr_sink_crc.c
> > @@ -532,6 +532,7 @@ int main(int argc, char *argv[])
> > igt_subtest("psr_basic") {
> > setup_test_plane();
> > igt_assert(wait_psr_entry());
> > +   test_cleanup();
> > }
> 
> 
> This looks correct indeed.
> 
> 
> >
> > igt_subtest("psr_drrs") {
> 
> 
> But the same is required here, isn't it?

Probably, but it is green on GLK-shards which is the only machine currently 
running it. By the way it's the only green PSR related tests on GLK-shards...
I guess I could do a fastfeedback.testlist hack to BAT to see if it fails there 
on some machine.

> 
> 
> 
> --
> Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup() for psr_basic

[Petri Latvala]

On Thu, Jan 04, 2018 at 12:54:34PM +0200, Marta Lofstedt wrote:
> The "*ERROR* Potential atomic update failure on pipe A"
> started to occure on some BAT machines with IGT_4063.
> Looking at the dmesgs the ERROR print come when the
> subtest is exiting. So, this is just a longshot to test if
> we may need to do the cleanup on this subtest as well.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260
> 
> Signed-off-by: Marta Lofstedt 
> ---
>  tests/kms_psr_sink_crc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> index 83a69f0b..7ee4c2f4 100644
> --- a/tests/kms_psr_sink_crc.c
> +++ b/tests/kms_psr_sink_crc.c
> @@ -532,6 +532,7 @@ int main(int argc, char *argv[])
>   igt_subtest("psr_basic") {
>   setup_test_plane();
>   igt_assert(wait_psr_entry());
> + test_cleanup();
>   }


This looks correct indeed.


>  
>   igt_subtest("psr_drrs") {


But the same is required here, isn't it?



-- 
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup() for psr_basic

[Lofstedt, Marta]

+Petri

PW results are looking good.
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_741/issues.html


From: Lofstedt, Marta
Sent: Thursday, January 04, 2018 11:54 AM
To: intel-gfx@lists.freedesktop.org
Cc: Lofstedt, Marta
Subject: [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup() 
for psr_basic

The "*ERROR* Potential atomic update failure on pipe A"
started to occure on some BAT machines with IGT_4063.
Looking at the dmesgs the ERROR print come when the
subtest is exiting. So, this is just a longshot to test if
we may need to do the cleanup on this subtest as well.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260

Signed-off-by: Marta Lofstedt 
---
 tests/kms_psr_sink_crc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 83a69f0b..7ee4c2f4 100644
--- a/tests/kms_psr_sink_crc.c
+++ b/tests/kms_psr_sink_crc.c
@@ -532,6 +532,7 @@ int main(int argc, char *argv[])
igt_subtest("psr_basic") {
setup_test_plane();
igt_assert(wait_psr_entry());
+   test_cleanup();
}

igt_subtest("psr_drrs") {
--
2.11.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] test/kms_psr_sink_crc - Hack to test test_cleanup() for psr_basic

[Marta Lofstedt]

The "*ERROR* Potential atomic update failure on pipe A"
started to occure on some BAT machines with IGT_4063.
Looking at the dmesgs the ERROR print come when the
subtest is exiting. So, this is just a longshot to test if
we may need to do the cleanup on this subtest as well.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104260

Signed-off-by: Marta Lofstedt 
---
 tests/kms_psr_sink_crc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 83a69f0b..7ee4c2f4 100644
--- a/tests/kms_psr_sink_crc.c
+++ b/tests/kms_psr_sink_crc.c
@@ -532,6 +532,7 @@ int main(int argc, char *argv[])
igt_subtest("psr_basic") {
setup_test_plane();
igt_assert(wait_psr_entry());
+   test_cleanup();
}
 
igt_subtest("psr_drrs") {
-- 
2.11.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx