Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Madhav Chauhan > Sent: Friday, November 30, 2018 7:43 PM > To: Nikula, Jani ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling > > On 11/2/2018 5:17 PM, Jani Nikula wrote: > > Next version of [1]. Sorry for the spam, needed to get the authorship > > straight. Fixed power domains and compute config hook initialization. > > Overall, with this series ICL DSI dual link video mode feature looks complete > to me. Thanks!! I meant for v11 :) > > Regards, > Madhav > > > > > BR, > > Jani. > > > > [1] https://patchwork.freedesktop.org/series/51011/ > > > > > > Jani Nikula (1): > >drm/i915/icl: add dummy DSI GPIO element execution function > > > > Madhav Chauhan (14): > >drm/i915/icl: Allocate DSI encoder/connector > >drm/i915/icl: Fill DSI ports info > >drm/i915/icl: Allocate DSI hosts and imlement host transfer > >drm/i915/icl: Add get config functionality for DSI > >drm/i915/icl: Get HW state for DSI encoder > >drm/i915/icl: Add DSI encoder remaining functions > >drm/i915/icl: Configure DSI Dual link mode > >drm/i915/icl: Consider DSI for getting transcoder state > >drm/i915/icl: Get pipe timings for DSI > >drm/i915/icl: Define missing bitfield for shortplug reg > >drm/i915/icl: Define Panel power ctrl register > >drm/i915/icl: Define display GPIO pins for DSI > >HACK: drm/i915/icl: Add changes to program DSI panel GPIOs > >HACK: drm/i915/icl: Configure backlight functions for DSI > > > > drivers/gpu/drm/i915/i915_reg.h | 12 + > > drivers/gpu/drm/i915/icl_dsi.c | 417 > ++- > > drivers/gpu/drm/i915/intel_display.c | 34 ++- > > drivers/gpu/drm/i915/intel_dsi_vbt.c | 58 - > > drivers/gpu/drm/i915/intel_panel.c | 3 +- > > 5 files changed, 505 insertions(+), 19 deletions(-) > > > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
On 11/2/2018 5:17 PM, Jani Nikula wrote: Next version of [1]. Sorry for the spam, needed to get the authorship straight. Fixed power domains and compute config hook initialization. Overall, with this series ICL DSI dual link video mode feature looks complete to me. Thanks!! Regards, Madhav BR, Jani. [1] https://patchwork.freedesktop.org/series/51011/ Jani Nikula (1): drm/i915/icl: add dummy DSI GPIO element execution function Madhav Chauhan (14): drm/i915/icl: Allocate DSI encoder/connector drm/i915/icl: Fill DSI ports info drm/i915/icl: Allocate DSI hosts and imlement host transfer drm/i915/icl: Add get config functionality for DSI drm/i915/icl: Get HW state for DSI encoder drm/i915/icl: Add DSI encoder remaining functions drm/i915/icl: Configure DSI Dual link mode drm/i915/icl: Consider DSI for getting transcoder state drm/i915/icl: Get pipe timings for DSI drm/i915/icl: Define missing bitfield for shortplug reg drm/i915/icl: Define Panel power ctrl register drm/i915/icl: Define display GPIO pins for DSI HACK: drm/i915/icl: Add changes to program DSI panel GPIOs HACK: drm/i915/icl: Configure backlight functions for DSI drivers/gpu/drm/i915/i915_reg.h | 12 + drivers/gpu/drm/i915/icl_dsi.c | 417 ++- drivers/gpu/drm/i915/intel_display.c | 34 ++- drivers/gpu/drm/i915/intel_dsi_vbt.c | 58 - drivers/gpu/drm/i915/intel_panel.c | 3 +- 5 files changed, 505 insertions(+), 19 deletions(-) ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
> -Original Message- > From: Chauhan, Madhav > Sent: Monday, November 5, 2018 3:46 PM > To: Kulkarni, Vandita ; Nikula, Jani > ; intel-gfx@lists.freedesktop.org > Cc: Ville Syrjälä > Subject: RE: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling > > > -Original Message- > > From: Kulkarni, Vandita > > Sent: Monday, November 5, 2018 3:26 PM > > To: Chauhan, Madhav ; Nikula, Jani > > ; intel-gfx@lists.freedesktop.org > > Cc: Ville Syrjälä > > Subject: RE: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling > > > > > > > > > -Original Message- > > > From: Chauhan, Madhav > > > Sent: Monday, November 5, 2018 3:03 PM > > > To: Kulkarni, Vandita ; Nikula, Jani > > > ; intel-gfx@lists.freedesktop.org > > > Cc: Ville Syrjälä > > > Subject: RE: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi > > > enabling > > > > > > > -Original Message- > > > > From: Kulkarni, Vandita > > > > Sent: Monday, November 5, 2018 11:17 AM > > > > To: Nikula, Jani ; Chauhan, Madhav > > > > ; intel-gfx@lists.freedesktop.org > > > > Cc: Ville Syrjälä > > > > Subject: RE: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi > > > > enabling > > > > > > > > > > > > > > > > > -Original Message- > > > > > From: Nikula, Jani > > > > > Sent: Sunday, November 4, 2018 12:46 AM > > > > > To: Chauhan, Madhav ; intel- > > > > > g...@lists.freedesktop.org; Kulkarni, Vandita > > > > > > > > > > Cc: Ville Syrjälä > > > > > Subject: Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi > > > > > enabling > > > > > > > > > > On Sat, 03 Nov 2018, Madhav Chauhan > > > > wrote: > > > > > > On 11/2/2018 7:15 PM, Jani Nikula wrote: > > > > > >> On Fri, 02 Nov 2018, Jani Nikula wrote: > > > > > >>> Next version of [1]. Sorry for the spam, needed to get the > > > > > >>> authorship straight. Fixed power domains and compute config > > > > > >>> hook > > > > > initialization. > > > > > >> It looks like DDI intel_ddi_get_hw_state() returns true for > > > > > >> ICL DSI > > > > Yes, it does, checked on Jani's latest branch. > > > > > >> as well. I'm not sure how this wasn't a problem before, but > > > > > >> if I'm not mistaken it is now. > > > > > >> > > > > > >> At least that's my only explanation to intel_ddi_get_config() > > > > > >> hitting (transcoder_is_dsi(cpu_transcoder)). > > > > > > > > > > > > I didn't observe that while testing. Where can we access the > > > > > > complete > > > > log?? > > > > Sent. > > > > > > There were some patches from Clock enabling and one hack wrt to VBT > > parsing. > > > Vandita will be trying with those. > > Thanks Madhav, but looks like just that is not enough. Will keep you posted. > Ok. So you included VBT Patch + PLL Enabling + Clock gate/ungated patches. Yes. > Whats the issue now?? Still WARN_ON?? Looks like the VBT hack fixes the WARN_ON and the ddi calls. Thanks for the help. Unfortunately, it doesn't boot, even with the above recipe. There is a hard hang. Regards, Vandita > > Regards, > Madhav > > > > > Regards, > > Vandita > > > > > > Regards, > > > Madhav > > > > > > > -Vandita > > > > > > > > > > Vandita reported that. > > > > > > > > > > BR, > > > > > Jani. > > > > > > > > > > > > > > > > > Regards, > > > > > > Madhav > > > > > > > > > > > >> > > > > > >> BR, > > > > > >> Jani. > > > > > >> > > > > > >> > > > > > > > > > > > > > > > > -- > > > > > Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
> -Original Message- > From: Kulkarni, Vandita > Sent: Monday, November 5, 2018 3:26 PM > To: Chauhan, Madhav ; Nikula, Jani > ; intel-gfx@lists.freedesktop.org > Cc: Ville Syrjälä > Subject: RE: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling > > > > > -Original Message- > > From: Chauhan, Madhav > > Sent: Monday, November 5, 2018 3:03 PM > > To: Kulkarni, Vandita ; Nikula, Jani > > ; intel-gfx@lists.freedesktop.org > > Cc: Ville Syrjälä > > Subject: RE: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling > > > > > -Original Message- > > > From: Kulkarni, Vandita > > > Sent: Monday, November 5, 2018 11:17 AM > > > To: Nikula, Jani ; Chauhan, Madhav > > > ; intel-gfx@lists.freedesktop.org > > > Cc: Ville Syrjälä > > > Subject: RE: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi > > > enabling > > > > > > > > > > > > > -Original Message- > > > > From: Nikula, Jani > > > > Sent: Sunday, November 4, 2018 12:46 AM > > > > To: Chauhan, Madhav ; intel- > > > > g...@lists.freedesktop.org; Kulkarni, Vandita > > > > > > > > Cc: Ville Syrjälä > > > > Subject: Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi > > > > enabling > > > > > > > > On Sat, 03 Nov 2018, Madhav Chauhan > > > wrote: > > > > > On 11/2/2018 7:15 PM, Jani Nikula wrote: > > > > >> On Fri, 02 Nov 2018, Jani Nikula wrote: > > > > >>> Next version of [1]. Sorry for the spam, needed to get the > > > > >>> authorship straight. Fixed power domains and compute config > > > > >>> hook > > > > initialization. > > > > >> It looks like DDI intel_ddi_get_hw_state() returns true for ICL > > > > >> DSI > > > Yes, it does, checked on Jani's latest branch. > > > > >> as well. I'm not sure how this wasn't a problem before, but if > > > > >> I'm not mistaken it is now. > > > > >> > > > > >> At least that's my only explanation to intel_ddi_get_config() > > > > >> hitting (transcoder_is_dsi(cpu_transcoder)). > > > > > > > > > > I didn't observe that while testing. Where can we access the > > > > > complete > > > log?? > > > Sent. > > > > There were some patches from Clock enabling and one hack wrt to VBT > parsing. > > Vandita will be trying with those. > Thanks Madhav, but looks like just that is not enough. Will keep you posted. Ok. So you included VBT Patch + PLL Enabling + Clock gate/ungated patches. Whats the issue now?? Still WARN_ON?? Regards, Madhav > > Regards, > Vandita > > > > Regards, > > Madhav > > > > > -Vandita > > > > > > > > Vandita reported that. > > > > > > > > BR, > > > > Jani. > > > > > > > > > > > > > > Regards, > > > > > Madhav > > > > > > > > > >> > > > > >> BR, > > > > >> Jani. > > > > >> > > > > >> > > > > > > > > > > > > > -- > > > > Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
> -Original Message- > From: Chauhan, Madhav > Sent: Monday, November 5, 2018 3:03 PM > To: Kulkarni, Vandita ; Nikula, Jani > ; intel-gfx@lists.freedesktop.org > Cc: Ville Syrjälä > Subject: RE: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling > > > -Original Message- > > From: Kulkarni, Vandita > > Sent: Monday, November 5, 2018 11:17 AM > > To: Nikula, Jani ; Chauhan, Madhav > > ; intel-gfx@lists.freedesktop.org > > Cc: Ville Syrjälä > > Subject: RE: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling > > > > > > > > > -Original Message- > > > From: Nikula, Jani > > > Sent: Sunday, November 4, 2018 12:46 AM > > > To: Chauhan, Madhav ; intel- > > > g...@lists.freedesktop.org; Kulkarni, Vandita > > > > > > Cc: Ville Syrjälä > > > Subject: Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi > > > enabling > > > > > > On Sat, 03 Nov 2018, Madhav Chauhan > > wrote: > > > > On 11/2/2018 7:15 PM, Jani Nikula wrote: > > > >> On Fri, 02 Nov 2018, Jani Nikula wrote: > > > >>> Next version of [1]. Sorry for the spam, needed to get the > > > >>> authorship straight. Fixed power domains and compute config hook > > > initialization. > > > >> It looks like DDI intel_ddi_get_hw_state() returns true for ICL > > > >> DSI > > Yes, it does, checked on Jani's latest branch. > > > >> as well. I'm not sure how this wasn't a problem before, but if > > > >> I'm not mistaken it is now. > > > >> > > > >> At least that's my only explanation to intel_ddi_get_config() > > > >> hitting WARN_ON(transcoder_is_dsi(cpu_transcoder)). > > > > > > > > I didn't observe that while testing. Where can we access the > > > > complete > > log?? > > Sent. > > There were some patches from Clock enabling and one hack wrt to VBT parsing. > Vandita will be trying with those. Thanks Madhav, but looks like just that is not enough. Will keep you posted. Regards, Vandita > > Regards, > Madhav > > > -Vandita > > > > > > Vandita reported that. > > > > > > BR, > > > Jani. > > > > > > > > > > > Regards, > > > > Madhav > > > > > > > >> > > > >> BR, > > > >> Jani. > > > >> > > > >> > > > > > > > > > > -- > > > Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
> -Original Message- > From: Kulkarni, Vandita > Sent: Monday, November 5, 2018 11:17 AM > To: Nikula, Jani ; Chauhan, Madhav > ; intel-gfx@lists.freedesktop.org > Cc: Ville Syrjälä > Subject: RE: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling > > > > > -Original Message- > > From: Nikula, Jani > > Sent: Sunday, November 4, 2018 12:46 AM > > To: Chauhan, Madhav ; intel- > > g...@lists.freedesktop.org; Kulkarni, Vandita > > > > Cc: Ville Syrjälä > > Subject: Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling > > > > On Sat, 03 Nov 2018, Madhav Chauhan > wrote: > > > On 11/2/2018 7:15 PM, Jani Nikula wrote: > > >> On Fri, 02 Nov 2018, Jani Nikula wrote: > > >>> Next version of [1]. Sorry for the spam, needed to get the > > >>> authorship straight. Fixed power domains and compute config hook > > initialization. > > >> It looks like DDI intel_ddi_get_hw_state() returns true for ICL DSI > Yes, it does, checked on Jani's latest branch. > > >> as well. I'm not sure how this wasn't a problem before, but if I'm > > >> not mistaken it is now. > > >> > > >> At least that's my only explanation to intel_ddi_get_config() > > >> hitting WARN_ON(transcoder_is_dsi(cpu_transcoder)). > > > > > > I didn't observe that while testing. Where can we access the complete > log?? > Sent. There were some patches from Clock enabling and one hack wrt to VBT parsing. Vandita will be trying with those. Regards, Madhav > -Vandita > > > > Vandita reported that. > > > > BR, > > Jani. > > > > > > > > Regards, > > > Madhav > > > > > >> > > >> BR, > > >> Jani. > > >> > > >> > > > > > > > -- > > Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
> -Original Message- > From: Nikula, Jani > Sent: Sunday, November 4, 2018 12:46 AM > To: Chauhan, Madhav ; intel- > g...@lists.freedesktop.org; Kulkarni, Vandita > Cc: Ville Syrjälä > Subject: Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling > > On Sat, 03 Nov 2018, Madhav Chauhan wrote: > > On 11/2/2018 7:15 PM, Jani Nikula wrote: > >> On Fri, 02 Nov 2018, Jani Nikula wrote: > >>> Next version of [1]. Sorry for the spam, needed to get the > >>> authorship straight. Fixed power domains and compute config hook > initialization. > >> It looks like DDI intel_ddi_get_hw_state() returns true for ICL DSI Yes, it does, checked on Jani's latest branch. > >> as well. I'm not sure how this wasn't a problem before, but if I'm > >> not mistaken it is now. > >> > >> At least that's my only explanation to intel_ddi_get_config() hitting > >> WARN_ON(transcoder_is_dsi(cpu_transcoder)). > > > > I didn't observe that while testing. Where can we access the complete log?? Sent. -Vandita > > Vandita reported that. > > BR, > Jani. > > > > > Regards, > > Madhav > > > >> > >> BR, > >> Jani. > >> > >> > > > > -- > Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
On Sat, 03 Nov 2018, Madhav Chauhan wrote: > On 11/2/2018 7:15 PM, Jani Nikula wrote: >> On Fri, 02 Nov 2018, Jani Nikula wrote: >>> Next version of [1]. Sorry for the spam, needed to get the authorship >>> straight. Fixed power domains and compute config hook initialization. >> It looks like DDI intel_ddi_get_hw_state() returns true for ICL DSI as >> well. I'm not sure how this wasn't a problem before, but if I'm not >> mistaken it is now. >> >> At least that's my only explanation to intel_ddi_get_config() hitting >> WARN_ON(transcoder_is_dsi(cpu_transcoder)). > > I didn't observe that while testing. Where can we access the complete log?? Vandita reported that. BR, Jani. > > Regards, > Madhav > >> >> BR, >> Jani. >> >> > -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
On 11/2/2018 7:15 PM, Jani Nikula wrote: On Fri, 02 Nov 2018, Jani Nikula wrote: Next version of [1]. Sorry for the spam, needed to get the authorship straight. Fixed power domains and compute config hook initialization. It looks like DDI intel_ddi_get_hw_state() returns true for ICL DSI as well. I'm not sure how this wasn't a problem before, but if I'm not mistaken it is now. At least that's my only explanation to intel_ddi_get_config() hitting WARN_ON(transcoder_is_dsi(cpu_transcoder)). I didn't observe that while testing. Where can we access the complete log?? Regards, Madhav BR, Jani. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
On Fri, 02 Nov 2018, Jani Nikula wrote: > Next version of [1]. Sorry for the spam, needed to get the authorship > straight. Fixed power domains and compute config hook initialization. It looks like DDI intel_ddi_get_hw_state() returns true for ICL DSI as well. I'm not sure how this wasn't a problem before, but if I'm not mistaken it is now. At least that's my only explanation to intel_ddi_get_config() hitting WARN_ON(transcoder_is_dsi(cpu_transcoder)). BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
On Fri, 02 Nov 2018, Jani Nikula wrote: > Next version of [1]. Sorry for the spam, needed to get the authorship > straight. Fixed power domains and compute config hook initialization. Also at icl-dsi-2018-11-02 branch of https://cgit.freedesktop.org/~jani/drm/ BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH v10 00/15] drm/i915/icl: dsi enabling
Next version of [1]. Sorry for the spam, needed to get the authorship straight. Fixed power domains and compute config hook initialization. BR, Jani. [1] https://patchwork.freedesktop.org/series/51011/ Jani Nikula (1): drm/i915/icl: add dummy DSI GPIO element execution function Madhav Chauhan (14): drm/i915/icl: Allocate DSI encoder/connector drm/i915/icl: Fill DSI ports info drm/i915/icl: Allocate DSI hosts and imlement host transfer drm/i915/icl: Add get config functionality for DSI drm/i915/icl: Get HW state for DSI encoder drm/i915/icl: Add DSI encoder remaining functions drm/i915/icl: Configure DSI Dual link mode drm/i915/icl: Consider DSI for getting transcoder state drm/i915/icl: Get pipe timings for DSI drm/i915/icl: Define missing bitfield for shortplug reg drm/i915/icl: Define Panel power ctrl register drm/i915/icl: Define display GPIO pins for DSI HACK: drm/i915/icl: Add changes to program DSI panel GPIOs HACK: drm/i915/icl: Configure backlight functions for DSI drivers/gpu/drm/i915/i915_reg.h | 12 + drivers/gpu/drm/i915/icl_dsi.c | 417 ++- drivers/gpu/drm/i915/intel_display.c | 34 ++- drivers/gpu/drm/i915/intel_dsi_vbt.c | 58 - drivers/gpu/drm/i915/intel_panel.c | 3 +- 5 files changed, 505 insertions(+), 19 deletions(-) -- 2.11.0 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
