Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Wa_1606679103

2019-11-13 Thread Chris Wilson
Quoting Radhakrishna Sripada (2019-11-13 23:19:53)
> Extend disabling SAMPLER_STATE prefetch workaround to gen12.
> 
> v2: Limit the WA to TGL A0 and update the WA no(Chris)
> 
> BSpec: 52890
> Cc: Chris Wilson 
> Cc: Mika Kuoppala 
> Signed-off-by: Radhakrishna Sripada 

Reviewed-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v2 1/2] drm/i915/tgl: Wa_1606679103

2019-11-13 Thread Radhakrishna Sripada
Extend disabling SAMPLER_STATE prefetch workaround to gen12.

v2: Limit the WA to TGL A0 and update the WA no(Chris)

BSpec: 52890
Cc: Chris Wilson 
Cc: Mika Kuoppala 
Signed-off-by: Radhakrishna Sripada 
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 15 ++-
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c 
b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index e4bccc14602f..da27eb1cd7cd 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1370,11 +1370,6 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, 
struct i915_wa_list *wal)
GEN7_SARCHKMD,
GEN7_DISABLE_DEMAND_PREFETCH);
 
-   /* Wa_1606682166:icl */
-   wa_write_or(wal,
-   GEN7_SARCHKMD,
-   GEN7_DISABLE_SAMPLER_PREFETCH);
-
/* Wa_1409178092:icl */
wa_write_masked_or(wal,
   GEN11_SCRATCH2,
@@ -1382,6 +1377,16 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, 
struct i915_wa_list *wal)
   0);
}
 
+   if (IS_TGL_REVID(i915, TGL_REVID_A0, TGL_REVID_A0) || IS_GEN(i915, 11)) 
{
+   /*
+* Wa_1606682166:icl
+* Wa_1606679103:tgl
+*/
+   wa_write_or(wal,
+   GEN7_SARCHKMD,
+   GEN7_DISABLE_SAMPLER_PREFETCH);
+   }
+
if (IS_GEN_RANGE(i915, 9, 11)) {
/* 
FtrPerCtxtPreemptionGranularityControl:skl,bxt,kbl,cfl,cnl,icl */
wa_masked_en(wal,
-- 
2.20.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx