Re: [Intel-gfx] [PATCH v3 06/20] drm/i915: Fix adl+ degamma LUT size

[Shankar, Uma]

> -Original Message-
> From: Intel-gfx  On Behalf Of Ville 
> Syrjala
> Sent: Monday, November 14, 2022 9:07 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH v3 06/20] drm/i915: Fix adl+ degamma LUT size
> 
> From: Ville Syrjälä 
> 
> The degamma LUT is interpolated so we need the 128th (==1.0) entry to 
> represent
> the full < 1.0 input range. Only the 129th and 130th entries are strictly for 
> the >=1.0
> extended range inputs.

Looks Good to me.
Reviewed-by: Uma Shankar 

> Signed-off-by: Ville Syrjälä 
> ---
>  drivers/gpu/drm/i915/i915_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c 
> b/drivers/gpu/drm/i915/i915_pci.c index
> 211913be40ce..c50841e36c61 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -948,7 +948,7 @@ static const struct intel_device_info adl_s_info = {  
> #define
> XE_LPD_FEATURES \
>   .display.abox_mask = GENMASK(1, 0), 
> \
>   .display.color = {  
> \
> - .degamma_lut_size = 128, .gamma_lut_size = 1024,
> \
> + .degamma_lut_size = 129, .gamma_lut_size = 1024,
> \
>   .degamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING |
>   \
>DRM_COLOR_LUT_EQUAL_CHANNELS,
>   \
>   },  
> \
> --
> 2.37.4

[Intel-gfx] [PATCH v3 06/20] drm/i915: Fix adl+ degamma LUT size

[Ville Syrjala]

From: Ville Syrjälä 

The degamma LUT is interpolated so we need the 128th (==1.0)
entry to represent the full < 1.0 input range. Only the 129th
and 130th entries are strictly for the >=1.0 extended range
inputs.

Signed-off-by: Ville Syrjälä 
---
 drivers/gpu/drm/i915/i915_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 211913be40ce..c50841e36c61 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -948,7 +948,7 @@ static const struct intel_device_info adl_s_info = {
 #define XE_LPD_FEATURES \
.display.abox_mask = GENMASK(1, 0), 
\
.display.color = {  
\
-   .degamma_lut_size = 128, .gamma_lut_size = 1024,
\
+   .degamma_lut_size = 129, .gamma_lut_size = 1024,
\
.degamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING | 
\
 DRM_COLOR_LUT_EQUAL_CHANNELS,  
\
},  
\
-- 
2.37.4