Re: [Intel-gfx] [PATCH v3 resend 4/5] drm/i915: add I915_PARAM_HAS_RESOURCE_STREAMER to i915_getparam

2015-06-29 Thread Abdiel Janulgue


On 06/24/2015 09:30 AM, Abdiel Janulgue wrote:
 
 
 On 06/16/2015 03:41 PM, Abdiel Janulgue wrote:
 This will let userspace know whether Resource Streamer is supported
 in the kernel.

 v2: Update I915_PARAM_HAS_RESOURCE_STREAMER so it's after
 I915_PARAM_HAS_GPU_RESET.
 v3: Only advertise RS support for hardware that supports it.
 
 Ping. Any status on this one?

Chris?

 

 Suggested-by: Kenneth Graunke kenn...@whitecape.org
 Cc: Kenneth Graunke kenn...@whitecape.org
 Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com
 ---
  drivers/gpu/drm/i915/i915_dma.c | 3 +++
  include/uapi/drm/i915_drm.h | 1 +
  2 files changed, 4 insertions(+)

 diff --git a/drivers/gpu/drm/i915/i915_dma.c 
 b/drivers/gpu/drm/i915/i915_dma.c
 index 88795d2..4f55f51 100644
 --- a/drivers/gpu/drm/i915/i915_dma.c
 +++ b/drivers/gpu/drm/i915/i915_dma.c
 @@ -168,6 +168,9 @@ static int i915_getparam(struct drm_device *dev, void 
 *data,
  i915.reset 
  intel_has_gpu_reset(dev);
  break;
 +case I915_PARAM_HAS_RESOURCE_STREAMER:
 +value = IS_HASWELL(dev) || INTEL_INFO(dev)-gen = 8;
 +   break;
  default:
  DRM_DEBUG(Unknown parameter %d\n, param-param);
  return -EINVAL;
 diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
 index f88cc1c..51137bd 100644
 --- a/include/uapi/drm/i915_drm.h
 +++ b/include/uapi/drm/i915_drm.h
 @@ -355,6 +355,7 @@ typedef struct drm_i915_irq_wait {
  #define I915_PARAM_SUBSLICE_TOTAL33
  #define I915_PARAM_EU_TOTAL  34
  #define I915_PARAM_HAS_GPU_RESET 35
 +#define I915_PARAM_HAS_RESOURCE_STREAMER 36
  
  typedef struct drm_i915_getparam {
  int param;

 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx
 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH v3 resend 4/5] drm/i915: add I915_PARAM_HAS_RESOURCE_STREAMER to i915_getparam

2015-06-29 Thread Chris Wilson
On Mon, Jun 29, 2015 at 10:52:22AM +0300, Abdiel Janulgue wrote:
 
 
 On 06/24/2015 09:30 AM, Abdiel Janulgue wrote:
  
  
  On 06/16/2015 03:41 PM, Abdiel Janulgue wrote:
  This will let userspace know whether Resource Streamer is supported
  in the kernel.
 
  v2: Update I915_PARAM_HAS_RESOURCE_STREAMER so it's after
  I915_PARAM_HAS_GPU_RESET.
  v3: Only advertise RS support for hardware that supports it.
  
  Ping. Any status on this one?
 
 Chris?

Run it through indent, and I'm happy with it. I think we should make it
a HAS_RESOURCE_STREAMER() macro so we can share the definition between
here and execbuf validation, but that's icing on the cake.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH v3 resend 4/5] drm/i915: add I915_PARAM_HAS_RESOURCE_STREAMER to i915_getparam

2015-06-24 Thread Abdiel Janulgue


On 06/16/2015 03:41 PM, Abdiel Janulgue wrote:
 This will let userspace know whether Resource Streamer is supported
 in the kernel.
 
 v2: Update I915_PARAM_HAS_RESOURCE_STREAMER so it's after
 I915_PARAM_HAS_GPU_RESET.
 v3: Only advertise RS support for hardware that supports it.

Ping. Any status on this one?

 
 Suggested-by: Kenneth Graunke kenn...@whitecape.org
 Cc: Kenneth Graunke kenn...@whitecape.org
 Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com
 ---
  drivers/gpu/drm/i915/i915_dma.c | 3 +++
  include/uapi/drm/i915_drm.h | 1 +
  2 files changed, 4 insertions(+)
 
 diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
 index 88795d2..4f55f51 100644
 --- a/drivers/gpu/drm/i915/i915_dma.c
 +++ b/drivers/gpu/drm/i915/i915_dma.c
 @@ -168,6 +168,9 @@ static int i915_getparam(struct drm_device *dev, void 
 *data,
   i915.reset 
   intel_has_gpu_reset(dev);
   break;
 + case I915_PARAM_HAS_RESOURCE_STREAMER:
 + value = IS_HASWELL(dev) || INTEL_INFO(dev)-gen = 8;
 +   break;
   default:
   DRM_DEBUG(Unknown parameter %d\n, param-param);
   return -EINVAL;
 diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
 index f88cc1c..51137bd 100644
 --- a/include/uapi/drm/i915_drm.h
 +++ b/include/uapi/drm/i915_drm.h
 @@ -355,6 +355,7 @@ typedef struct drm_i915_irq_wait {
  #define I915_PARAM_SUBSLICE_TOTAL 33
  #define I915_PARAM_EU_TOTAL   34
  #define I915_PARAM_HAS_GPU_RESET  35
 +#define I915_PARAM_HAS_RESOURCE_STREAMER 36
  
  typedef struct drm_i915_getparam {
   int param;
 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH v3 resend 4/5] drm/i915: add I915_PARAM_HAS_RESOURCE_STREAMER to i915_getparam

2015-06-16 Thread Abdiel Janulgue
This will let userspace know whether Resource Streamer is supported
in the kernel.

v2: Update I915_PARAM_HAS_RESOURCE_STREAMER so it's after
I915_PARAM_HAS_GPU_RESET.
v3: Only advertise RS support for hardware that supports it.

Suggested-by: Kenneth Graunke kenn...@whitecape.org
Cc: Kenneth Graunke kenn...@whitecape.org
Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com
---
 drivers/gpu/drm/i915/i915_dma.c | 3 +++
 include/uapi/drm/i915_drm.h | 1 +
 2 files changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 88795d2..4f55f51 100644
--- a/drivers/gpu/drm/i915/i915_dma.c
+++ b/drivers/gpu/drm/i915/i915_dma.c
@@ -168,6 +168,9 @@ static int i915_getparam(struct drm_device *dev, void *data,
i915.reset 
intel_has_gpu_reset(dev);
break;
+   case I915_PARAM_HAS_RESOURCE_STREAMER:
+   value = IS_HASWELL(dev) || INTEL_INFO(dev)-gen = 8;
+   break;
default:
DRM_DEBUG(Unknown parameter %d\n, param-param);
return -EINVAL;
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index f88cc1c..51137bd 100644
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -355,6 +355,7 @@ typedef struct drm_i915_irq_wait {
 #define I915_PARAM_SUBSLICE_TOTAL   33
 #define I915_PARAM_EU_TOTAL 34
 #define I915_PARAM_HAS_GPU_RESET35
+#define I915_PARAM_HAS_RESOURCE_STREAMER 36
 
 typedef struct drm_i915_getparam {
int param;
-- 
1.9.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx