Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-21 Thread Ville Syrjälä 
On Thu, Sep 21, 2023 at 08:34:35AM +, Govindapillai, Vinod wrote:
> On Wed, 2023-09-13 at 13:38 +0300, Ville Syrjälä wrote:
> > On Mon, Sep 04, 2023 at 02:55:17PM +0300, Vinod Govindapillai wrote:
> > > For LNL onwards, FBC can be supported on planes with per
> > > pixel alpha
> > > 
> > > Bspec: 69560
> > > Signed-off-by: Vinod Govindapillai 
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c 
> > > b/drivers/gpu/drm/i915/display/intel_fbc.c
> > > index a3999ad95a19..c0e4caec03ea 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> > > @@ -1209,7 +1209,8 @@ static int intel_fbc_check_plane(struct 
> > > intel_atomic_state *state,
> > > return 0;
> > > }
> > >  
> > > -   if (plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE 
> > > &&
> > > +   if (DISPLAY_VER(i915) < 20 &&
> > 
> > Bspec still says 15. Someone needs to figure this mess out for
> > all LNL patches.
> > 
> > > +   plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE 
> > > &&
> > >     fb->format->has_alpha) {
> > 
> > We would have already rejected the pixel format earlier, so atm this
> > check is redundant.
> 
> Hi,
> 
> Could you please clarify this.

pixel_format_is_valid()

-- 
Ville Syrjälä
Intel

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-21 Thread Govindapillai, Vinod 
On Wed, 2023-09-13 at 13:38 +0300, Ville Syrjälä wrote:
> On Mon, Sep 04, 2023 at 02:55:17PM +0300, Vinod Govindapillai wrote:
> > For LNL onwards, FBC can be supported on planes with per
> > pixel alpha
> > 
> > Bspec: 69560
> > Signed-off-by: Vinod Govindapillai 
> > ---
> >  drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c 
> > b/drivers/gpu/drm/i915/display/intel_fbc.c
> > index a3999ad95a19..c0e4caec03ea 100644
> > --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> > +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> > @@ -1209,7 +1209,8 @@ static int intel_fbc_check_plane(struct 
> > intel_atomic_state *state,
> > return 0;
> > }
> >  
> > -   if (plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
> > +   if (DISPLAY_VER(i915) < 20 &&
> 
> Bspec still says 15. Someone needs to figure this mess out for
> all LNL patches.
> 
> > +   plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
> >     fb->format->has_alpha) {
> 
> We would have already rejected the pixel format earlier, so atm this
> check is redundant.

Hi,

Could you please clarify this.

This is an existing check and I just added to limit this versions before 20.
As we have this FBC possibility to plane 0/1/2, isn't this restriction not 
applied to any of those
planes as well. 

Though at the moment there is no possibility to set FBC any one of this 
possibility explicitly, we
plan to have some IGT cases where we would like to validate this feature by 
having cases with only 0
or 1 or 2 plane and check FBC is enablement is okay.

BR
Vinod

> 
> > plane_state->no_fbc_reason = "per-pixel alpha not 
> > supported";
> > return 0;
> > -- 
> > 2.34.1
>

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-13 Thread Govindapillai, Vinod 
Hi Ville,

It was confirmed by Jani Nikula that it is 20. Here is his comments.

" display ver 20 is what the hardware reports to us. the current info is at 
bspecb70821  if you scroll down to "LNL GMD Architecture IDs"
"

Br
Vinod



From: Ville Syrjälä 
Sent: Wednesday, September 13, 2023 1:38:23 PM
To: Govindapillai, Vinod 
Cc: intel...@lists.freedesktop.org ; Roper, 
Matthew D ; intel-gfx@lists.freedesktop.org 
; Syrjala, Ville 
Subject: Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per 
pixel alpha

On Mon, Sep 04, 2023 at 02:55:17PM +0300, Vinod Govindapillai wrote:
> For LNL onwards, FBC can be supported on planes with per
> pixel alpha
>
> Bspec: 69560
> Signed-off-by: Vinod Govindapillai 
> ---
>  drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c 
> b/drivers/gpu/drm/i915/display/intel_fbc.c
> index a3999ad95a19..c0e4caec03ea 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1209,7 +1209,8 @@ static int intel_fbc_check_plane(struct 
> intel_atomic_state *state,
>return 0;
>}
>
> - if (plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
> + if (DISPLAY_VER(i915) < 20 &&

Bspec still says 15. Someone needs to figure this mess out for
all LNL patches.

> + plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
>fb->format->has_alpha) {

We would have already rejected the pixel format earlier, so atm this
check is redundant.

>plane_state->no_fbc_reason = "per-pixel alpha not supported";
>return 0;
> --
> 2.34.1

--
Ville Syrjälä
Intel

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-13 Thread Ville Syrjälä 
On Mon, Sep 04, 2023 at 02:55:17PM +0300, Vinod Govindapillai wrote:
> For LNL onwards, FBC can be supported on planes with per
> pixel alpha
> 
> Bspec: 69560
> Signed-off-by: Vinod Govindapillai 
> ---
>  drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c 
> b/drivers/gpu/drm/i915/display/intel_fbc.c
> index a3999ad95a19..c0e4caec03ea 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1209,7 +1209,8 @@ static int intel_fbc_check_plane(struct 
> intel_atomic_state *state,
>   return 0;
>   }
>  
> - if (plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
> + if (DISPLAY_VER(i915) < 20 &&

Bspec still says 15. Someone needs to figure this mess out for
all LNL patches.

> + plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
>   fb->format->has_alpha) {

We would have already rejected the pixel format earlier, so atm this
check is redundant.

>   plane_state->no_fbc_reason = "per-pixel alpha not supported";
>   return 0;
> -- 
> 2.34.1

-- 
Ville Syrjälä
Intel

[Intel-gfx] [PATCH v4 2/2] drm/i915/lnl: FBC is supported with per pixel alpha

2023-09-04 Thread Vinod Govindapillai 
For LNL onwards, FBC can be supported on planes with per
pixel alpha

Bspec: 69560
Signed-off-by: Vinod Govindapillai 
---
 drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c 
b/drivers/gpu/drm/i915/display/intel_fbc.c
index a3999ad95a19..c0e4caec03ea 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -1209,7 +1209,8 @@ static int intel_fbc_check_plane(struct 
intel_atomic_state *state,
return 0;
}
 
-   if (plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
+   if (DISPLAY_VER(i915) < 20 &&
+   plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
fb->format->has_alpha) {
plane_state->no_fbc_reason = "per-pixel alpha not supported";
return 0;
-- 
2.34.1