Re: [Intel-gfx] [PATCH v4 9/9] drm/i915/mtl+: Don't enable the AUX_IO power for non-eDP port main links
On Thu, Nov 17, 2022 at 03:24:51PM +0200, Ville Syrjälä wrote: > On Mon, Nov 14, 2022 at 02:22:51PM +0200, Imre Deak wrote: > > MTL+ requires the AUX_IO power for the main link only on eDP, so don't > > enable it in other cases. > > > > v2: > > - Rebased on checking intel_encoder_can_psr() instead of crtc->has_psr. > > > > Cc: Ville Syrjälä > > Signed-off-by: Imre Deak > > --- > > drivers/gpu/drm/i915/display/intel_ddi.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c > > b/drivers/gpu/drm/i915/display/intel_ddi.c > > index 0231b273e1673..9bf303e166e1a 100644 > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > > @@ -868,8 +868,9 @@ intel_ddi_main_link_aux_domain(struct > > intel_digital_port *dig_port, > > */ > > if (intel_encoder_can_psr(&dig_port->base)) > > return intel_display_power_aux_io_domain(i915, > > dig_port->aux_ch); > > - else if (intel_crtc_has_dp_encoder(crtc_state) || > > -intel_phy_is_tc(i915, phy)) > > + else if (DISPLAY_VER(i915) < 14 && > > +(intel_crtc_has_dp_encoder(crtc_state) || > > You want to keep that for now, and maybe remove later I guess? Yes, according to https://lore.kernel.org/intel-gfx/20221107170917.3566758-5-imre.d...@intel.com/T/#m49ef1ce586700e1 > Series looks OK to me. > Reviewed-by: Ville Syrjälä Thanks. > > > + intel_phy_is_tc(i915, phy))) > > return intel_aux_power_domain(dig_port); > > else > > return POWER_DOMAIN_INVALID; > > -- > > 2.37.1 > > -- > Ville Syrjälä > Intel
Re: [Intel-gfx] [PATCH v4 9/9] drm/i915/mtl+: Don't enable the AUX_IO power for non-eDP port main links
On Mon, Nov 14, 2022 at 02:22:51PM +0200, Imre Deak wrote: > MTL+ requires the AUX_IO power for the main link only on eDP, so don't > enable it in other cases. > > v2: > - Rebased on checking intel_encoder_can_psr() instead of crtc->has_psr. > > Cc: Ville Syrjälä > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c > b/drivers/gpu/drm/i915/display/intel_ddi.c > index 0231b273e1673..9bf303e166e1a 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -868,8 +868,9 @@ intel_ddi_main_link_aux_domain(struct intel_digital_port > *dig_port, >*/ > if (intel_encoder_can_psr(&dig_port->base)) > return intel_display_power_aux_io_domain(i915, > dig_port->aux_ch); > - else if (intel_crtc_has_dp_encoder(crtc_state) || > - intel_phy_is_tc(i915, phy)) > + else if (DISPLAY_VER(i915) < 14 && > + (intel_crtc_has_dp_encoder(crtc_state) || You want to keep that for now, and maybe remove later I guess? Series looks OK to me. Reviewed-by: Ville Syrjälä > + intel_phy_is_tc(i915, phy))) > return intel_aux_power_domain(dig_port); > else > return POWER_DOMAIN_INVALID; > -- > 2.37.1 -- Ville Syrjälä Intel
[Intel-gfx] [PATCH v4 9/9] drm/i915/mtl+: Don't enable the AUX_IO power for non-eDP port main links
MTL+ requires the AUX_IO power for the main link only on eDP, so don't enable it in other cases. v2: - Rebased on checking intel_encoder_can_psr() instead of crtc->has_psr. Cc: Ville Syrjälä Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_ddi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 0231b273e1673..9bf303e166e1a 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -868,8 +868,9 @@ intel_ddi_main_link_aux_domain(struct intel_digital_port *dig_port, */ if (intel_encoder_can_psr(&dig_port->base)) return intel_display_power_aux_io_domain(i915, dig_port->aux_ch); - else if (intel_crtc_has_dp_encoder(crtc_state) || -intel_phy_is_tc(i915, phy)) + else if (DISPLAY_VER(i915) < 14 && +(intel_crtc_has_dp_encoder(crtc_state) || + intel_phy_is_tc(i915, phy))) return intel_aux_power_domain(dig_port); else return POWER_DOMAIN_INVALID; -- 2.37.1
