Re: [Intel-gfx] [PATCH v8 20/38] drm/i915/icl: Add DSI packet payload/header registers

2018-11-01 Thread Jani Nikula
On Wed, 31 Oct 2018, Madhav Chauhan  wrote:
> On 10/30/2018 5:26 PM, Jani Nikula wrote:
>> From: Madhav Chauhan 
>>
>> This patch defines payload/header registers for each DSI
>> transcoder used for transmitting DSI packets.
>>
>> v2 by Jani:
>>   - Drop full register mask and shift for payload
>>   - Use lower case for hex 0x
>
> v2 change are fine.

Thanks, pushed.

BR,
Jani.

>
> Regards,
> Madhav
>
>>
>> Signed-off-by: Madhav Chauhan 
>> Signed-off-by: Jani Nikula 
>> ---
>>   drivers/gpu/drm/i915/i915_reg.h | 22 ++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_reg.h 
>> b/drivers/gpu/drm/i915/i915_reg.h
>> index 8d089ef848b2..639667d0fb00 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -10523,6 +10523,28 @@ enum skl_power_gate {
>>   #define  MAX_HEADER_CREDIT 0x10
>>   #define  MAX_PLOAD_CREDIT  0x40
>>   
>> +#define _DSI_CMD_TXHDR_00x6b100
>> +#define _DSI_CMD_TXHDR_10x6b900
>> +#define DSI_CMD_TXHDR(tc)   _MMIO_DSI(tc,   \
>> +  _DSI_CMD_TXHDR_0,\
>> +  _DSI_CMD_TXHDR_1)
>> +#define  PAYLOAD_PRESENT(1 << 31)
>> +#define  LP_DATA_TRANSFER   (1 << 30)
>> +#define  VBLANK_FENCE   (1 << 29)
>> +#define  PARAM_WC_MASK  (0x << 8)
>> +#define  PARAM_WC_LOWER_SHIFT   8
>> +#define  PARAM_WC_UPPER_SHIFT   16
>> +#define  VC_MASK(0x3 << 6)
>> +#define  VC_SHIFT   6
>> +#define  DT_MASK(0x3f << 0)
>> +#define  DT_SHIFT   0
>> +
>> +#define _DSI_CMD_TXPYLD_0   0x6b104
>> +#define _DSI_CMD_TXPYLD_1   0x6b904
>> +#define DSI_CMD_TXPYLD(tc)  _MMIO_DSI(tc,   \
>> +  _DSI_CMD_TXPYLD_0,\
>> +  _DSI_CMD_TXPYLD_1)
>> +
>>   #define _DSI_LP_MSG_0  0x6b0d8
>>   #define _DSI_LP_MSG_1  0x6b8d8
>>   #define DSI_LP_MSG(tc) _MMIO_DSI(tc,   \
>

-- 
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH v8 20/38] drm/i915/icl: Add DSI packet payload/header registers

2018-10-31 Thread Madhav Chauhan

On 10/30/2018 5:26 PM, Jani Nikula wrote:

From: Madhav Chauhan 

This patch defines payload/header registers for each DSI
transcoder used for transmitting DSI packets.

v2 by Jani:
  - Drop full register mask and shift for payload
  - Use lower case for hex 0x


v2 change are fine.

Regards,
Madhav



Signed-off-by: Madhav Chauhan 
Signed-off-by: Jani Nikula 
---
  drivers/gpu/drm/i915/i915_reg.h | 22 ++
  1 file changed, 22 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 8d089ef848b2..639667d0fb00 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -10523,6 +10523,28 @@ enum skl_power_gate {
  #define  MAX_HEADER_CREDIT0x10
  #define  MAX_PLOAD_CREDIT 0x40
  
+#define _DSI_CMD_TXHDR_0		0x6b100

+#define _DSI_CMD_TXHDR_1   0x6b900
+#define DSI_CMD_TXHDR(tc)  _MMIO_DSI(tc,   \
+ _DSI_CMD_TXHDR_0,\
+ _DSI_CMD_TXHDR_1)
+#define  PAYLOAD_PRESENT   (1 << 31)
+#define  LP_DATA_TRANSFER  (1 << 30)
+#define  VBLANK_FENCE  (1 << 29)
+#define  PARAM_WC_MASK (0x << 8)
+#define  PARAM_WC_LOWER_SHIFT  8
+#define  PARAM_WC_UPPER_SHIFT  16
+#define  VC_MASK   (0x3 << 6)
+#define  VC_SHIFT  6
+#define  DT_MASK   (0x3f << 0)
+#define  DT_SHIFT  0
+
+#define _DSI_CMD_TXPYLD_0  0x6b104
+#define _DSI_CMD_TXPYLD_1  0x6b904
+#define DSI_CMD_TXPYLD(tc) _MMIO_DSI(tc,   \
+ _DSI_CMD_TXPYLD_0,\
+ _DSI_CMD_TXPYLD_1)
+
  #define _DSI_LP_MSG_0 0x6b0d8
  #define _DSI_LP_MSG_1 0x6b8d8
  #define DSI_LP_MSG(tc)_MMIO_DSI(tc,   \


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH v8 20/38] drm/i915/icl: Add DSI packet payload/header registers

2018-10-30 Thread Jani Nikula
From: Madhav Chauhan 

This patch defines payload/header registers for each DSI
transcoder used for transmitting DSI packets.

v2 by Jani:
 - Drop full register mask and shift for payload
 - Use lower case for hex 0x

Signed-off-by: Madhav Chauhan 
Signed-off-by: Jani Nikula 
---
 drivers/gpu/drm/i915/i915_reg.h | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 8d089ef848b2..639667d0fb00 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -10523,6 +10523,28 @@ enum skl_power_gate {
 #define  MAX_HEADER_CREDIT 0x10
 #define  MAX_PLOAD_CREDIT  0x40
 
+#define _DSI_CMD_TXHDR_0   0x6b100
+#define _DSI_CMD_TXHDR_1   0x6b900
+#define DSI_CMD_TXHDR(tc)  _MMIO_DSI(tc,   \
+ _DSI_CMD_TXHDR_0,\
+ _DSI_CMD_TXHDR_1)
+#define  PAYLOAD_PRESENT   (1 << 31)
+#define  LP_DATA_TRANSFER  (1 << 30)
+#define  VBLANK_FENCE  (1 << 29)
+#define  PARAM_WC_MASK (0x << 8)
+#define  PARAM_WC_LOWER_SHIFT  8
+#define  PARAM_WC_UPPER_SHIFT  16
+#define  VC_MASK   (0x3 << 6)
+#define  VC_SHIFT  6
+#define  DT_MASK   (0x3f << 0)
+#define  DT_SHIFT  0
+
+#define _DSI_CMD_TXPYLD_0  0x6b104
+#define _DSI_CMD_TXPYLD_1  0x6b904
+#define DSI_CMD_TXPYLD(tc) _MMIO_DSI(tc,   \
+ _DSI_CMD_TXPYLD_0,\
+ _DSI_CMD_TXPYLD_1)
+
 #define _DSI_LP_MSG_0  0x6b0d8
 #define _DSI_LP_MSG_1  0x6b8d8
 #define DSI_LP_MSG(tc) _MMIO_DSI(tc,   \
-- 
2.11.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx