Re: [Intel-gfx] [PULL] git-fixes for 4.16-rc2

2018-02-21 Thread Chris Wilson 
Quoting Zhenyu Wang (2018-02-22 03:13:19)
> On 2018.02.20 20:15:22 +, Chris Wilson wrote:
> > Quoting Zhenyu Wang (2018-02-14 05:28:27)
> > > 
> > > Hi, here's current gvt-fixes pull for 4.16-rc2, as it is close for
> > > chinese new year, team would take one week off at least, so like to
> > > send this out before vacation. This has one to fix GTT mmio 8b access
> > > from guest and two simple ones for mmio switch and typo fix. And sorry
> > > that patchwork link is still not there yet, using dim to pull should
> > > be ok but might need direct push to skip dim push check for now.
> > 
> > There are still quite a few sore points that would be nice to fix:
> > 
> > drivers/gpu/drm/i915/gvt/handlers.c:203 sanitize_fence_mmio_access()
> > error: 'vgpu' dereferencing possible ERR_PTR()
> > drivers/gpu/drm/i915/gvt/handlers.c:323 gdrst_mmio_write() warn:
> > inconsistent indenting
> > drivers/gpu/drm/i915/gvt/handlers.c:871 dp_aux_ch_ctl_mmio_write()
> > error: buffer overflow 'display->ports' 5 <= 5
> > drivers/gpu/drm/i915/gvt/handlers.c:1392 hws_pga_write() error: 'vgpu'
> > dereferencing possible ERR_PTR()
> > drivers/gpu/drm/i915/gvt/handlers.c:1402 hws_pga_write() error: 'vgpu'
> > dereferencing possible ERR_PTR()
> > 
> > + Lots of kerneldoc errors that should be tidied up.
> 
> Chris, thanks for this, we will double check those smatch warnings.
> 
> Strange thing is that 0day kernel does run kinds of static checker
> against our tree, but seems reports are sent to Dan instead of our
> developers...

Dan Carpenter is the developer behind smatch, and he runs and sends
reports himself. It's a reasonable tool for its signal:noise ratio.
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PULL] git-fixes for 4.16-rc2

2018-02-21 Thread Zhenyu Wang 
On 2018.02.20 20:15:22 +, Chris Wilson wrote:
> Quoting Zhenyu Wang (2018-02-14 05:28:27)
> > 
> > Hi, here's current gvt-fixes pull for 4.16-rc2, as it is close for
> > chinese new year, team would take one week off at least, so like to
> > send this out before vacation. This has one to fix GTT mmio 8b access
> > from guest and two simple ones for mmio switch and typo fix. And sorry
> > that patchwork link is still not there yet, using dim to pull should
> > be ok but might need direct push to skip dim push check for now.
> 
> There are still quite a few sore points that would be nice to fix:
> 
> drivers/gpu/drm/i915/gvt/handlers.c:203 sanitize_fence_mmio_access()
> error: 'vgpu' dereferencing possible ERR_PTR()
> drivers/gpu/drm/i915/gvt/handlers.c:323 gdrst_mmio_write() warn:
> inconsistent indenting
> drivers/gpu/drm/i915/gvt/handlers.c:871 dp_aux_ch_ctl_mmio_write()
> error: buffer overflow 'display->ports' 5 <= 5
> drivers/gpu/drm/i915/gvt/handlers.c:1392 hws_pga_write() error: 'vgpu'
> dereferencing possible ERR_PTR()
> drivers/gpu/drm/i915/gvt/handlers.c:1402 hws_pga_write() error: 'vgpu'
> dereferencing possible ERR_PTR()
> 
> + Lots of kerneldoc errors that should be tidied up.

Chris, thanks for this, we will double check those smatch warnings.

Strange thing is that 0day kernel does run kinds of static checker
against our tree, but seems reports are sent to Dan instead of our
developers...

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827


signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PULL] git-fixes for 4.16-rc2

2018-02-20 Thread Chris Wilson 
Quoting Zhenyu Wang (2018-02-14 05:28:27)
> 
> Hi, here's current gvt-fixes pull for 4.16-rc2, as it is close for
> chinese new year, team would take one week off at least, so like to
> send this out before vacation. This has one to fix GTT mmio 8b access
> from guest and two simple ones for mmio switch and typo fix. And sorry
> that patchwork link is still not there yet, using dim to pull should
> be ok but might need direct push to skip dim push check for now.

There are still quite a few sore points that would be nice to fix:

drivers/gpu/drm/i915/gvt/handlers.c:203 sanitize_fence_mmio_access()
error: 'vgpu' dereferencing possible ERR_PTR()
drivers/gpu/drm/i915/gvt/handlers.c:323 gdrst_mmio_write() warn:
inconsistent indenting
drivers/gpu/drm/i915/gvt/handlers.c:871 dp_aux_ch_ctl_mmio_write()
error: buffer overflow 'display->ports' 5 <= 5
drivers/gpu/drm/i915/gvt/handlers.c:1392 hws_pga_write() error: 'vgpu'
dereferencing possible ERR_PTR()
drivers/gpu/drm/i915/gvt/handlers.c:1402 hws_pga_write() error: 'vgpu'
dereferencing possible ERR_PTR()

+ Lots of kerneldoc errors that should be tidied up.
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PULL] git-fixes for 4.16-rc2

2018-02-14 Thread Rodrigo Vivi 
Zhenyu Wang  writes:

> Hi, here's current gvt-fixes pull for 4.16-rc2, as it is close for
> chinese new year, team would take one week off at least, so like to
> send this out before vacation. This has one to fix GTT mmio 8b access
> from guest and two simple ones for mmio switch and typo fix.

Applied already. Thanks.

> And sorry
> that patchwork link is still not there yet, using dim to pull should
> be ok but might need direct push to skip dim push check for now.

It was funny, but dim didn't complained this time about signatures or
links. Just went through cleanly without any bypass.

I'm not sure what we have specially on next-fixes apply pull that end up
needing my signature and complaining about links that doesn't happen
here. I will check later

>
> thanks
> --
> The following changes since commit 4b8b41d15d9db54703958fbd2928a2fd319563f6:
>
>   drm/i915/pmu: Fix building without CONFIG_PM (2018-02-13 16:56:06 -0800)
>
> are available in the Git repository at:
>
>   https://github.com/intel/gvt-linux.git tags/gvt-fixes-2018-02-14
>
> for you to fetch changes up to 3cc7644e4af179e79153b1fd60f9dd937ee32684:
>
>   drm/i915/gvt: fix one typo of render_mmio trace (2018-02-14 10:35:00 +0800)
>
> 
> gvt-fixes-2018-02-14
>
> - gtt mmio 8b access fix (Tina)
> - one KBL required mmio reg for switch (Weinan)
> - one trace log typo fix (Weinan)
>
> 
> Tina Zhang (1):
>   drm/i915/gvt: Support BAR0 8-byte reads/writes
>
> Weinan Li (2):
>   drm/i915/gvt: add 0xe4f0 into gen9 render list
>   drm/i915/gvt: fix one typo of render_mmio trace
>
>  drivers/gpu/drm/i915/gvt/kvmgt.c| 51 
> +++--
>  drivers/gpu/drm/i915/gvt/mmio_context.c |  1 +
>  drivers/gpu/drm/i915/gvt/trace.h|  2 +-
>  3 files changed, 51 insertions(+), 3 deletions(-)
>
> -- 
> Open Source Technology Center, Intel ltd.
>
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PULL] git-fixes for 4.16-rc2

2018-02-13 Thread Zhenyu Wang 

Hi, here's current gvt-fixes pull for 4.16-rc2, as it is close for
chinese new year, team would take one week off at least, so like to
send this out before vacation. This has one to fix GTT mmio 8b access
from guest and two simple ones for mmio switch and typo fix. And sorry
that patchwork link is still not there yet, using dim to pull should
be ok but might need direct push to skip dim push check for now.

thanks
--
The following changes since commit 4b8b41d15d9db54703958fbd2928a2fd319563f6:

  drm/i915/pmu: Fix building without CONFIG_PM (2018-02-13 16:56:06 -0800)

are available in the Git repository at:

  https://github.com/intel/gvt-linux.git tags/gvt-fixes-2018-02-14

for you to fetch changes up to 3cc7644e4af179e79153b1fd60f9dd937ee32684:

  drm/i915/gvt: fix one typo of render_mmio trace (2018-02-14 10:35:00 +0800)


gvt-fixes-2018-02-14

- gtt mmio 8b access fix (Tina)
- one KBL required mmio reg for switch (Weinan)
- one trace log typo fix (Weinan)


Tina Zhang (1):
  drm/i915/gvt: Support BAR0 8-byte reads/writes

Weinan Li (2):
  drm/i915/gvt: add 0xe4f0 into gen9 render list
  drm/i915/gvt: fix one typo of render_mmio trace

 drivers/gpu/drm/i915/gvt/kvmgt.c| 51 +++--
 drivers/gpu/drm/i915/gvt/mmio_context.c |  1 +
 drivers/gpu/drm/i915/gvt/trace.h|  2 +-
 3 files changed, 51 insertions(+), 3 deletions(-)

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827


signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx