Re: [Intel-gfx] [REVERT] - drm/i915: Removing TV Out modes
Hi there, Most of these modes aren't present in any of our documents and since they aren't standards I think no sense let them there. However I removed 480p and 576p by mistake. either looking to a closed version of document that wont be released or thinking that they were already contempled by one of modes that were there after the refresh rates were fixed... I think a patch to add these 2 missing modes better than a full revert... I'm going to do this right now... but it is up to you revert the old one entirely or accept this new one. On Sat, May 19, 2012 at 3:42 PM, Daniel Vetter wrote: > On Sat, May 19, 2012 at 09:41:00PM +1000, Robert Lowery wrote: >> Further to my previous post regarding getting TV Out working on recent >> kernels, I see a recent check in to the mainline kernel source removed >> support for 576p TV output which I use. >> >> Could someone please revert >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=55a6713b3f30a5024056027e9dbf03ac8f13bfc9 >> or at least reinstate the 576p mode that I use. >> >> I think 480p@59.94Hz is also a valid mode (though I don't use it) and >> should be left in and perhaps be renamed to just 480p since there is now >> no need to differentiate frequencies. >> >> Something like this? > > Hm, I have no idea whether we should just revert the entire commit. > Rodrigo, your commit > > commit 55a6713b3f30a5024056027e9dbf03ac8f13bfc9 > Author: Rodrigo Vivi > Date: Thu Dec 15 14:47:33 2011 -0200 > > drm/i915: Removing TV Out modes. > > is a bit thin on justification as to why we need that. Can you please > explain? > > Thanks, Daniel > -- > Daniel Vetter > Mail: dan...@ffwll.ch > Mobile: +41 (0)79 365 57 48 -- Rodrigo Vivi Blog: http://blog.vivi.eng.br ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [REVERT] - drm/i915: Removing TV Out modes
On Sat, May 19, 2012 at 09:41:00PM +1000, Robert Lowery wrote: > Further to my previous post regarding getting TV Out working on recent > kernels, I see a recent check in to the mainline kernel source removed > support for 576p TV output which I use. > > Could someone please revert > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=55a6713b3f30a5024056027e9dbf03ac8f13bfc9 > or at least reinstate the 576p mode that I use. > > I think 480p@59.94Hz is also a valid mode (though I don't use it) and > should be left in and perhaps be renamed to just 480p since there is now > no need to differentiate frequencies. > > Something like this? Hm, I have no idea whether we should just revert the entire commit. Rodrigo, your commit commit 55a6713b3f30a5024056027e9dbf03ac8f13bfc9 Author: Rodrigo Vivi Date: Thu Dec 15 14:47:33 2011 -0200 drm/i915: Removing TV Out modes. is a bit thin on justification as to why we need that. Can you please explain? Thanks, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [REVERT] - drm/i915: Removing TV Out modes
Further to my previous post regarding getting TV Out working on recent
kernels, I see a recent check in to the mainline kernel source removed
support for 576p TV output which I use.
Could someone please revert
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=55a6713b3f30a5024056027e9dbf03ac8f13bfc9
or at least reinstate the 576p mode that I use.
I think 480p@59.94Hz is also a valid mode (though I don't use it) and
should be left in and perhaps be renamed to just 480p since there is now
no need to differentiate frequencies.
Something like this?
--- intel_tv.c.orig 2012-05-19 17:06:11.0 +1000
+++ intel_tv.c 2012-05-19 17:19:52.0 +1000
@@ -674,6 +674,54 @@ static const struct tv_mode tv_modes[] =
.filter_table = filter_table,
},
{
+ .name = "480p",
+ .clock = 107520,
+ .refresh= 59940,
+ .oversample = TV_OVERSAMPLE_4X,
+ .component_only = 1,
+
+ .hsync_end = 64, .hblank_end = 122,
+ .hblank_start = 842, .htotal = 857,
+
+ .progressive= true, .trilevel_sync = false,
+
+ .vsync_start_f1 = 12, .vsync_start_f2 = 12,
+ .vsync_len = 12,
+
+ .veq_ena= false,
+
+ .vi_end_f1 = 44, .vi_end_f2 = 44,
+ .nbr_end= 479,
+
+ .burst_ena = false,
+
+ .filter_table = filter_table,
+ },
+ {
+ .name = "576p",
+ .clock = 107520,
+ .refresh= 5,
+ .oversample = TV_OVERSAMPLE_4X,
+ .component_only = 1,
+
+ .hsync_end = 64, .hblank_end = 139,
+ .hblank_start = 859, .htotal = 863,
+
+ .progressive= true, .trilevel_sync = false,
+
+ .vsync_start_f1 = 10, .vsync_start_f2 = 10,
+ .vsync_len = 10,
+
+ .veq_ena= false,
+
+ .vi_end_f1 = 48, .vi_end_f2 = 48,
+ .nbr_end= 575,
+
+ .burst_ena = false,
+
+ .filter_table = filter_table,
+ },
+ {
.name = "720p@60Hz",
.clock = 148800,
.refresh= 6,
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [REVERT] - drm/i915: Removing TV Out modes
Further to my previous post regarding getting TV Out working on recent
kernels, I see a recent check in to the mainline kernel source removed
support for 576p TV output which I use.
Could someone please revert
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=55a6713b3f30a5024056027e9dbf03ac8f13bfc9
or at least reinstate the 576p mode that I use.
I think 480p@59.94Hz is also a valid mode (though I don't use it) and
should be left in and perhaps be renamed to just 480p since there is now
no need to differentiate frequencies.
Something like this?
--- intel_tv.c.orig 2012-05-19 17:06:11.0 +1000
+++ intel_tv.c 2012-05-19 17:19:52.0 +1000
@@ -674,6 +674,54 @@ static const struct tv_mode tv_modes[] =
.filter_table = filter_table,
},
{
+ .name = "480p",
+ .clock = 107520,
+ .refresh= 59940,
+ .oversample = TV_OVERSAMPLE_4X,
+ .component_only = 1,
+
+ .hsync_end = 64, .hblank_end = 122,
+ .hblank_start = 842, .htotal = 857,
+
+ .progressive= true, .trilevel_sync = false,
+
+ .vsync_start_f1 = 12, .vsync_start_f2 = 12,
+ .vsync_len = 12,
+
+ .veq_ena= false,
+
+ .vi_end_f1 = 44, .vi_end_f2 = 44,
+ .nbr_end= 479,
+
+ .burst_ena = false,
+
+ .filter_table = filter_table,
+ },
+ {
+ .name = "576p",
+ .clock = 107520,
+ .refresh= 5,
+ .oversample = TV_OVERSAMPLE_4X,
+ .component_only = 1,
+
+ .hsync_end = 64, .hblank_end = 139,
+ .hblank_start = 859, .htotal = 863,
+
+ .progressive= true, .trilevel_sync = false,
+
+ .vsync_start_f1 = 10, .vsync_start_f2 = 10,
+ .vsync_len = 10,
+
+ .veq_ena= false,
+
+ .vi_end_f1 = 48, .vi_end_f2 = 48,
+ .nbr_end= 575,
+
+ .burst_ena = false,
+
+ .filter_table = filter_table,
+ },
+ {
.name = "720p@60Hz",
.clock = 148800,
.refresh= 6,
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
