Re: [Intel-gfx] [for-CI] Revert "drm/i915: Limit the auto arming of mmio debugs on vlv/chv"
On Mon, Apr 11, 2016 at 02:37:09PM +0100, Chris Wilson wrote: > On Mon, Apr 11, 2016 at 04:31:28PM +0300, Ville Syrjälä wrote: > > On Mon, Apr 11, 2016 at 02:21:01PM +0100, Chris Wilson wrote: > > > This reverts commit c81eeea6c14b212016104f4256c65f93ad230a86. > > > > Not quite yet. I have patches pretty much line up to fix the resulting > > spew. Just got a bit sidetracked by the CHV irq problems. > > Aye, this was just probing CI to see if we can get an explanation for > some [drm:cherryview_enable_rps] GT fifo had a previous error 108 > in recent runs. Those bits aren't actually errors. They're just FIFO free space counters. -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [for-CI] Revert "drm/i915: Limit the auto arming of mmio debugs on vlv/chv"
On Mon, Apr 11, 2016 at 04:31:28PM +0300, Ville Syrjälä wrote: > On Mon, Apr 11, 2016 at 02:21:01PM +0100, Chris Wilson wrote: > > This reverts commit c81eeea6c14b212016104f4256c65f93ad230a86. > > Not quite yet. I have patches pretty much line up to fix the resulting > spew. Just got a bit sidetracked by the CHV irq problems. Aye, this was just probing CI to see if we can get an explanation for some [drm:cherryview_enable_rps] GT fifo had a previous error 108 in recent runs. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [for-CI] Revert "drm/i915: Limit the auto arming of mmio debugs on vlv/chv"
On Mon, Apr 11, 2016 at 02:21:01PM +0100, Chris Wilson wrote: > This reverts commit c81eeea6c14b212016104f4256c65f93ad230a86. Not quite yet. I have patches pretty much line up to fix the resulting spew. Just got a bit sidetracked by the CHV irq problems. > --- > drivers/gpu/drm/i915/intel_uncore.c | 9 - > 1 file changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_uncore.c > b/drivers/gpu/drm/i915/intel_uncore.c > index ac2ac07b505b..2f7fb7d169b8 100644 > --- a/drivers/gpu/drm/i915/intel_uncore.c > +++ b/drivers/gpu/drm/i915/intel_uncore.c > @@ -633,15 +633,6 @@ __unclaimed_reg_debug(struct drm_i915_private *dev_priv, > const bool read, > const bool before) > { > - /* XXX. We limit the auto arming traces for mmio > - * debugs on these platforms. There are just too many > - * revealed by these and CI/Bat suffers from the noise. > - * Please fix and then re-enable the automatic traces. > - */ > - if (i915.mmio_debug < 2 && > - (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))) > - return; > - > if (WARN(check_for_unclaimed_mmio(dev_priv), >"Unclaimed register detected %s %s register 0x%x\n", >before ? "before" : "after", > -- > 2.8.0.rc3 > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [for-CI] Revert "drm/i915: Limit the auto arming of mmio debugs on vlv/chv"
This reverts commit c81eeea6c14b212016104f4256c65f93ad230a86. --- drivers/gpu/drm/i915/intel_uncore.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index ac2ac07b505b..2f7fb7d169b8 100644 --- a/drivers/gpu/drm/i915/intel_uncore.c +++ b/drivers/gpu/drm/i915/intel_uncore.c @@ -633,15 +633,6 @@ __unclaimed_reg_debug(struct drm_i915_private *dev_priv, const bool read, const bool before) { - /* XXX. We limit the auto arming traces for mmio -* debugs on these platforms. There are just too many -* revealed by these and CI/Bat suffers from the noise. -* Please fix and then re-enable the automatic traces. -*/ - if (i915.mmio_debug < 2 && - (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))) - return; - if (WARN(check_for_unclaimed_mmio(dev_priv), "Unclaimed register detected %s %s register 0x%x\n", before ? "before" : "after", -- 2.8.0.rc3 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx