Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Pipe config debug dump diet

2016-11-18 Thread Tvrtko Ursulin


On 17/11/2016 16:52, Ville Syrjälä wrote:

On Thu, Nov 17, 2016 at 03:13:55PM +, Tvrtko Ursulin wrote:


On 17/11/2016 13:16, Patchwork wrote:

== Series Details ==

Series: Pipe config debug dump diet
URL   : https://patchwork.freedesktop.org/series/15493/
State : success

== Summary ==

Series 15493v1 Pipe config debug dump diet
https://patchwork.freedesktop.org/api/1.0/series/15493/revisions/1/mbox/


fi-bdw-5557u total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15
fi-bsw-n3050 total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40
fi-bxt-t5700 total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28
fi-byt-j1900 total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28
fi-byt-n2820 total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32
fi-hsw-4770  total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20
fi-hsw-4770r total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20
fi-ilk-650   total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53
fi-ivb-3520m total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
fi-ivb-3770  total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
fi-kbl-7200u total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
fi-skl-6260u total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14
fi-skl-6700hqtotal:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21
fi-skl-6700k total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21
fi-skl-6770hqtotal:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14
fi-snb-2520m total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32
fi-snb-2600  total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33

ccd01198820ab7286f0b98f7b28dbf6ad29fa861 drm-intel-nightly: 
2016y-11m-17d-10h-54m-57s UTC integration manifest
a9bf7b7 drm/i915: Introduce enableddisabled helper
1cd61af drm/i915: Only dump possible panel fitter config for the platform
e5069f1 drm/i915: Only dump scaler config where supported
5d6948f drm/i915: Compact a few pipe config debug lines
63a49f1 drm/i915: Don't log pipe config kernel pointer and duplicated pipe name
f711717 drm/i915: Dump FDI config only where applicable
2a89809 drm/i915: Extract intel_link_m_n config printing into a helper


Merged to dinq and thanks Maarten for the review. Unfortunately I forgot
to apply his r-b's manually before pushing. :(


I'm not a big fan of this series. It merged some totally unrelated stuff
to the same line, and I don't really like making the dump look different
depending on the output_types either. Just makes life more confusing to
look at the thing, and potentually we might fail to notice some
discrepancies.


Oh.. sorry to hear this. My logic was that absence of a line tells you 
that the respective set is not applicable/relevant so no information is 
lost. Maybe give it a few days and then if you still dislike it we can 
tweak it a bit? Maybe improve the grouping like move the pipe bpp, size 
and maybe dithering on a line. Or something.


Regards,

Tvrtko


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Pipe config debug dump diet

2016-11-17 Thread Ville Syrjälä
On Thu, Nov 17, 2016 at 03:13:55PM +, Tvrtko Ursulin wrote:
> 
> On 17/11/2016 13:16, Patchwork wrote:
> > == Series Details ==
> >
> > Series: Pipe config debug dump diet
> > URL   : https://patchwork.freedesktop.org/series/15493/
> > State : success
> >
> > == Summary ==
> >
> > Series 15493v1 Pipe config debug dump diet
> > https://patchwork.freedesktop.org/api/1.0/series/15493/revisions/1/mbox/
> >
> >
> > fi-bdw-5557u total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15
> > fi-bsw-n3050 total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40
> > fi-bxt-t5700 total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28
> > fi-byt-j1900 total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28
> > fi-byt-n2820 total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32
> > fi-hsw-4770  total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20
> > fi-hsw-4770r total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20
> > fi-ilk-650   total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53
> > fi-ivb-3520m total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
> > fi-ivb-3770  total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
> > fi-kbl-7200u total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
> > fi-skl-6260u total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14
> > fi-skl-6700hqtotal:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21
> > fi-skl-6700k total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21
> > fi-skl-6770hqtotal:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14
> > fi-snb-2520m total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32
> > fi-snb-2600  total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33
> >
> > ccd01198820ab7286f0b98f7b28dbf6ad29fa861 drm-intel-nightly: 
> > 2016y-11m-17d-10h-54m-57s UTC integration manifest
> > a9bf7b7 drm/i915: Introduce enableddisabled helper
> > 1cd61af drm/i915: Only dump possible panel fitter config for the platform
> > e5069f1 drm/i915: Only dump scaler config where supported
> > 5d6948f drm/i915: Compact a few pipe config debug lines
> > 63a49f1 drm/i915: Don't log pipe config kernel pointer and duplicated pipe 
> > name
> > f711717 drm/i915: Dump FDI config only where applicable
> > 2a89809 drm/i915: Extract intel_link_m_n config printing into a helper
> 
> Merged to dinq and thanks Maarten for the review. Unfortunately I forgot 
> to apply his r-b's manually before pushing. :(

I'm not a big fan of this series. It merged some totally unrelated stuff
to the same line, and I don't really like making the dump look different
depending on the output_types either. Just makes life more confusing to
look at the thing, and potentually we might fail to notice some
discrepancies.

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Pipe config debug dump diet

2016-11-17 Thread Tvrtko Ursulin


On 17/11/2016 13:16, Patchwork wrote:

== Series Details ==

Series: Pipe config debug dump diet
URL   : https://patchwork.freedesktop.org/series/15493/
State : success

== Summary ==

Series 15493v1 Pipe config debug dump diet
https://patchwork.freedesktop.org/api/1.0/series/15493/revisions/1/mbox/


fi-bdw-5557u total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15
fi-bsw-n3050 total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40
fi-bxt-t5700 total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28
fi-byt-j1900 total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28
fi-byt-n2820 total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32
fi-hsw-4770  total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20
fi-hsw-4770r total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20
fi-ilk-650   total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53
fi-ivb-3520m total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
fi-ivb-3770  total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
fi-kbl-7200u total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
fi-skl-6260u total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14
fi-skl-6700hqtotal:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21
fi-skl-6700k total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21
fi-skl-6770hqtotal:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14
fi-snb-2520m total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32
fi-snb-2600  total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33

ccd01198820ab7286f0b98f7b28dbf6ad29fa861 drm-intel-nightly: 
2016y-11m-17d-10h-54m-57s UTC integration manifest
a9bf7b7 drm/i915: Introduce enableddisabled helper
1cd61af drm/i915: Only dump possible panel fitter config for the platform
e5069f1 drm/i915: Only dump scaler config where supported
5d6948f drm/i915: Compact a few pipe config debug lines
63a49f1 drm/i915: Don't log pipe config kernel pointer and duplicated pipe name
f711717 drm/i915: Dump FDI config only where applicable
2a89809 drm/i915: Extract intel_link_m_n config printing into a helper


Merged to dinq and thanks Maarten for the review. Unfortunately I forgot 
to apply his r-b's manually before pushing. :(


Regards,

Tvrtko
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] ✓ Fi.CI.BAT: success for Pipe config debug dump diet

2016-11-17 Thread Patchwork
== Series Details ==

Series: Pipe config debug dump diet
URL   : https://patchwork.freedesktop.org/series/15493/
State : success

== Summary ==

Series 15493v1 Pipe config debug dump diet
https://patchwork.freedesktop.org/api/1.0/series/15493/revisions/1/mbox/


fi-bdw-5557u total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050 total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40 
fi-bxt-t5700 total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-j1900 total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820 total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770  total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-ilk-650   total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53 
fi-ivb-3520m total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-ivb-3770  total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-7200u total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hqtotal:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21 
fi-skl-6770hqtotal:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-snb-2600  total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33 

ccd01198820ab7286f0b98f7b28dbf6ad29fa861 drm-intel-nightly: 
2016y-11m-17d-10h-54m-57s UTC integration manifest
a9bf7b7 drm/i915: Introduce enableddisabled helper
1cd61af drm/i915: Only dump possible panel fitter config for the platform
e5069f1 drm/i915: Only dump scaler config where supported
5d6948f drm/i915: Compact a few pipe config debug lines
63a49f1 drm/i915: Don't log pipe config kernel pointer and duplicated pipe name
f711717 drm/i915: Dump FDI config only where applicable
2a89809 drm/i915: Extract intel_link_m_n config printing into a helper

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3035/
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx