Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Non-interface changing GuC CTBs updates (rev2)
On Thu, May 27, 2021 at 10:13:21AM -0700, John Harrison wrote: > On 5/25/2021 23:42, Patchwork wrote: > > == Series Details == > > > > Series: Non-interface changing GuC CTBs updates (rev2) > > URL : https://patchwork.freedesktop.org/series/90552/ > > State : warning > > > > == Summary == > > > > $ dim checkpatch origin/drm-tip > > 6b6bffd59ced drm/i915/guc: skip disabling CTBs before sanitizing the GuC > > 3f9bbaddbf9d drm/i915/guc: use probe_error log for CT enablement failure > > 866285dad8d0 drm/i915/guc: enable only the user interrupt when using GuC > > submission > > eafc57f85f6f drm/i915/guc: Remove sample_forcewake h2g action > > cb62a7f50e3b drm/i915/guc: Keep strict GuC ABI definitions > > -:18: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does > > MAINTAINERS need updating? > > #18: > > new file mode 100644 > > > > total: 0 errors, 1 warnings, 0 checks, 476 lines checked > > 28e9b20a7873 drm/i915/guc: Drop guc->interrupts.enabled > > 190975af8c9f drm/i915/guc: Stop using fence/status from CTB descriptor > > 15a068ac5b1e drm/i915: Promote ptrdiff() to i915_utils.h > > e3a6d58106c2 drm/i915/guc: Only rely on own CTB size > > aaa8781a008e drm/i915/guc: Don't repeat CTB layout calculations > > b065023c038e drm/i915/guc: Replace CTB array with explicit members > > 9f1ec21626ae drm/i915/guc: Update sizes of CTB buffers > > 7a0e05be601b drm/i915/guc: Relax CTB response timeout > > 11573d2c3987 drm/i915/guc: Start protecting access to CTB descriptors > > -:87: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment > > #87: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h:36: > > + spinlock_t lock; > > > > total: 0 errors, 0 warnings, 1 checks, 61 lines checked > > f32e4faa422e drm/i915/guc: Ensure H2G buffer updates visible before tail > > update > > -:23: ERROR:OPEN_BRACE: open brace '{' following function definitions go on > > the next line > > #23: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:331: > > +static void write_barrier(struct intel_guc_ct *ct) { > > > > -:31: WARNING:MEMORY_BARRIER: memory barrier without comment > > #31: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:339: > > + wmb(); > These three warnings should be fixed. > Will do. But it seems odd to require comments for these. > John. > > > total: 1 errors, 1 warnings, 0 checks, 30 lines checked > > 6feab437948e drm/i915/guc: Stop using mutex while sending CTB messages > > a44bbeef3e75 drm/i915/guc: Don't receive all G2H messages in irq handler > > 41650b9fd9e5 drm/i915/guc: Always copy CT message to new allocation > > > > > > ___ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Non-interface changing GuC CTBs updates (rev2)
On 5/25/2021 23:42, Patchwork wrote: == Series Details == Series: Non-interface changing GuC CTBs updates (rev2) URL : https://patchwork.freedesktop.org/series/90552/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6b6bffd59ced drm/i915/guc: skip disabling CTBs before sanitizing the GuC 3f9bbaddbf9d drm/i915/guc: use probe_error log for CT enablement failure 866285dad8d0 drm/i915/guc: enable only the user interrupt when using GuC submission eafc57f85f6f drm/i915/guc: Remove sample_forcewake h2g action cb62a7f50e3b drm/i915/guc: Keep strict GuC ABI definitions -:18: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 476 lines checked 28e9b20a7873 drm/i915/guc: Drop guc->interrupts.enabled 190975af8c9f drm/i915/guc: Stop using fence/status from CTB descriptor 15a068ac5b1e drm/i915: Promote ptrdiff() to i915_utils.h e3a6d58106c2 drm/i915/guc: Only rely on own CTB size aaa8781a008e drm/i915/guc: Don't repeat CTB layout calculations b065023c038e drm/i915/guc: Replace CTB array with explicit members 9f1ec21626ae drm/i915/guc: Update sizes of CTB buffers 7a0e05be601b drm/i915/guc: Relax CTB response timeout 11573d2c3987 drm/i915/guc: Start protecting access to CTB descriptors -:87: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #87: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h:36: + spinlock_t lock; total: 0 errors, 0 warnings, 1 checks, 61 lines checked f32e4faa422e drm/i915/guc: Ensure H2G buffer updates visible before tail update -:23: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #23: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:331: +static void write_barrier(struct intel_guc_ct *ct) { -:31: WARNING:MEMORY_BARRIER: memory barrier without comment #31: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:339: + wmb(); These three warnings should be fixed. John. total: 1 errors, 1 warnings, 0 checks, 30 lines checked 6feab437948e drm/i915/guc: Stop using mutex while sending CTB messages a44bbeef3e75 drm/i915/guc: Don't receive all G2H messages in irq handler 41650b9fd9e5 drm/i915/guc: Always copy CT message to new allocation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Non-interface changing GuC CTBs updates (rev2)
== Series Details == Series: Non-interface changing GuC CTBs updates (rev2) URL : https://patchwork.freedesktop.org/series/90552/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6b6bffd59ced drm/i915/guc: skip disabling CTBs before sanitizing the GuC 3f9bbaddbf9d drm/i915/guc: use probe_error log for CT enablement failure 866285dad8d0 drm/i915/guc: enable only the user interrupt when using GuC submission eafc57f85f6f drm/i915/guc: Remove sample_forcewake h2g action cb62a7f50e3b drm/i915/guc: Keep strict GuC ABI definitions -:18: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 476 lines checked 28e9b20a7873 drm/i915/guc: Drop guc->interrupts.enabled 190975af8c9f drm/i915/guc: Stop using fence/status from CTB descriptor 15a068ac5b1e drm/i915: Promote ptrdiff() to i915_utils.h e3a6d58106c2 drm/i915/guc: Only rely on own CTB size aaa8781a008e drm/i915/guc: Don't repeat CTB layout calculations b065023c038e drm/i915/guc: Replace CTB array with explicit members 9f1ec21626ae drm/i915/guc: Update sizes of CTB buffers 7a0e05be601b drm/i915/guc: Relax CTB response timeout 11573d2c3987 drm/i915/guc: Start protecting access to CTB descriptors -:87: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #87: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h:36: + spinlock_t lock; total: 0 errors, 0 warnings, 1 checks, 61 lines checked f32e4faa422e drm/i915/guc: Ensure H2G buffer updates visible before tail update -:23: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #23: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:331: +static void write_barrier(struct intel_guc_ct *ct) { -:31: WARNING:MEMORY_BARRIER: memory barrier without comment #31: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:339: + wmb(); total: 1 errors, 1 warnings, 0 checks, 30 lines checked 6feab437948e drm/i915/guc: Stop using mutex while sending CTB messages a44bbeef3e75 drm/i915/guc: Don't receive all G2H messages in irq handler 41650b9fd9e5 drm/i915/guc: Always copy CT message to new allocation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Non-interface changing GuC CTBs updates
== Series Details == Series: Non-interface changing GuC CTBs updates URL : https://patchwork.freedesktop.org/series/90552/ State : warning == Summary == $ dim checkpatch origin/drm-tip 232417d031b9 drm/i915/guc: skip disabling CTBs before sanitizing the GuC 341c70656750 drm/i915/guc: use probe_error log for CT enablement failure -:57: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #57: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:38: +#define CT_PROBE_ERROR(_ct, _fmt, ...) \ + i915_probe_error(ct_to_i915(ct), "CT: " _fmt, ##__VA_ARGS__); total: 0 errors, 1 warnings, 0 checks, 72 lines checked b6b4993218ab drm/i915/guc: enable only the user interrupt when using GuC submission 7bc25d889ff7 drm/i915/guc: Remove sample_forcewake h2g action -:11: WARNING:BAD_SIGN_OFF: Use a single space after Cc: #11: Cc: Vinay Belgaumkar total: 0 errors, 1 warnings, 0 checks, 55 lines checked a02cb3e825d6 drm/i915/guc: Keep strict GuC ABI definitions -:18: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 476 lines checked 776f36a2bce0 drm/i915/guc: Stop using fence/status from CTB descriptor 877a8bd1e6bd drm/i915: Promote ptrdiff() to i915_utils.h 62559d3051cf drm/i915/guc: Only rely on own CTB size 51f154fa0b01 drm/i915/guc: Don't repeat CTB layout calculations 23f84eb2bb28 drm/i915/guc: Replace CTB array with explicit members ef402f00ed93 drm/i915/guc: Update sizes of CTB buffers fcdee0ecb586 drm/i915/guc: Relax CTB response timeout -:7: WARNING:TYPO_SPELLING: 'procesing' may be misspelled - perhaps 'processing'? #7: parallel to the GuC for procesing, so we shouldn't assume any more ^ total: 0 errors, 1 warnings, 0 checks, 35 lines checked c48c38ded661 drm/i915/guc: Start protecting access to CTB descriptors -:87: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #87: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h:36: + spinlock_t lock; total: 0 errors, 0 warnings, 1 checks, 61 lines checked 7d0c670b963f drm/i915/guc: Ensure H2G buffer updates visible before tail update -:23: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #23: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:331: +static void write_barrier(struct intel_guc_ct *ct) { -:31: WARNING:MEMORY_BARRIER: memory barrier without comment #31: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:339: + wmb(); total: 1 errors, 1 warnings, 0 checks, 30 lines checked 29bcbe2dea0e drm/i915/guc: Stop using mutex while sending CTB messages 5e9855bcaa3f drm/i915/guc: Don't receive all G2H messages in irq handler b4f470d880ca drm/i915/guc: Always copy CT message to new allocation ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx