[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: ioctl clean-ups (rev7)
== Series Details ==
Series: drm/i915/gem: ioctl clean-ups (rev7)
URL : https://patchwork.freedesktop.org/series/89443/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
100d73aa9252 drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE
-:177: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#177:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 159 lines checked
c3f6a0807a27 drm/i915: Stop storing the ring size in the ring pointer (v2)
a9718291830e drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP
ec5522a9644b drm/i915/gem: Set the watchdog timeout directly in
intel_context_set_gem (v2)
203766899755 drm/i915/gem: Return void from context_apply_all
835c8348dc42 drm/i915: Drop the CONTEXT_CLONE API (v2)
2dad231d92fb drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4)
07f876e84333 drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES
46e86a5d9e0e drm/i915/gem: Disallow bonding of virtual engines (v3)
30fdc9fcedba drm/i915/gem: Remove engine auto-magic with FENCE_SUBMIT (v2)
969b77513f32 drm/i915/request: Remove the hook from await_execution
3d0a4c060233 drm/i915/gem: Disallow creating contexts with too many engines
79c699205313 drm/i915: Stop manually RCU banging in reset_stats_ioctl (v2)
587a7f034af2 drm/i915/gem: Add a separate validate_priority helper
d102d0429864 drm/i915: Add gem/i915_gem_context.h to the docs
3602847dade8 drm/i915/gem: Add an intermediate proto_context struct (v5)
-:281: WARNING:REPEATED_WORD: Possible repeated word: 'See'
#281: FILE: drivers/gpu/drm/i915/gem/i915_gem_context_types.h:87:
+ /** @single_timeline: See See _gem_context.syncobj */
total: 0 errors, 1 warnings, 0 checks, 260 lines checked
f6e071ec8bae drm/i915/gem: Rework error handling in default_engines
051bed0b2983 drm/i915/gem: Optionally set SSEU in intel_context_set_gem
f4cebc831245 drm/i915: Add an i915_gem_vm_lookup helper
b0db512b3247 drm/i915/gem: Make an alignment check more sensible
ff8c4049d11e drm/i915/gem: Use the proto-context to handle create parameters
(v4)
-:99: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#99: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:310:
+ unsigned num_engines;
-:280: ERROR:CODE_INDENT: code indent should use tabs where possible
#280: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:491:
+^I^I^I struct i915_gem_proto_context *pc,$
-:280: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#280: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:491:
+static int set_proto_ctx_engines(struct drm_i915_file_private *fpriv,
+struct i915_gem_proto_context *pc,
-:281: ERROR:CODE_INDENT: code indent should use tabs where possible
#281: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:492:
+^I^I^I const struct drm_i915_gem_context_param *args)$
-:384: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#384: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:595:
+ if (!!(user_sseu.flags & I915_CONTEXT_SSEU_FLAG_ENGINE_INDEX) !=
(pc->num_user_engines >= 0))
-:384: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around
'pc->num_user_engines >= 0'
#384: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:595:
+ if (!!(user_sseu.flags & I915_CONTEXT_SSEU_FLAG_ENGINE_INDEX) !=
(pc->num_user_engines >= 0))
total: 2 errors, 2 warnings, 2 checks, 688 lines checked
5d4b208bfccf drm/i915/gem: Return an error ptr from context_lookup
-:60: WARNING:LIKELY_MISUSE: nested (un)?likely() calls, IS_ERR already uses
unlikely() internally
#60: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:742:
+ if (unlikely(IS_ERR(ctx)))
total: 0 errors, 1 warnings, 0 checks, 60 lines checked
a7f403d3da97 drm/i915/gt: Drop i915_address_space::file (v2)
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit 2bfa996e031b ("drm/i915: Store
owning file on the i915_address_space")'
#9:
It was added in 2bfa996e031b ("drm/i915: Store owning file on the
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit f6e8aa387171 ("drm/i915: Report
the number of closed vma held by each context in debugfs")'
#11:
the difference between the global GTT and a PPGTT. In f6e8aa387171
-:15: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit db80a1294c23 ("drm/i915/gem:
Remove per-client stats from debugfs/i915_gem_objects")'
#15:
were entirely nuked in db80a1294c23 ("drm/i915/gem: Remove per-client
total: 3 errors, 0 warnings, 0 checks, 55 lines checked
0d52b049e5f2 drm/i915/gem: Delay context creation (v3)
b9b1b45bf4fc drm/i915/gem: Don't allow changing the VM on running contexts (v4)
77127cea6b1b drm/i915/gem: Don't allow changing the engine set on running
contexts (v3)
-:25: WARNING:TYPO_SPELLING: 'mesage' may be misspelled -
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: ioctl clean-ups (rev6)
== Series Details ==
Series: drm/i915/gem: ioctl clean-ups (rev6)
URL : https://patchwork.freedesktop.org/series/89443/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9bed855e16a0 drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE
-:177: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#177:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 159 lines checked
bcc3d9296cf1 drm/i915: Stop storing the ring size in the ring pointer (v2)
30643107eda9 drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP
d15967a05b62 drm/i915/gem: Set the watchdog timeout directly in
intel_context_set_gem (v2)
9128ae468d28 drm/i915/gem: Return void from context_apply_all
f3f668886b95 drm/i915: Drop the CONTEXT_CLONE API (v2)
e3f2ad211e12 drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4)
6b3e766c7441 drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES
7ca2359062f7 drm/i915/gem: Disallow bonding of virtual engines (v3)
054b1f8e7432 drm/i915/gem: Remove engine auto-magic with FENCE_SUBMIT (v2)
6fe842590232 drm/i915/request: Remove the hook from await_execution
f5928334153d drm/i915/gem: Disallow creating contexts with too many engines
a7a8f8d5ff55 drm/i915: Stop manually RCU banging in reset_stats_ioctl (v2)
93a5d3ac059d drm/i915/gem: Add a separate validate_priority helper
ebec0e49d883 drm/i915: Add gem/i915_gem_context.h to the docs
92cb528d35f6 drm/i915/gem: Add an intermediate proto_context struct (v4)
-:276: WARNING:REPEATED_WORD: Possible repeated word: 'See'
#276: FILE: drivers/gpu/drm/i915/gem/i915_gem_context_types.h:87:
+ /** @single_timeline: See See _gem_context.syncobj */
total: 0 errors, 1 warnings, 0 checks, 259 lines checked
9ba4bec35eb8 drm/i915/gem: Rework error handling in default_engines
cfe2616bb981 drm/i915/gem: Optionally set SSEU in intel_context_set_gem
ce5911d9f97c drm/i915: Add an i915_gem_vm_lookup helper
abdf4766d581 drm/i915/gem: Make an alignment check more sensible
c2ee5d981222 drm/i915/gem: Use the proto-context to handle create parameters
(v3)
-:100: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#100: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:310:
+ unsigned num_engines;
-:281: ERROR:CODE_INDENT: code indent should use tabs where possible
#281: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:491:
+^I^I^I struct i915_gem_proto_context *pc,$
-:281: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#281: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:491:
+static int set_proto_ctx_engines(struct drm_i915_file_private *fpriv,
+struct i915_gem_proto_context *pc,
-:282: ERROR:CODE_INDENT: code indent should use tabs where possible
#282: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:492:
+^I^I^I const struct drm_i915_gem_context_param *args)$
-:385: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#385: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:595:
+ if (!!(user_sseu.flags & I915_CONTEXT_SSEU_FLAG_ENGINE_INDEX) !=
(pc->num_user_engines >= 0))
-:385: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around
'pc->num_user_engines >= 0'
#385: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:595:
+ if (!!(user_sseu.flags & I915_CONTEXT_SSEU_FLAG_ENGINE_INDEX) !=
(pc->num_user_engines >= 0))
total: 2 errors, 2 warnings, 2 checks, 693 lines checked
8d3126761267 drm/i915/gem: Return an error ptr from context_lookup
-:60: WARNING:LIKELY_MISUSE: nested (un)?likely() calls, IS_ERR already uses
unlikely() internally
#60: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:742:
+ if (unlikely(IS_ERR(ctx)))
total: 0 errors, 1 warnings, 0 checks, 60 lines checked
c66b333bcf0d drm/i915/gt: Drop i915_address_space::file (v2)
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit 2bfa996e031b ("drm/i915: Store
owning file on the i915_address_space")'
#9:
It was added in 2bfa996e031b ("drm/i915: Store owning file on the
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit f6e8aa387171 ("drm/i915: Report
the number of closed vma held by each context in debugfs")'
#11:
the difference between the global GTT and a PPGTT. In f6e8aa387171
-:15: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit db80a1294c23 ("drm/i915/gem:
Remove per-client stats from debugfs/i915_gem_objects")'
#15:
were entirely nuked in db80a1294c23 ("drm/i915/gem: Remove per-client
total: 3 errors, 0 warnings, 0 checks, 55 lines checked
c201ac1b1cac drm/i915/gem: Delay context creation (v2)
e68bf5e2b2d3 drm/i915/gem: Don't allow changing the VM on running contexts (v2)
1fa13abc7009 drm/i915/gem: Don't allow changing the engine set on running
contexts (v2)
-:25: WARNING:TYPO_SPELLING: 'mesage' may be misspelled -
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: ioctl clean-ups (rev4)
== Series Details ==
Series: drm/i915/gem: ioctl clean-ups (rev4)
URL : https://patchwork.freedesktop.org/series/89443/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8d290e6238e7 drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE
-:177: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#177:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 159 lines checked
904e773fd289 drm/i915: Stop storing the ring size in the ring pointer
1c4bd7993075 drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP
8a99bfd835ff drm/i915/gem: Set the watchdog timeout directly in
intel_context_set_gem (v2)
715ae33bf9aa drm/i915/gem: Return void from context_apply_all
5e5b1ed85776 drm/i915: Drop the CONTEXT_CLONE API
8032eecf682d drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4)
895c2e4c3bdb drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES
25801b1c52c4 drm/i915/gem: Disallow bonding of virtual engines (v3)
c8b0561320c7 drm/i915/gem: Remove engine auto-magic with FENCE_SUBMIT
9ce8f241d55a drm/i915/request: Remove the hook from await_execution
255f845b4348 drm/i915/gem: Disallow creating contexts with too many engines
178b1c5883fd drm/i915: Stop manually RCU banging in reset_stats_ioctl (v2)
b8dd7d97db62 drm/i915/gem: Add a separate validate_priority helper
72c4d93eb050 drm/i915: Add gem/i915_gem_context.h to the docs
4b7c0de90422 drm/i915/gem: Add an intermediate proto_context struct
-:274: WARNING:REPEATED_WORD: Possible repeated word: 'See'
#274: FILE: drivers/gpu/drm/i915/gem/i915_gem_context_types.h:87:
+ /** @single_timeline: See See i915_gem_context::syncobj */
total: 0 errors, 1 warnings, 0 checks, 271 lines checked
b3c8a4f17cc3 drm/i915/gem: Rework error handling in default_engines
3353ac966ea8 drm/i915/gem: Optionally set SSEU in intel_context_set_gem
56d933b875f6 drm/i915/gem: Use the proto-context to handle create parameters
-:79: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#79: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:326:
+ unsigned num_engines;
-:260: ERROR:CODE_INDENT: code indent should use tabs where possible
#260: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:507:
+^I^I^I struct i915_gem_proto_context *pc,$
-:260: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#260: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:507:
+static int set_proto_ctx_engines(struct drm_i915_file_private *fpriv,
+struct i915_gem_proto_context *pc,
-:261: ERROR:CODE_INDENT: code indent should use tabs where possible
#261: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:508:
+^I^I^I const struct drm_i915_gem_context_param *args)$
-:369: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#369: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:616:
+ if (!!(user_sseu.flags & I915_CONTEXT_SSEU_FLAG_ENGINE_INDEX) !=
(pc->num_user_engines >= 0))
-:369: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around
'pc->num_user_engines >= 0'
#369: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:616:
+ if (!!(user_sseu.flags & I915_CONTEXT_SSEU_FLAG_ENGINE_INDEX) !=
(pc->num_user_engines >= 0))
total: 2 errors, 2 warnings, 2 checks, 698 lines checked
0a99acad1096 drm/i915/gem: Return an error ptr from context_lookup
-:60: WARNING:LIKELY_MISUSE: nested (un)?likely() calls, IS_ERR already uses
unlikely() internally
#60: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:742:
+ if (unlikely(IS_ERR(ctx)))
total: 0 errors, 1 warnings, 0 checks, 60 lines checked
c7bd40e3ab15 drm/i915/gt: Drop i915_address_space::file (v2)
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit 2bfa996e031b ("drm/i915: Store
owning file on the i915_address_space")'
#9:
It was added in 2bfa996e031b ("drm/i915: Store owning file on the
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit f6e8aa387171 ("drm/i915: Report
the number of closed vma held by each context in debugfs")'
#11:
the difference between the global GTT and a PPGTT. In f6e8aa387171
-:15: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit db80a1294c23 ("drm/i915/gem:
Remove per-client stats from debugfs/i915_gem_objects")'
#15:
were entirely nuked in db80a1294c23 ("drm/i915/gem: Remove per-client
total: 3 errors, 0 warnings, 0 checks, 55 lines checked
4dced50754af drm/i915/gem: Delay context creation
6c98c574e624 drm/i915/gem: Don't allow changing the VM on running contexts
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 424 lines checked
60bb25bf2322 drm/i915/gem: Don't allow changing the engine set on running
contexts
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: ioctl clean-ups (rev3)
== Series Details ==
Series: drm/i915/gem: ioctl clean-ups (rev3)
URL : https://patchwork.freedesktop.org/series/89443/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d568c0fd97a3 drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE
-:176: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#176:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 159 lines checked
f6aea3cd1da2 drm/i915: Stop storing the ring size in the ring pointer
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 81 lines checked
b99187a9b6a9 drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP
6b665f0d251c drm/i915/gem: Set the watchdog timeout directly in
intel_context_set_gem (v2)
54566d236033 drm/i915/gem: Return void from context_apply_all
3743384e9f0e drm/i915: Drop the CONTEXT_CLONE API
07ba0d24a10a drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4)
a9a28d64b5bc drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES
058f1057bf1d drm/i915/gem: Disallow bonding of virtual engines (v3)
46e724b65b3c drm/i915/gem: Remove engine auto-magic with FENCE_SUBMIT
9f6c3071c818 drm/i915/request: Remove the hook from await_execution
c55c0fc1bc06 drm/i915/gem: Disallow creating contexts with too many engines
1d13e2571078 drm/i915: Stop manually RCU banging in reset_stats_ioctl (v2)
9a52948d264c drm/i915/gem: Add a separate validate_priority helper
026ab9b0e512 drm/i915: Add gem/i915_gem_context.h to the docs
4919dd9c07a4 drm/i915/gem: Add an intermediate proto_context struct
-:272: WARNING:REPEATED_WORD: Possible repeated word: 'See'
#272: FILE: drivers/gpu/drm/i915/gem/i915_gem_context_types.h:87:
+ /** @single_timeline: See See i915_gem_context::syncobj */
total: 0 errors, 1 warnings, 0 checks, 269 lines checked
79c016fa10e5 drm/i915/gem: Use the proto-context to handle create parameters
-:79: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#79: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:324:
+ unsigned num_engines;
-:260: ERROR:CODE_INDENT: code indent should use tabs where possible
#260: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:505:
+^I^I^I struct i915_gem_proto_context *pc,$
-:260: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#260: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:505:
+static int set_proto_ctx_engines(struct drm_i915_file_private *fpriv,
+struct i915_gem_proto_context *pc,
-:261: ERROR:CODE_INDENT: code indent should use tabs where possible
#261: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:506:
+^I^I^I const struct drm_i915_gem_context_param *args)$
-:386: WARNING:ENOTSUPP: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
#386: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:631:
+ ret = -ENOTSUPP;
total: 2 errors, 2 warnings, 1 checks, 604 lines checked
33e918dfd45f drm/i915/gem: Return an error ptr from context_lookup
-:60: WARNING:LIKELY_MISUSE: nested (un)?likely() calls, IS_ERR already uses
unlikely() internally
#60: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:742:
+ if (unlikely(IS_ERR(ctx)))
total: 0 errors, 1 warnings, 0 checks, 60 lines checked
db39672ae812 drm/i915/gt: Drop i915_address_space::file (v2)
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit 2bfa996e031b ("drm/i915: Store
owning file on the i915_address_space")'
#9:
It was added in 2bfa996e031b ("drm/i915: Store owning file on the
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit f6e8aa387171 ("drm/i915: Report
the number of closed vma held by each context in debugfs")'
#11:
the difference between the global GTT and a PPGTT. In f6e8aa387171
-:15: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("")' - ie: 'commit db80a1294c23 ("drm/i915/gem:
Remove per-client stats from debugfs/i915_gem_objects")'
#15:
were entirely nuked in db80a1294c23 ("drm/i915/gem: Remove per-client
total: 3 errors, 0 warnings, 0 checks, 55 lines checked
bb2549ed6345 drm/i915/gem: Delay context creation
-:356: WARNING:ENOTSUPP: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
#356: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:2729:
+ if (ret == -ENOTSUPP) {
total: 0 errors, 1 warnings, 0 checks, 451 lines checked
335760197fdf drm/i915/gem: Don't allow changing the VM on running contexts
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 424 lines checked
df6523539e0a drm/i915/gem: Don't allow changing the engine set on running
contexts
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 314 lines checked
0c2f94037518
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: ioctl clean-ups
== Series Details ==
Series: drm/i915/gem: ioctl clean-ups
URL : https://patchwork.freedesktop.org/series/89443/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
468456983a83 drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE
-:176: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#176:
deleted file mode 100644
total: 0 errors, 1 warnings, 0 checks, 159 lines checked
79a91e982ff7 drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP
31e3478abfe0 drm/i915/gem: Set the watchdog timeout directly in
intel_context_set_gem
-:25: WARNING:LINE_SPACING: Missing a blank line after declarations
#25: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:239:
+ unsigned int timeout_ms = ctx->i915->params.request_timeout_ms;
+ intel_context_set_watchdog_us(ce, (u64)timeout_ms * 1000);
total: 0 errors, 1 warnings, 0 checks, 83 lines checked
53f030af52d4 drm/i915/gem: Return void from context_apply_all
4b9a8e315c1c drm/i915: Drop the CONTEXT_CLONE API
ebe52e477467 drm/i915: Implement SINGLE_TIMELINE with a syncobj (v3)
65796fb10e50 drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES
d3ad59ed0a22 drm/i915/gem: Disallow bonding of virtual engines
21cb51520e4b drm/i915/gem: Disallow creating contexts with too many engines
b6ef4a4c6f47 drm/i915/request: Remove the hook from await_execution
ab3620b9adb5 drm/i915: Stop manually RCU banging in reset_stats_ioctl
fa138a73374c drm/i915/gem: Add a separate validate_priority helper
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 56 lines checked
c50f4dd9ee3f drm/i915/gem: Add an intermediate proto_context struct
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 268 lines checked
70451a1734a2 drm/i915/gem: Return an error ptr from context_lookup
-:59: WARNING:LIKELY_MISUSE: nested (un)?likely() calls, IS_ERR already uses
unlikely() internally
#59: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:742:
+ if (unlikely(IS_ERR(ctx)))
total: 0 errors, 1 warnings, 0 checks, 60 lines checked
d0f063d4604e drm/i915/gt: Drop i915_address_space::file
6fce8cf246ee drm/i915/gem: Delay context creation
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
-:106: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#106: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:358:
+ unsigned num_engines;
-:287: ERROR:CODE_INDENT: code indent should use tabs where possible
#287: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:539:
+^I^I^I struct i915_gem_proto_context *pc,$
-:287: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#287: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:539:
+static int set_proto_ctx_engines(struct drm_i915_file_private *fpriv,
+struct i915_gem_proto_context *pc,
-:288: ERROR:CODE_INDENT: code indent should use tabs where possible
#288: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:540:
+^I^I^I const struct drm_i915_gem_context_param *args)$
-:412: WARNING:ENOTSUPP: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
#412: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:664:
+ ret = -ENOTSUPP;
-:807: WARNING:ENOTSUPP: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
#807: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:2719:
+ if (ret == -ENOTSUPP) {
-:925: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#925: FILE: drivers/gpu/drm/i915/i915_drv.h:203:
+ struct mutex proto_context_lock;
total: 2 errors, 4 warnings, 2 checks, 901 lines checked
40c7b0f86bc0 drm/i915/gem: Don't allow changing the VM on running contexts
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 424 lines checked
9bd5fd34f557 drm/i915/gem: Don't allow changing the engine set on running
contexts
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 313 lines checked
1694fd69838b drm/i915/selftests: Take a VM in kernel_context()
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 131 lines checked
e1c0a99c4bc6 i915/gem/selftests: Assign the VM at context creation in
igt_shared_ctx_exec
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 17 lines checked
0c4562693de5 drm/i915/gem: Roll all of context creation together
-:176: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a
separate line
#176: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:1291:
+* is no remap info, it will be a NOP. */
total: 0 errors, 1 warnings, 0 checks, 246 lines checked
