Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)

2020-09-16 Thread Srivatsa, Anusha 


> -Original Message-
> From: Jani Nikula 
> Sent: Wednesday, September 16, 2020 6:51 AM
> To: Srivatsa, Anusha 
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll:
> Centralize PLL_ENABLE register lookup (rev4)
> 
> On Fri, 11 Sep 2020, Patchwork  wrote:
> > == Series Details ==
> >
> > Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)
> > URL   : https://patchwork.freedesktop.org/series/81150/
> > State : warning
> >
> > == Summary ==
> >
> > $ dim checkpatch origin/drm-tip
> > dac234339c17 drm/i915/pll: Centralize PLL_ENABLE register lookup
> > -:38: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
> > #38: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:154:
> > +{
> > +
> >
> > -:39: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses
> around 'pll->info->id == DPLL_ID_EHL_DPLL4'
> > #39: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
> > +   if (IS_ELKHARTLAKE(i915) && (pll->info->id == DPLL_ID_EHL_DPLL4))
> >
> > -:44: CHECK:LINE_SPACING: Please don't use multiple blank lines
> > #44: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:160:
> > +
> > +
> >
> > -:45: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
> > #45: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:161:
> > +
> > +}
> 
> We have this in CI so people don't have to bother with mentioning this
> stuff. But I do expect people to look at them and fix them.

Yes jani. Will definitely keep this in mind.

Anusha
> BR,
> Jani.
> 
> 
> >
> > total: 0 errors, 0 warnings, 4 checks, 66 lines checked
> >
> >
> > ___
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> --
> Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)

2020-09-16 Thread Jani Nikula 
On Fri, 11 Sep 2020, Patchwork  wrote:
> == Series Details ==
>
> Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)
> URL   : https://patchwork.freedesktop.org/series/81150/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> dac234339c17 drm/i915/pll: Centralize PLL_ENABLE register lookup
> -:38: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
> #38: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:154:
> +{
> +
>
> -:39: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 
> 'pll->info->id == DPLL_ID_EHL_DPLL4'
> #39: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
> + if (IS_ELKHARTLAKE(i915) && (pll->info->id == DPLL_ID_EHL_DPLL4))
>
> -:44: CHECK:LINE_SPACING: Please don't use multiple blank lines
> #44: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:160:
> +
> +
>
> -:45: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
> #45: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:161:
> +
> +}

We have this in CI so people don't have to bother with mentioning this
stuff. But I do expect people to look at them and fix them.

BR,
Jani.


>
> total: 0 errors, 0 warnings, 4 checks, 66 lines checked
>
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev5)

2020-09-14 Thread Patchwork 
== Series Details ==

Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev5)
URL   : https://patchwork.freedesktop.org/series/81150/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f5ec8439a17d drm/i915/pll: Centralize PLL_ENABLE register lookup
-:38: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#38: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:154:
+{
+

-:39: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 
'pll->info->id == DPLL_ID_EHL_DPLL4'
#39: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
+   if (IS_ELKHARTLAKE(i915) && (pll->info->id == DPLL_ID_EHL_DPLL4))

-:44: CHECK:LINE_SPACING: Please don't use multiple blank lines
#44: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:160:
+
+

-:45: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#45: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:161:
+
+}

total: 0 errors, 0 warnings, 4 checks, 66 lines checked


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)

2020-09-10 Thread Patchwork 
== Series Details ==

Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev4)
URL   : https://patchwork.freedesktop.org/series/81150/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
dac234339c17 drm/i915/pll: Centralize PLL_ENABLE register lookup
-:38: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#38: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:154:
+{
+

-:39: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 
'pll->info->id == DPLL_ID_EHL_DPLL4'
#39: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
+   if (IS_ELKHARTLAKE(i915) && (pll->info->id == DPLL_ID_EHL_DPLL4))

-:44: CHECK:LINE_SPACING: Please don't use multiple blank lines
#44: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:160:
+
+

-:45: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#45: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:161:
+
+}

total: 0 errors, 0 warnings, 4 checks, 66 lines checked


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev3)

2020-09-08 Thread Patchwork 
== Series Details ==

Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev3)
URL   : https://patchwork.freedesktop.org/series/81150/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3be3651c4fb7 drm/i915/pll: Centralize PLL_ENABLE register lookup
-:33: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#33: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:152:
+i915_reg_t intel_combo_pll_enable_reg(struct drm_i915_private *dev_priv,
+   struct intel_shared_dpll *pll)

-:35: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#35: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:154:
+{
+

-:36: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional 
statements (8, 24)
#36: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
+   if (IS_ELKHARTLAKE(dev_priv) && (pll->info->id == DPLL_ID_EHL_DPLL4))
+   return MG_PLL_ENABLE(0);

-:36: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 
'pll->info->id == DPLL_ID_EHL_DPLL4'
#36: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
+   if (IS_ELKHARTLAKE(dev_priv) && (pll->info->id == DPLL_ID_EHL_DPLL4))

-:41: CHECK:LINE_SPACING: Please don't use multiple blank lines
#41: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:160:
+
+

-:42: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#42: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:161:
+
+}

total: 0 errors, 1 warnings, 5 checks, 65 lines checked


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup (rev2)

2020-09-01 Thread Patchwork 
== Series Details ==

Series: drm/i915/pll: Centralize PLL_ENABLE register lookup (rev2)
URL   : https://patchwork.freedesktop.org/series/81150/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2b838e80247e drm/i915/pll: Centralize PLL_ENABLE register lookup
-:30: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#30: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:152:
+i915_reg_t intel_combo_pll_enable_reg(struct drm_i915_private *dev_priv,
+   struct intel_shared_dpll *pll)

-:32: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#32: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:154:
+{
+

-:33: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional 
statements (8, 24)
#33: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
+   if (IS_ELKHARTLAKE(dev_priv) && (pll->info->id == DPLL_ID_EHL_DPLL4))
+   return MG_PLL_ENABLE(0);

-:33: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 
'pll->info->id == DPLL_ID_EHL_DPLL4'
#33: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
+   if (IS_ELKHARTLAKE(dev_priv) && (pll->info->id == DPLL_ID_EHL_DPLL4))

-:38: CHECK:LINE_SPACING: Please don't use multiple blank lines
#38: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:160:
+
+

-:39: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#39: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:161:
+
+}

total: 0 errors, 1 warnings, 5 checks, 55 lines checked


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pll: Centralize PLL_ENABLE register lookup

2020-08-28 Thread Patchwork 
== Series Details ==

Series: drm/i915/pll: Centralize PLL_ENABLE register lookup
URL   : https://patchwork.freedesktop.org/series/81150/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9b03add535d5 drm/i915/pll: Centralize PLL_ENABLE register lookup
-:26: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#26: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:154:
+{
+

-:34: CHECK:LINE_SPACING: Please don't use multiple blank lines
#34: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:162:
+
+

-:35: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#35: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:163:
+
+}

total: 0 errors, 0 warnings, 3 checks, 57 lines checked


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx