[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2)
== Series Details == Series: series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait (rev2) URL : https://patchwork.freedesktop.org/series/79517/ State : warning == Summary == $ dim checkpatch origin/drm-tip 130497fc98af drm/i915: Reduce i915_request.lock contention for i915_request_wait 78b2b4227c1a drm/i915: Remove i915_request.lock requirement for execution callbacks c0b29c38984e drm/i915: Remove requirement for holding i915_request.lock for breadcrumbs 96f54f935986 drm/i915: Add a couple of missing i915_active_fini() e0279073e5d3 drm/i915: Skip taking acquire mutex for no ref->active callback 74f1c669d951 drm/i915: Export a preallocate variant of i915_active_acquire() db2f42ce7206 drm/i915: Keep the most recently used active-fence upon discard 3bfed8a701e1 drm/i915: Make the stale cached active node available for any timeline 8d7b14253127 drm/i915: Provide a fastpath for waiting on vma bindings 638a715d2c30 drm/i915: Soften the tasklet flush frequency before waits 5250859a3025 drm/i915: Preallocate stashes for vma page-directories 2747217ec2ad drm/i915: Switch to object allocations for page directories 6bdab21d6597 drm/i915/gem: Don't drop the timeline lock during execbuf f3c8a75f8f0d drm/i915/gem: Rename execbuf.bind_link to unbound_link 1608dda568ca drm/i915/gem: Break apart the early i915_vma_pin from execbuf object lookup 63d098780e45 drm/i915/gem: Remove the call for no-evict i915_vma_pin 6ac79cc3b262 drm/i915: Add list_for_each_entry_safe_continue_reverse -:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pos' - possible side-effects? #21: FILE: drivers/gpu/drm/i915/i915_utils.h:269: +#define list_for_each_entry_safe_continue_reverse(pos, n, head, member) \ + for (pos = list_prev_entry(pos, member),\ +n = list_prev_entry(pos, member); \ +>member != (head);\ +pos = n, n = list_prev_entry(n, member)) -:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #21: FILE: drivers/gpu/drm/i915/i915_utils.h:269: +#define list_for_each_entry_safe_continue_reverse(pos, n, head, member) \ + for (pos = list_prev_entry(pos, member),\ +n = list_prev_entry(pos, member); \ +>member != (head);\ +pos = n, n = list_prev_entry(n, member)) -:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects? #21: FILE: drivers/gpu/drm/i915/i915_utils.h:269: +#define list_for_each_entry_safe_continue_reverse(pos, n, head, member) \ + for (pos = list_prev_entry(pos, member),\ +n = list_prev_entry(pos, member); \ +>member != (head);\ +pos = n, n = list_prev_entry(n, member)) total: 0 errors, 0 warnings, 3 checks, 12 lines checked 69b95b2f1b58 drm/i915: Always defer fenced work to the worker 339dd5f35caf drm/i915/gem: Assign context id for async work dbe18ef2f769 drm/i915/gem: Separate the ww_mutex walker into its own list d6442826e675 drm/i915/gem: Asynchronous GTT unbinding 2ee5a36ee1d9 drm/i915/gem: Bind the fence async for execbuf 2d3e21b38717 drm/i915/gem: Include cmdparser in common execbuf pinning c180ca0649ab drm/i915/gem: Include secure batch in common execbuf pinning 9040f3b37f3b drm/i915/gem: Reintroduce multiple passes for reloc processing -:1512: WARNING:MEMORY_BARRIER: memory barrier without comment #1512: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_execbuffer.c:161: + wmb(); total: 0 errors, 1 warnings, 0 checks, 1502 lines checked d3fe2f8baa11 drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2. -:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 -:354: WARNING:LINE_SPACING: Missing a blank line after declarations #354: FILE: drivers/gpu/drm/i915/mm/st_acquire_ctx.c:106: + const unsigned int total = ARRAY_SIZE(dl->obj); + I915_RND_STATE(prng); -:450: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c) #450: FILE: drivers/gpu/drm/i915/mm/st_acquire_ctx.c:202: + yield(); /* start all threads before we begin */ total: 0 errors, 3 warnings, 0 checks, 446 lines checked 90ec819f7195 drm/i915/gem: Pull execbuf dma resv under a single critical section 69013a1a8c42 drm/i915/gem: Replace i915_gem_object.mm.mutex with reservation_ww_class 6cb053b52a1e drm/i915: Hold wakeref for the duration of the vma GGTT binding 22e6c1fa7455 drm/i915: Specialise GGTT binding f89d50b33136 drm/i915/gt: Acquire backing storage for the context cd9d5d1c7e79 drm/i915/gt: Push the wait for the context to bound to the request -:198: WARNING:FILE_PATH_CHANGES: added, moved or deleted
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait
== Series Details == Series: series starting with [01/66] drm/i915: Reduce i915_request.lock contention for i915_request_wait URL : https://patchwork.freedesktop.org/series/79517/ State : warning == Summary == $ dim checkpatch origin/drm-tip 91bde1c5e935 drm/i915: Reduce i915_request.lock contention for i915_request_wait 13de08637a53 drm/i915: Remove i915_request.lock requirement for execution callbacks 6fa430293a65 drm/i915: Remove requirement for holding i915_request.lock for breadcrumbs e919aa95911c drm/i915: Add a couple of missing i915_active_fini() 379852a0d374 drm/i915: Skip taking acquire mutex for no ref->active callback 8628c1a1b800 drm/i915: Export a preallocate variant of i915_active_acquire() 383c7cbfc8d5 drm/i915: Keep the most recently used active-fence upon discard 00c92cc2c921 drm/i915: Make the stale cached active node available for any timeline a938c15b20b3 drm/i915: Provide a fastpath for waiting on vma bindings 63c73191100c drm/i915: Soften the tasklet flush frequency before waits 7c20ceade654 drm/i915: Preallocate stashes for vma page-directories f62b56fc3c3f drm/i915: Switch to object allocations for page directories d9e5a405669b drm/i915/gem: Don't drop the timeline lock during execbuf a488eb2ac0c6 drm/i915/gem: Rename execbuf.bind_link to unbound_link bf7156efc5fe drm/i915/gem: Break apart the early i915_vma_pin from execbuf object lookup b336351c77f1 drm/i915/gem: Remove the call for no-evict i915_vma_pin 482c12431055 drm/i915: Add list_for_each_entry_safe_continue_reverse -:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pos' - possible side-effects? #21: FILE: drivers/gpu/drm/i915/i915_utils.h:269: +#define list_for_each_entry_safe_continue_reverse(pos, n, head, member) \ + for (pos = list_prev_entry(pos, member),\ +n = list_prev_entry(pos, member); \ +>member != (head);\ +pos = n, n = list_prev_entry(n, member)) -:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #21: FILE: drivers/gpu/drm/i915/i915_utils.h:269: +#define list_for_each_entry_safe_continue_reverse(pos, n, head, member) \ + for (pos = list_prev_entry(pos, member),\ +n = list_prev_entry(pos, member); \ +>member != (head);\ +pos = n, n = list_prev_entry(n, member)) -:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects? #21: FILE: drivers/gpu/drm/i915/i915_utils.h:269: +#define list_for_each_entry_safe_continue_reverse(pos, n, head, member) \ + for (pos = list_prev_entry(pos, member),\ +n = list_prev_entry(pos, member); \ +>member != (head);\ +pos = n, n = list_prev_entry(n, member)) total: 0 errors, 0 warnings, 3 checks, 12 lines checked 03f0ac6d0aa7 drm/i915: Always defer fenced work to the worker 0ffcc361f56b drm/i915/gem: Assign context id for async work 82ed2ac041bb drm/i915/gem: Separate the ww_mutex walker into its own list 8ed473e9ebb5 drm/i915/gem: Asynchronous GTT unbinding 289e4f21e37d drm/i915/gem: Bind the fence async for execbuf 3994c1315802 drm/i915/gem: Include cmdparser in common execbuf pinning d59dcbda945a drm/i915/gem: Include secure batch in common execbuf pinning a2d67581b7cc drm/i915/gem: Reintroduce multiple passes for reloc processing -:1512: WARNING:MEMORY_BARRIER: memory barrier without comment #1512: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_execbuffer.c:161: + wmb(); total: 0 errors, 1 warnings, 0 checks, 1502 lines checked 34f8c8b06fb1 drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2. -:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 -:354: WARNING:LINE_SPACING: Missing a blank line after declarations #354: FILE: drivers/gpu/drm/i915/mm/st_acquire_ctx.c:106: + const unsigned int total = ARRAY_SIZE(dl->obj); + I915_RND_STATE(prng); -:450: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c) #450: FILE: drivers/gpu/drm/i915/mm/st_acquire_ctx.c:202: + yield(); /* start all threads before we begin */ total: 0 errors, 3 warnings, 0 checks, 446 lines checked fe0b2e8f9867 drm/i915/gem: Pull execbuf dma resv under a single critical section 0ca5333286a3 drm/i915/gem: Replace i915_gem_object.mm.mutex with reservation_ww_class 009379133a04 drm/i915: Hold wakeref for the duration of the vma GGTT binding 30196b1778f2 drm/i915: Specialise GGTT binding 7ef75aca0d57 drm/i915/gt: Acquire backing storage for the context 0e4a431e2f5e drm/i915/gt: Push the wait for the context to bound to the request -:198: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
