[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gtt: pde entry encoding is identical

2019-07-04 Thread Patchwork 
== Series Details ==

Series: series starting with [1/3] drm/i915/gtt: pde entry encoding is identical
URL   : https://patchwork.freedesktop.org/series/63229/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3d60e2b75e24 drm/i915/gtt: pde entry encoding is identical
-:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pd' - possible side-effects?
#58: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:777:
+#define init_pd(vm, pd, to) {  \
+   GEM_DEBUG_BUG_ON(!pd_has_phys_page(pd));\
+   fill_px((vm), (pd), gen8_pde_encode(px_dma(to), I915_CACHE_LLC)); \
+   memset_p((pd)->entry, (to), 512);   \
 }

-:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'to' - possible side-effects?
#58: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:777:
+#define init_pd(vm, pd, to) {  \
+   GEM_DEBUG_BUG_ON(!pd_has_phys_page(pd));\
+   fill_px((vm), (pd), gen8_pde_encode(px_dma(to), I915_CACHE_LLC)); \
+   memset_p((pd)->entry, (to), 512);   \
 }

-:91: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pd' - possible side-effects?
#91: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:804:
+#define set_pd_entry(pd, pde, to)  ({ \
+   __write_pd_entry((pd), (pde), px_base(to), gen8_pde_encode); \
+   atomic_inc(&(pd)->used);   \
+})

-:96: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pd' - possible side-effects?
#96: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:809:
+#define clear_pd_entry(pd, pde, to) ({  \
+   __write_pd_entry((pd), (pde), px_base(to), gen8_pde_encode); \
+   atomic_dec(&pd->used);   \
+})

total: 0 errors, 0 warnings, 4 checks, 272 lines checked
d1cf7c577159 drm/i915/gtt: Tear down setup and cleanup macros for page dma
ecf8477bcfc1 drm/i915/gtt: Setup phys pages for 3lvl pdps

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gtt: pde entry encoding is identical

2019-06-18 Thread Patchwork 
== Series Details ==

Series: series starting with [1/3] drm/i915/gtt: pde entry encoding is identical
URL   : https://patchwork.freedesktop.org/series/62324/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
224a6de52ba2 drm/i915/gtt: pde entry encoding is identical
-:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pd' - possible side-effects?
#55: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:734:
+#define init_pd(vm, pd, to) {  \
+   GEM_DEBUG_BUG_ON(!pd_has_phys_page(pd));\
+   fill_px((vm), (pd), gen8_pde_encode(px_dma(to), I915_CACHE_LLC)); \
+   memset_p((pd)->entry, (to), 512);   \
 }

-:55: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'to' - possible side-effects?
#55: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:734:
+#define init_pd(vm, pd, to) {  \
+   GEM_DEBUG_BUG_ON(!pd_has_phys_page(pd));\
+   fill_px((vm), (pd), gen8_pde_encode(px_dma(to), I915_CACHE_LLC)); \
+   memset_p((pd)->entry, (to), 512);   \
 }

total: 0 errors, 0 warnings, 2 checks, 235 lines checked
4f46c24d9757 drm/i915/gtt: Tear down setup and cleanup macros for page dma
3fc849b75c9d drm/i915/gtt: Setup phys pages for 3lvl pdps

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx