Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2)

2021-03-04 Thread Matt Roper
On Thu, Mar 04, 2021 at 10:37:28AM -0800, Chiou, Cooper wrote:
> > <3> [198.221812] [drm:wa_verify [i915]] *ERROR* engine workaround lost
> > on application! (reg[b004]=0x0, relevant bits were 0x0 vs expected 0x80) <3>
> > [198.222751] [drm:wa_verify [i915]] *ERROR* engine workaround lost on
> > application! (reg[b118]=0x0, relevant bits were 0x0 vs expected 0x20)
> > <3> [198.223076] [drm:wa_verify [i915]] *ERROR* engine workaround lost
> > on application! (reg[b11c]=0x0, relevant bits were 0x0 vs expected 0x4)
> >
> > ?
> >
> > CI does not think they are old warnings and registers are the MCR affected
> > range. So more digging would be needed to be sure. You are saying those
> > happen in our CI without the patch?
> 
> Hi Tvrtko,
> This patch only programmed 0xfdc register in reg[fdc]=0x1200, no touch
> reg[b004]=0x0 & reg[b118]=0x0 & reg[b11c]=0x0, so I don't think this error
> is caused by this change.

0xFDC is the multicast steering register --- it controls how accesses to
other multicast registers operate.  According to bspec page 66673, range
0xB000-0xB0FF is a multicast range that uses slice steering and
0xB100-0xB3FF is a multicast range that uses L3BANK steering.  So the
regressions here are likely due to your patch introducing invalid
steering (i.e., making register accesses target fused-off or
non-existent instances of those registers).

> This error might be due to wa_write_masked_or()
> 
> Meanwhile, as you can see this 2 kbl devices has different CI result.
> 1. fi-kbl-7500u - no any error log -
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19752/fi-kbl-7500u/igt@gem_exec_susp...@basic-s0.html
> 
> 2. fi-kbl-7567u- has register read/write error log:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19752/fi-kbl-7567u/igt@gem_exec_susp...@basic-s0.html

Multi-cast fusing depends on the fusing of the specific part you're
running on.  When you see these kind of failures on one KBL and not on
another, it's an indiction that you probably need to take a look at the
steering logic being used (i.e., the programming of 0xFDC) for mistakes.
Incorrect steering logic can result in things working fine on platforms
with certain fusing configs, but still cause major regressions on
platforms with different fusing.


Matt

> 
> Cooper
> >
> > Then with regards to the reported perf drop - something to check would be if
> > the CML system you tested on has the same slice/subslice config as the one
> > from which the original report originated. Might be hard if the test farm 
> > has
> > been re-configured. But essentially running the benchmark on a few Gen9
> > machine with fused ss would be needed I think.
> >
> > And finally I couldn't find the WA entry in bspec, but maybe I just don't 
> > know
> > where to look. Someone better versed to finding WA. Maybe Matt you would
> > have time for a quick check if
> > WaProgramMgsrForCorrectSliceSpecificMmioReads is documented as
> > applicable to Gen9?
> >
> > Regards,
> >
> > Tvrtko

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2)

2021-03-04 Thread Chiou, Cooper
> <3> [198.221812] [drm:wa_verify [i915]] *ERROR* engine workaround lost
> on application! (reg[b004]=0x0, relevant bits were 0x0 vs expected 0x80) <3>
> [198.222751] [drm:wa_verify [i915]] *ERROR* engine workaround lost on
> application! (reg[b118]=0x0, relevant bits were 0x0 vs expected 0x20)
> <3> [198.223076] [drm:wa_verify [i915]] *ERROR* engine workaround lost
> on application! (reg[b11c]=0x0, relevant bits were 0x0 vs expected 0x4)
> 
> ?
> 
> CI does not think they are old warnings and registers are the MCR affected
> range. So more digging would be needed to be sure. You are saying those
> happen in our CI without the patch?

Hi Tvrtko,
This patch only programmed 0xfdc register in reg[fdc]=0x1200, no touch 
reg[b004]=0x0 & reg[b118]=0x0 & reg[b11c]=0x0, so I don't think this error 
is caused by this change.
This error might be due to wa_write_masked_or() 

Meanwhile, as you can see this 2 kbl devices has different CI result.
1. fi-kbl-7500u - no any error log - 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19752/fi-kbl-7500u/igt@gem_exec_susp...@basic-s0.html

2. fi-kbl-7567u- has register read/write error log: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19752/fi-kbl-7567u/igt@gem_exec_susp...@basic-s0.html

Cooper
> 
> Then with regards to the reported perf drop - something to check would be if
> the CML system you tested on has the same slice/subslice config as the one
> from which the original report originated. Might be hard if the test farm has
> been re-configured. But essentially running the benchmark on a few Gen9
> machine with fused ss would be needed I think.
> 
> And finally I couldn't find the WA entry in bspec, but maybe I just don't know
> where to look. Someone better versed to finding WA. Maybe Matt you would
> have time for a quick check if
> WaProgramMgsrForCorrectSliceSpecificMmioReads is documented as
> applicable to Gen9?
> 
> Regards,
> 
> Tvrtko
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2)

2021-02-17 Thread Tvrtko Ursulin



Hi,

On 09/02/2021 11:37, Chiou, Cooper wrote:
 From this CI warning log, there are all known warning message in i915 
driver and is not caused by my patch.


Warning 1:

<3> [69.081809] [drm:wa_verify [i915]] *ERROR* engine workaround lost on 
application! (reg[b004]=0x0, relevant bits were 0x0 vs expected 0x80)


Warning 2:

<3> [619.188270] i915/intel_lrc_live_selftests: live_lrc_isolation 
failed with error -22


Warning 3:

<3> [282.248111] i915 :00:02.0: [drm] *ERROR* CPU pipe A FIFO underrun


This one:

igt@i915_pm_rpm@module-reload:

fi-cfl-8109u: PASS -> DMESG-WARN +35 similar issues

<3> [198.221812] [drm:wa_verify [i915]] *ERROR* engine workaround lost on 
application! (reg[b004]=0x0, relevant bits were 0x0 vs expected 0x80)
<3> [198.222751] [drm:wa_verify [i915]] *ERROR* engine workaround lost on 
application! (reg[b118]=0x0, relevant bits were 0x0 vs expected 0x20)
<3> [198.223076] [drm:wa_verify [i915]] *ERROR* engine workaround lost on 
application! (reg[b11c]=0x0, relevant bits were 0x0 vs expected 0x4)

?

CI does not think they are old warnings and registers are the MCR affected 
range. So more digging would be needed to be sure. You are saying those happen 
in our CI without the patch?

Then with regards to the reported perf drop - something to check would be if 
the CML system you tested on has the same slice/subslice config as the one from 
which the original report originated. Might be hard if the test farm has been 
re-configured. But essentially running the benchmark on a few Gen9 machine with 
fused ss would be needed I think.

And finally I couldn't find the WA entry in bspec, but maybe I just don't know 
where to look. Someone better versed to finding WA. Maybe Matt you would have 
time for a quick check if WaProgramMgsrForCorrectSliceSpecificMmioReads is 
documented as applicable to Gen9?

Regards,

Tvrtko
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2)

2021-02-09 Thread Chiou, Cooper
From this CI warning log, there are all known warning message in i915 driver 
and is not caused by my patch.

Warning 1:
<3> [69.081809] [drm:wa_verify [i915]] *ERROR* engine workaround lost on 
application! (reg[b004]=0x0, relevant bits were 0x0 vs expected 0x80)
Warning 2:
<3> [619.188270] i915/intel_lrc_live_selftests: live_lrc_isolation failed with 
error -22
Warning 3:
<3> [282.248111] i915 :00:02.0: [drm] *ERROR* CPU pipe A FIFO underrun

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2)

2021-02-08 Thread Patchwork
== Series Details ==

Series: drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 
(rev2)
URL   : https://patchwork.freedesktop.org/series/81764/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9747 -> Patchwork_19638


Summary
---

  **FAILURE**

  Serious unknown changes coming with Patchwork_19638 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_19638, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/index.html

Possible new issues
---

  Here are the unknown changes that may have been introduced in Patchwork_19638:

### IGT changes ###

 Possible regressions 

  * igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u:   [PASS][1] -> [DMESG-WARN][2] +35 similar issues
   [1]: 
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9747/fi-cfl-8109u/igt@i915_pm_...@module-reload.html
   [2]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-cfl-8109u/igt@i915_pm_...@module-reload.html

  
Known issues


  Here are the changes found in Patchwork_19638 that come from known issues:

### IGT changes ###

 Issues hit 

  * igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-cfl-8700k:   NOTRUN -> [SKIP][3] ([fdo#109271]) +25 similar issues
   [3]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-cfl-8700k/igt@amdgpu/amd_cs_...@sync-fork-gfx0.html

  * igt@debugfs_test@read_all_entries:
- fi-tgl-y:   [PASS][4] -> [DMESG-WARN][5] ([i915#402]) +2 similar 
issues
   [4]: 
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9747/fi-tgl-y/igt@debugfs_test@read_all_entries.html
   [5]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-tgl-y/igt@debugfs_test@read_all_entries.html

  * igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka:  NOTRUN -> [SKIP][6] ([fdo#109271]) +23 similar issues
   [6]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-kbl-soraka/igt@gem_exec_fence@basic-b...@bcs0.html

  * igt@gem_exec_suspend@basic-s0:
- fi-cfl-8109u:   [PASS][7] -> [DMESG-WARN][8] ([i915#262])
   [7]: 
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9747/fi-cfl-8109u/igt@gem_exec_susp...@basic-s0.html
   [8]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-cfl-8109u/igt@gem_exec_susp...@basic-s0.html

  * igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka:  NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#2190])
   [9]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-kbl-soraka/igt@gem_huc_c...@huc-copy.html
- fi-cfl-8700k:   NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#2190])
   [10]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-cfl-8700k/igt@gem_huc_c...@huc-copy.html

  * igt@i915_selftest@live@execlists:
- fi-cfl-8109u:   [PASS][11] -> [DMESG-WARN][12] ([i915#1037])
   [11]: 
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9747/fi-cfl-8109u/igt@i915_selftest@l...@execlists.html
   [12]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-cfl-8109u/igt@i915_selftest@l...@execlists.html

  * igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka:  NOTRUN -> [DMESG-FAIL][13] ([i915#1886] / [i915#2291])
   [13]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka:  NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827]) +8 
similar issues
   [14]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-kbl-soraka/igt@kms_chamel...@common-hpd-after-suspend.html

  * igt@kms_chamelium@vga-edid-read:
- fi-cfl-8700k:   NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +8 
similar issues
   [15]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-cfl-8700k/igt@kms_chamel...@vga-edid-read.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-cfl-8700k:   NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#533])
   [16]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-cfl-8700k/igt@kms_pipe_crc_ba...@compare-crc-sanitycheck-pipe-d.html
- fi-kbl-soraka:  NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#533])
   [17]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-kbl-soraka/igt@kms_pipe_crc_ba...@compare-crc-sanitycheck-pipe-d.html

  
 Possible fixes 

  * igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y:   [DMESG-WARN][18] ([i915#402]) -> [PASS][19] +1 
similar issue
   [18]: 
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9747/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
   [19]: 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19638/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html

  
  [fdo#109271]: https: