[Intel-gfx] vlv punit and sideband tidy

2018-03-07 Thread Chris Wilson
While we continue to observe hangs even with this w/a in place, I do
believe we are in a better position (although that may just be my
confirmation bias). I certainly don't think it's all happy yet. Mika
believes that if we keep the cpu in C0 whilst the gpu is busy, then it
behaves much better -- but that is a very tough sell; virtually disabling
cpu powersaving entirely, for the gpu rarely sleeps under the target
workloads.

Still I think this series moves us forwards and would appreciation acks
or an outright nak to drop it. :)
-Chris

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] vlv punit and sideband tidy

2018-03-07 Thread Rogozhkin, Dmitry V
On Wed, 2018-03-07 at 19:41 +, Chris Wilson wrote:
> Mika
> believes that if we keep the cpu in C0 whilst the gpu is busy, then
> it
> behaves much better -- but that is a very tough sell

Chris, Mika, I wonder does i915 driver tries to keep CPU in C0 at the
moment already or you just consider this? If it is doing anything to
CPU while gpu is busy, could you, please, clarify what exactly and
point me to the code/key patches? Please, answer from BDW/SKL gen
perspective rather than VLV.

Dmitry.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] vlv punit and sideband tidy

2018-03-08 Thread Chris Wilson
Quoting Rogozhkin, Dmitry V (2018-03-07 20:39:16)
> On Wed, 2018-03-07 at 19:41 +, Chris Wilson wrote:
> > Mika
> > believes that if we keep the cpu in C0 whilst the gpu is busy, then
> > it
> > behaves much better -- but that is a very tough sell
> 
> Chris, Mika, I wonder does i915 driver tries to keep CPU in C0 at the
> moment already or you just consider this? 

That is what Mika looked at, setting C0 while the GPU is marked busy.
Iirc, he was satisfied with the result, I just objected on the grounds
that keeping the CPU at max frequency was unlikely to win any friends in
HTPC. (Although, maybe my gut feeling here is backwards and killawatt
reports differently.)

> CPU while gpu is busy, could you, please, clarify what exactly and
> point me to the code/key patches? Please, answer from BDW/SKL gen
> perspective rather than VLV.

Basically you do pm_qos_update_request() from i915_request::mark_busy().
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx