Re: [PATCH 3/3] drm/i915: Don't use __func__ as prefix for drm_dbg_printer

2024-05-17 Thread Jani Nikula 
On Fri, 17 May 2024, Michal Wajdeczko  wrote:
> Updated code of drm_dbg_printer() is already printing symbolic
> name of the caller like drm_dbg() does.
>
> Signed-off-by: Michal Wajdeczko 

Reviewed-by: Jani Nikula 

> ---
>  drivers/gpu/drm/i915/gt/intel_reset.c  | 2 +-
>  drivers/gpu/drm/i915/gt/selftest_context.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c 
> b/drivers/gpu/drm/i915/gt/intel_reset.c
> index 6161f7a3ff70..735cd23a43c6 100644
> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
> @@ -1025,7 +1025,7 @@ void intel_gt_set_wedged(struct intel_gt *gt)
>  
>   if (GEM_SHOW_DEBUG()) {
>   struct drm_printer p = drm_dbg_printer(>i915->drm,
> -DRM_UT_DRIVER, __func__);
> +DRM_UT_DRIVER, NULL);
>   struct intel_engine_cs *engine;
>   enum intel_engine_id id;
>  
> diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c 
> b/drivers/gpu/drm/i915/gt/selftest_context.c
> index 12eca750f7d0..5eb46700dc4e 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_context.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_context.c
> @@ -286,7 +286,7 @@ static int __live_active_context(struct intel_engine_cs 
> *engine)
>  
>   if (intel_engine_pm_is_awake(engine)) {
>   struct drm_printer p = drm_dbg_printer(>i915->drm,
> -DRM_UT_DRIVER, __func__);
> +DRM_UT_DRIVER, NULL);
>  
>   intel_engine_dump(engine, ,
> "%s is still awake:%d after idle-barriers\n",

-- 
Jani Nikula, Intel

[PATCH 3/3] drm/i915: Don't use __func__ as prefix for drm_dbg_printer

2024-05-17 Thread Michal Wajdeczko 
Updated code of drm_dbg_printer() is already printing symbolic
name of the caller like drm_dbg() does.

Signed-off-by: Michal Wajdeczko 
---
 drivers/gpu/drm/i915/gt/intel_reset.c  | 2 +-
 drivers/gpu/drm/i915/gt/selftest_context.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c 
b/drivers/gpu/drm/i915/gt/intel_reset.c
index 6161f7a3ff70..735cd23a43c6 100644
--- a/drivers/gpu/drm/i915/gt/intel_reset.c
+++ b/drivers/gpu/drm/i915/gt/intel_reset.c
@@ -1025,7 +1025,7 @@ void intel_gt_set_wedged(struct intel_gt *gt)
 
if (GEM_SHOW_DEBUG()) {
struct drm_printer p = drm_dbg_printer(>i915->drm,
-  DRM_UT_DRIVER, __func__);
+  DRM_UT_DRIVER, NULL);
struct intel_engine_cs *engine;
enum intel_engine_id id;
 
diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c 
b/drivers/gpu/drm/i915/gt/selftest_context.c
index 12eca750f7d0..5eb46700dc4e 100644
--- a/drivers/gpu/drm/i915/gt/selftest_context.c
+++ b/drivers/gpu/drm/i915/gt/selftest_context.c
@@ -286,7 +286,7 @@ static int __live_active_context(struct intel_engine_cs 
*engine)
 
if (intel_engine_pm_is_awake(engine)) {
struct drm_printer p = drm_dbg_printer(>i915->drm,
-  DRM_UT_DRIVER, __func__);
+  DRM_UT_DRIVER, NULL);
 
intel_engine_dump(engine, ,
  "%s is still awake:%d after idle-barriers\n",
-- 
2.43.0