[PATCH v9 12/12] drm/i915/psr: Add panel replay sel update support to debugfs interface

2024-05-02 Thread Jouni Högander
Add panel replay selective update support to debugfs status interface. In
case of sink supporting panel replay we will print out:

Sink support: PSR = no, Panel Replay = yes, Panel Replay Selective Update = yes

and PSR mode will look like this if printing out enabled panel replay
selective update:

PSR mode: Panel Replay Selective Update Enabled

Current PSR and panel replay printouts remain same.

Cc: Kunal Joshi 

Signed-off-by: Jouni Högander 
---
 drivers/gpu/drm/i915/display/intel_psr.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c 
b/drivers/gpu/drm/i915/display/intel_psr.c
index 2198448fdb27..2ad7964998e0 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -3575,7 +3575,9 @@ static int intel_psr_status(struct seq_file *m, struct 
intel_dp *intel_dp)
 
if (psr->sink_support)
seq_printf(m, " [0x%02x]", intel_dp->psr_dpcd[0]);
-   seq_printf(m, ", Panel Replay = %s\n", 
str_yes_no(psr->sink_panel_replay_support));
+   seq_printf(m, ", Panel Replay = %s", 
str_yes_no(psr->sink_panel_replay_support));
+   seq_printf(m, ", Panel Replay Selective Update = %s\n",
+  str_yes_no(psr->sink_panel_replay_su_support));
 
if (!(psr->sink_support || psr->sink_panel_replay_support))
return 0;
@@ -3584,9 +3586,10 @@ static int intel_psr_status(struct seq_file *m, struct 
intel_dp *intel_dp)
mutex_lock(&psr->lock);
 
if (psr->panel_replay_enabled)
-   status = "Panel Replay Enabled";
+   status = psr->sel_update_enabled ? "Panel Replay Selective 
Update Enabled" :
+   "Panel Replay Enabled";
else if (psr->enabled)
-   status = psr->sel_update_enabled ? "PSR2 enabled" : "PSR1 
enabled";
+   status = psr->sel_update_enabled ? "PSR2" : "PSR1";
else
status = "disabled";
seq_printf(m, "PSR mode: %s\n", status);
-- 
2.34.1



RE: [PATCH v9 12/12] drm/i915/psr: Add panel replay sel update support to debugfs interface

2024-05-09 Thread Manna, Animesh


> -Original Message-
> From: Hogander, Jouni 
> Sent: Friday, May 3, 2024 12:04 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh ; Hogander, Jouni
> ; Joshi, Kunal1 
> Subject: [PATCH v9 12/12] drm/i915/psr: Add panel replay sel update
> support to debugfs interface
> 
> Add panel replay selective update support to debugfs status interface. In
> case of sink supporting panel replay we will print out:
> 
> Sink support: PSR = no, Panel Replay = yes, Panel Replay Selective Update =
> yes
> 
> and PSR mode will look like this if printing out enabled panel replay 
> selective
> update:
> 
> PSR mode: Panel Replay Selective Update Enabled
> 
> Current PSR and panel replay printouts remain same.
> 
> Cc: Kunal Joshi 
> 
> Signed-off-by: Jouni Högander 

Reviewed-by: Animesh Manna 

> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 2198448fdb27..2ad7964998e0 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -3575,7 +3575,9 @@ static int intel_psr_status(struct seq_file *m, struct
> intel_dp *intel_dp)
> 
>   if (psr->sink_support)
>   seq_printf(m, " [0x%02x]", intel_dp->psr_dpcd[0]);
> - seq_printf(m, ", Panel Replay = %s\n", str_yes_no(psr-
> >sink_panel_replay_support));
> + seq_printf(m, ", Panel Replay = %s", str_yes_no(psr-
> >sink_panel_replay_support));
> + seq_printf(m, ", Panel Replay Selective Update = %s\n",
> +str_yes_no(psr->sink_panel_replay_su_support));
> 
>   if (!(psr->sink_support || psr->sink_panel_replay_support))
>   return 0;
> @@ -3584,9 +3586,10 @@ static int intel_psr_status(struct seq_file *m,
> struct intel_dp *intel_dp)
>   mutex_lock(&psr->lock);
> 
>   if (psr->panel_replay_enabled)
> - status = "Panel Replay Enabled";
> + status = psr->sel_update_enabled ? "Panel Replay Selective
> Update Enabled" :
> + "Panel Replay Enabled";
>   else if (psr->enabled)
> - status = psr->sel_update_enabled ? "PSR2 enabled" : "PSR1
> enabled";
> + status = psr->sel_update_enabled ? "PSR2" : "PSR1";
>   else
>   status = "disabled";
>   seq_printf(m, "PSR mode: %s\n", status);
> --
> 2.34.1