Re: [Intel-gfx] [PATCH] drm/i915: Fix uninitialized mask in intel_device_info_subplatform_init
On Wed, Apr 03, 2019 at 09:13:59AM +0100, Tvrtko Ursulin wrote: > P.S. Also the assert about no junk in high bits did not fire in CI which > would suggest stack slot was either zero or no more than three low bits > sets. Strange luck. GCC happens to initialize it to zero. It's also why GCC didn't trigger an uninialized variable warning. The bug was reported to GCC years ago. regards, dan carpenter ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Fix uninitialized mask in intel_device_info_subplatform_init
On 03/04/2019 08:13, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-04-03 07:44:07)
From: Tvrtko Ursulin
Mask need to be initialized to zero since device id checks may not match.
Signed-off-by: Tvrtko Ursulin
Reported-by: Dan Carpenter
Fixes: 805446c8347c ("drm/i915: Introduce concept of a sub-platform")
Cc: Tvrtko Ursulin
Cc: Chris Wilson
Cc: Jani Nikula
Cc: Lucas De Marchi
Cc: Jose Souza
Cc: Ville Syrjälä
Cc: Paulo Zanoni
Cc: Jani Nikula
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Cc: Dan Carpenter
Bots are doing a better job than me, but still
Reviewed-by: Chris Wilson
It's my bad, probably introduced due various refactoring of the patch
itself. Since I definitely remember changing the mask initialization
back and forth.
No huge harm done since caught quickly by this very valuable service
provided by Dan.
Regards,
Tvrtko
P.S. Also the assert about no junk in high bits did not fire in CI which
would suggest stack slot was either zero or no more than three low bits
sets. Strange luck.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Fix uninitialized mask in intel_device_info_subplatform_init
Quoting Tvrtko Ursulin (2019-04-03 07:44:07)
> From: Tvrtko Ursulin
>
> Mask need to be initialized to zero since device id checks may not match.
>
> Signed-off-by: Tvrtko Ursulin
> Reported-by: Dan Carpenter
> Fixes: 805446c8347c ("drm/i915: Introduce concept of a sub-platform")
> Cc: Tvrtko Ursulin
> Cc: Chris Wilson
> Cc: Jani Nikula
> Cc: Lucas De Marchi
> Cc: Jose Souza
> Cc: Ville Syrjälä
> Cc: Paulo Zanoni
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Dan Carpenter
Bots are doing a better job than me, but still
Reviewed-by: Chris Wilson
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
