Re: [Intel-gfx] [PATCH] drm/i915: Re-enable fastboot by default

2017-11-01 Thread Ville Syrjälä 
On Wed, Nov 01, 2017 at 05:06:43PM +0200, Ville Syrjälä wrote:
> On Wed, Nov 01, 2017 at 03:53:25PM +0100, Maarten Lankhorst wrote:
> > This fix was originally reverted because it left a chromebook pixel
> > black, and no immediate fix was available. This has been fixed in the
> > meantime.
> > 
> > Rather than trying to remove the parameter, set it to default to true
> > for now, so we can always back out if required.
> 
> Like I said we have gaps in the state readout (eg. infoframes), so this
> doesn't look entirely sane to me.

BTW speaking of infofames I started moving them into atomic state(s),
but I didn't add full readout yet.

git://github.com/vsyrjala/linux.git infoframe_state_const

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Re-enable fastboot by default

2017-11-01 Thread Ville Syrjälä 
On Wed, Nov 01, 2017 at 03:53:25PM +0100, Maarten Lankhorst wrote:
> This fix was originally reverted because it left a chromebook pixel
> black, and no immediate fix was available. This has been fixed in the
> meantime.
> 
> Rather than trying to remove the parameter, set it to default to true
> for now, so we can always back out if required.

Like I said we have gaps in the state readout (eg. infoframes), so this
doesn't look entirely sane to me.

> 
> Signed-off-by: Maarten Lankhorst 
> Cc: Jani Nikula 
> Cc: Daniel Vetter 
> Testcase: kms_panel_fitting
> ---
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.h 
> b/drivers/gpu/drm/i915/i915_params.h
> index e54e6a4bc6bd..396126aac932 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -57,7 +57,7 @@
>   param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
>   param(bool, enable_cmd_parser, true) \
>   param(bool, enable_hangcheck, true) \
> - param(bool, fastboot, false) \
> + param(bool, fastboot, true) \
>   param(bool, prefault_disable, false) \
>   param(bool, load_detect_test, false) \
>   param(bool, force_reset_modeset_test, false) \
> -- 
> 2.14.1
> 
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx