Re: [Intel-gfx] [PATCH] drm/i915: move encoder-mode_set calls to crtc_mode_set

2012-11-01 Thread Daniel Vetter
On Wed, Oct 31, 2012 at 10:46:36PM +, Chris Wilson wrote:
 On Wed, 31 Oct 2012 19:26:13 +0100, Daniel Vetter daniel.vet...@ffwll.ch 
 wrote:
  Makes more sense to group the entire mode_set stage into one function.
  Noticed while discussiing the rather confusing set of function names
  with Paulo Zanoni. Unfortunately I don't have an idea to make the
  function names lesss confusion.
  
  v2: Use for_each_encoder_on_crtc as suggested by Chris Wilson.
  
  Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
 
 Just a simple piece of code movement, with a sprinkling of sugar on top.
 Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk
Queued for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH] drm/i915: move encoder-mode_set calls to crtc_mode_set

2012-10-31 Thread Chris Wilson
On Wed, 31 Oct 2012 19:26:13 +0100, Daniel Vetter daniel.vet...@ffwll.ch 
wrote:
 Makes more sense to group the entire mode_set stage into one function.
 Noticed while discussiing the rather confusing set of function names
 with Paulo Zanoni. Unfortunately I don't have an idea to make the
 function names lesss confusion.
 
 v2: Use for_each_encoder_on_crtc as suggested by Chris Wilson.
 
 Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch

Just a simple piece of code movement, with a sprinkling of sugar on top.
Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH] drm/i915: move encoder-mode_set calls to crtc_mode_set

2012-10-12 Thread Chris Wilson
On Thu, 11 Oct 2012 19:46:07 +0200, Daniel Vetter daniel.vet...@ffwll.ch 
wrote:
 Makes more sense to group the entire mode_set stage into one function.
 Noticed while discussion the rather confusing set of function names
 with Paulo Zanoni. Unfortunately I don't have an idea to make the
 function names lesss confusion.

for_each_encoder_on_crtc()
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx