Re: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps members under display.pps
On Thu, Aug 11, 2022 at 06:07:21PM +0300, Jani Nikula wrote: Move display related members under drm_i915_private display sub-struct. Signed-off-by: Jani Nikula Reviewed-by: Lucas De Marchi Lucas De Marchi
Re: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps members under display.pps
> -Original Message-
> From: Nikula, Jani
> Sent: Friday, August 12, 2022 12:28 PM
> To: Murthy, Arun R ; intel-
> g...@lists.freedesktop.org
> Cc: De Marchi, Lucas
> Subject: RE: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps
> members under display.pps
>
> On Fri, 12 Aug 2022, "Murthy, Arun R" wrote:
> >> -Original Message-
> >> From: Intel-gfx On Behalf
> >> Of Jani Nikula
> >> Sent: Thursday, August 11, 2022 8:37 PM
> >> To: intel-gfx@lists.freedesktop.org
> >> Cc: Nikula, Jani ; De Marchi, Lucas
> >>
> >> Subject: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps
> >> members under display.pps
> >>
> >> Move display related members under drm_i915_private display sub-
> struct.
> >>
> >> Signed-off-by: Jani Nikula
> >> ---
> >> .../gpu/drm/i915/display/intel_display_core.h | 7 +++
> >> drivers/gpu/drm/i915/display/intel_pps.c | 48 +--
> >> drivers/gpu/drm/i915/i915_driver.c| 2 +-
> >> drivers/gpu/drm/i915/i915_drv.h | 5 --
> >> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> >> 5 files changed, 33 insertions(+), 31 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h
> >> b/drivers/gpu/drm/i915/display/intel_display_core.h
> >> index fe19d4f9a9ab..030ced4068bb 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_display_core.h
> >> +++ b/drivers/gpu/drm/i915/display/intel_display_core.h
> >> @@ -101,6 +101,13 @@ struct intel_display {
> >>
> >> wait_queue_head_t wait_queue;
> >> } gmbus;
> >> +
> >> + struct {
> >> + u32 mmio_base;
> >> +
> >> + /* protects panel power sequencer state */
> >> + struct mutex mutex;
> >> + } pps;
> >> };
> > Again can this power related to be moved under a substruct intel_pm ?
>
> The pps is pretty well separated from rest of pm, so feels wrong to shove it
> together with pm. And again, intel_pm makes me think intel_pm.c which is
> not purely display, and needs to be reorganized.
>
Maybe a subordinate of pm. Lets take it up later. I would prefer to have a TODO
under all of these would lets us keep an eye on this part of the cleanup.
Reviewed-by: Arun R Murthy
Thanks and Regards,
Arun R Murthy
Re: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps members under display.pps
On Fri, 12 Aug 2022, "Murthy, Arun R" wrote:
>> -Original Message-
>> From: Intel-gfx On Behalf Of Jani
>> Nikula
>> Sent: Thursday, August 11, 2022 8:37 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Nikula, Jani ; De Marchi, Lucas
>>
>> Subject: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps members
>> under display.pps
>>
>> Move display related members under drm_i915_private display sub-struct.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> .../gpu/drm/i915/display/intel_display_core.h | 7 +++
>> drivers/gpu/drm/i915/display/intel_pps.c | 48 +--
>> drivers/gpu/drm/i915/i915_driver.c| 2 +-
>> drivers/gpu/drm/i915/i915_drv.h | 5 --
>> drivers/gpu/drm/i915/i915_reg.h | 2 +-
>> 5 files changed, 33 insertions(+), 31 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h
>> b/drivers/gpu/drm/i915/display/intel_display_core.h
>> index fe19d4f9a9ab..030ced4068bb 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_core.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_core.h
>> @@ -101,6 +101,13 @@ struct intel_display {
>>
>> wait_queue_head_t wait_queue;
>> } gmbus;
>> +
>> + struct {
>> + u32 mmio_base;
>> +
>> + /* protects panel power sequencer state */
>> + struct mutex mutex;
>> + } pps;
>> };
> Again can this power related to be moved under a substruct intel_pm ?
The pps is pretty well separated from rest of pm, so feels wrong to
shove it together with pm. And again, intel_pm makes me think intel_pm.c
which is not purely display, and needs to be reorganized.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
Re: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps members under display.pps
> -Original Message-
> From: Intel-gfx On Behalf Of Jani
> Nikula
> Sent: Thursday, August 11, 2022 8:37 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Nikula, Jani ; De Marchi, Lucas
>
> Subject: [Intel-gfx] [PATCH 10/39] drm/i915: move and group pps members
> under display.pps
>
> Move display related members under drm_i915_private display sub-struct.
>
> Signed-off-by: Jani Nikula
> ---
> .../gpu/drm/i915/display/intel_display_core.h | 7 +++
> drivers/gpu/drm/i915/display/intel_pps.c | 48 +--
> drivers/gpu/drm/i915/i915_driver.c| 2 +-
> drivers/gpu/drm/i915/i915_drv.h | 5 --
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> 5 files changed, 33 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h
> b/drivers/gpu/drm/i915/display/intel_display_core.h
> index fe19d4f9a9ab..030ced4068bb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_core.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_core.h
> @@ -101,6 +101,13 @@ struct intel_display {
>
> wait_queue_head_t wait_queue;
> } gmbus;
> +
> + struct {
> + u32 mmio_base;
> +
> + /* protects panel power sequencer state */
> + struct mutex mutex;
> + } pps;
> };
Again can this power related to be moved under a substruct intel_pm ?
Thanks and Regards
Arun R Murthy
