Re: [Intel-gfx] [PATCH 13/19] drm/i915: untested DP support for Ivy Bridge
On Sun, 01 May 2011 17:26:11 +0100 Chris Wilson wrote: > On Thu, 28 Apr 2011 15:12:59 -0700, Jesse Barnes > wrote: > > Treat it like Sandy Bridge in a few places. > > > > Signed-off-by: Jesse Barnes > > --- > > drivers/gpu/drm/i915/intel_dp.c |6 +++--- > > 1 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c > > b/drivers/gpu/drm/i915/intel_dp.c > > index 0daefca..1d0eccd 100644 > > --- a/drivers/gpu/drm/i915/intel_dp.c > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > @@ -312,7 +312,7 @@ intel_dp_aux_ch(struct intel_dp *intel_dp, > > else > > aux_clock_divider = intel_hrawclk(dev) / 2; > > > > - if (IS_GEN6(dev)) > > + if (IS_GEN6(dev) || IS_GEN7(dev)) > > Shouldn't these be IS_SANDYBRIDGE(dev) || IS_IVYBRIDGE(dev) following the > convention that info->gen is reserved for the render engine. > > Perhaps if you do the s/IS_GEN6/IS_SNADYBRIDGE/ fixes first it will become > much clearer? :) Yeah, sorry I violated my own rule, will fix (this one can be delayed until I can test it anyway). -- Jesse Barnes, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 13/19] drm/i915: untested DP support for Ivy Bridge
On Sun, 01 May 2011 17:26:11 +0100, Chris Wilson wrote: > Perhaps if you do the s/IS_GEN6/IS_SNADYBRIDGE/ fixes first it will become > much clearer? :) The only question is one of regressions; getting the cleanups tested in isolation from the IVB patches. That seems do-able for the 2.6.40 merge window. -- keith.pack...@intel.com pgpwscQGrJcxa.pgp Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 13/19] drm/i915: untested DP support for Ivy Bridge
On Thu, 28 Apr 2011 15:12:59 -0700, Jesse Barnes wrote: > Treat it like Sandy Bridge in a few places. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_dp.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 0daefca..1d0eccd 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -312,7 +312,7 @@ intel_dp_aux_ch(struct intel_dp *intel_dp, > else > aux_clock_divider = intel_hrawclk(dev) / 2; > > - if (IS_GEN6(dev)) > + if (IS_GEN6(dev) || IS_GEN7(dev)) Shouldn't these be IS_SANDYBRIDGE(dev) || IS_IVYBRIDGE(dev) following the convention that info->gen is reserved for the render engine. Perhaps if you do the s/IS_GEN6/IS_SNADYBRIDGE/ fixes first it will become much clearer? :) -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 13/19] drm/i915: untested DP support for Ivy Bridge
On Thu, 28 Apr 2011 15:12:59 -0700, Jesse Barnes wrote: > Treat it like Sandy Bridge in a few places. gen >= 6? -- keith.pack...@intel.com pgpqFHB2q8tev.pgp Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
