Re: [Intel-gfx] [PATCH 2/3] drm/i915: Check for ips_mchdev being NULL
Quoting Niranjan Vishwanathapura (2019-11-06 02:14:45) > On Wed, Nov 06, 2019 at 12:37:14AM +, Chris Wilson wrote: > >Quoting Niranjana Vishwanathapura (2019-11-06 00:02:04) > >> Guard against uninitalized (NULL) ips_mchdev before > >> dereferencing. > > > >Because? > > I am seeing some exported functions like i915_read_mch_val() that try to > dereference ips_mchdev via mchdev_get(). I don't know full usage here, > but probably make these APIs fail safe? Are you also going to make those functions safe when the module isn't there? If that module interface is used outside of the registration period, then the binding with the caller went horribly astray. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/3] drm/i915: Check for ips_mchdev being NULL
On Wed, Nov 06, 2019 at 12:37:14AM +, Chris Wilson wrote: Quoting Niranjana Vishwanathapura (2019-11-06 00:02:04) Guard against uninitalized (NULL) ips_mchdev before dereferencing. Because? I am seeing some exported functions like i915_read_mch_val() that try to dereference ips_mchdev via mchdev_get(). I don't know full usage here, but probably make these APIs fail safe? Niranjana -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/3] drm/i915: Check for ips_mchdev being NULL
Quoting Niranjana Vishwanathapura (2019-11-06 00:02:04) > Guard against uninitalized (NULL) ips_mchdev before > dereferencing. Because? -Chris - Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
