Re: [Intel-gfx] [PATCH i-g-t 4/4] igt/v3d_*: Add new tests for the V3D UABI.
Petri Latvala writes: > On Mon, Nov 26, 2018 at 12:46:46PM -0800, Eric Anholt wrote: >> Petri Latvala writes: >> >> > On Wed, Nov 14, 2018 at 02:28:32PM -0800, Eric Anholt wrote: >> >> These are basic non-rendering tests of the UABI. >> >> >> >> Signed-off-by: Eric Anholt >> >> --- >> >> lib/igt_v3d.c | 4 -- >> >> tests/Makefile.am | 2 + >> >> tests/Makefile.sources| 6 +++ >> >> tests/meson.build | 3 ++ >> >> tests/v3d_ci/README | 26 + >> >> tests/v3d_ci/v3d.testlist | 6 +++ >> >> tests/v3d_get_bo_offset.c | 78 ++ >> >> tests/v3d_get_param.c | 80 +++ >> >> tests/v3d_mmap.c | 55 +++ >> > >> > >> > Do you need a separate directory for v3d or can you use the vc4 >> > directory for v3d as well? Renamed to 'broadcom-ci' maybe? >> >> Do we really need to introduce the vendor name separate from the driver >> name? I guess intel_ci makes some sense if it's used by Intel's CI, but >> these are just the test lists for anyone that happens to use igt for >> this driver. > > Fair enough, I was assuming there's an active CI somewhere that used > both at the same time. > > > > Acked-by: Petri Latvala Thanks for taking a look at these and acking them! signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH i-g-t 4/4] igt/v3d_*: Add new tests for the V3D UABI.
On Mon, Nov 26, 2018 at 12:46:46PM -0800, Eric Anholt wrote: > Petri Latvala writes: > > > On Wed, Nov 14, 2018 at 02:28:32PM -0800, Eric Anholt wrote: > >> These are basic non-rendering tests of the UABI. > >> > >> Signed-off-by: Eric Anholt > >> --- > >> lib/igt_v3d.c | 4 -- > >> tests/Makefile.am | 2 + > >> tests/Makefile.sources| 6 +++ > >> tests/meson.build | 3 ++ > >> tests/v3d_ci/README | 26 + > >> tests/v3d_ci/v3d.testlist | 6 +++ > >> tests/v3d_get_bo_offset.c | 78 ++ > >> tests/v3d_get_param.c | 80 +++ > >> tests/v3d_mmap.c | 55 +++ > > > > > > Do you need a separate directory for v3d or can you use the vc4 > > directory for v3d as well? Renamed to 'broadcom-ci' maybe? > > Do we really need to introduce the vendor name separate from the driver > name? I guess intel_ci makes some sense if it's used by Intel's CI, but > these are just the test lists for anyone that happens to use igt for > this driver. Fair enough, I was assuming there's an active CI somewhere that used both at the same time. Acked-by: Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH i-g-t 4/4] igt/v3d_*: Add new tests for the V3D UABI.
Petri Latvala writes: > On Wed, Nov 14, 2018 at 02:28:32PM -0800, Eric Anholt wrote: >> These are basic non-rendering tests of the UABI. >> >> Signed-off-by: Eric Anholt >> --- >> lib/igt_v3d.c | 4 -- >> tests/Makefile.am | 2 + >> tests/Makefile.sources| 6 +++ >> tests/meson.build | 3 ++ >> tests/v3d_ci/README | 26 + >> tests/v3d_ci/v3d.testlist | 6 +++ >> tests/v3d_get_bo_offset.c | 78 ++ >> tests/v3d_get_param.c | 80 +++ >> tests/v3d_mmap.c | 55 +++ > > > Do you need a separate directory for v3d or can you use the vc4 > directory for v3d as well? Renamed to 'broadcom-ci' maybe? Do we really need to introduce the vendor name separate from the driver name? I guess intel_ci makes some sense if it's used by Intel's CI, but these are just the test lists for anyone that happens to use igt for this driver. signature.asc Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH i-g-t 4/4] igt/v3d_*: Add new tests for the V3D UABI.
On Wed, Nov 14, 2018 at 02:28:32PM -0800, Eric Anholt wrote: > These are basic non-rendering tests of the UABI. > > Signed-off-by: Eric Anholt > --- > lib/igt_v3d.c | 4 -- > tests/Makefile.am | 2 + > tests/Makefile.sources| 6 +++ > tests/meson.build | 3 ++ > tests/v3d_ci/README | 26 + > tests/v3d_ci/v3d.testlist | 6 +++ > tests/v3d_get_bo_offset.c | 78 ++ > tests/v3d_get_param.c | 80 +++ > tests/v3d_mmap.c | 55 +++ Do you need a separate directory for v3d or can you use the vc4 directory for v3d as well? Renamed to 'broadcom-ci' maybe? > 9 files changed, 256 insertions(+), 4 deletions(-) > create mode 100644 tests/v3d_ci/README > create mode 100644 tests/v3d_ci/v3d.testlist > create mode 100644 tests/v3d_get_bo_offset.c > create mode 100644 tests/v3d_get_param.c > create mode 100644 tests/v3d_mmap.c > > diff --git a/lib/igt_v3d.c b/lib/igt_v3d.c > index 1a5ede1bd5fc..619c072c0e47 100644 > --- a/lib/igt_v3d.c > +++ b/lib/igt_v3d.c > @@ -40,10 +40,6 @@ > #include "intel_chipset.h" > #include "v3d_drm.h" > > -#if NEW_CONTEXT_PARAM_NO_ERROR_CAPTURE_API > -#define LOCAL_CONTEXT_PARAM_NO_ERROR_CAPTURE 0x4 > -#endif > - > /** > * SECTION:igt_v3d > * @short_description: V3D support library > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 3d1ce0bc1af8..a6b2ba51ea4f 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -14,6 +14,8 @@ if BUILD_VC4 > TESTS_progs += $(VC4_TESTS) > endif > > +TESTS_progs += $(V3D_TESTS) > + > if HAVE_CHAMELIUM > TESTS_progs += \ > kms_chamelium \ > diff --git a/tests/Makefile.sources b/tests/Makefile.sources > index d007ebc74ab9..3ed60e7c30c7 100644 > --- a/tests/Makefile.sources > +++ b/tests/Makefile.sources > @@ -15,6 +15,12 @@ VC4_TESTS = \ > vc4_wait_seqno \ > $(NULL) > > +V3D_TESTS = \ > + v3d_get_bo_offset \ > + v3d_get_param \ > + v3d_mmap \ > + $(NULL) > + > AMDGPU_TESTS = \ > amdgpu/amd_basic \ > amdgpu/amd_cs_nop \ > diff --git a/tests/meson.build b/tests/meson.build > index 3020f7984d7a..4472536aef65 100644 > --- a/tests/meson.build > +++ b/tests/meson.build > @@ -85,6 +85,9 @@ test_progs = [ > 'syncobj_wait', > 'template', > 'tools_test', > + 'v3d_get_bo_offset', > + 'v3d_get_param', > + 'v3d_mmap', > 'vc4_create_bo', > 'vc4_dmabuf_poll', > 'vc4_label_bo', > diff --git a/tests/v3d_ci/README b/tests/v3d_ci/README > new file mode 100644 > index ..e03c552fb972 > --- /dev/null > +++ b/tests/v3d_ci/README > @@ -0,0 +1,26 @@ > +This directory contains test lists to be used for v3d's DRM support. The > files > +are passed to piglit with the --test-list parameter directly. Note to self: Change this piglit reference to igt_runner (or both) in intel-ci/README... -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
