Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/crt: remove BUG_ON()

2022-08-31 Thread Jani Nikula 
On Wed, 31 Aug 2022, Andrzej Hajda  wrote:
> On 30.08.2022 11:34, Jani Nikula wrote:
>> Avoid BUG_ON(). We don't have such checks on output type anywhere else
>> either, so just remove.
>> 
>> Suggested-by: Ville Syrjälä 
>> Signed-off-by: Jani Nikula 
>> ---
> Reviewed-by: Andrzej Hajda 

Thanks for the reviews, pushed to drm-intel-next.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/crt: remove BUG_ON()

2022-08-31 Thread Andrzej Hajda 

On 30.08.2022 11:34, Jani Nikula wrote:

Avoid BUG_ON(). We don't have such checks on output type anywhere else
either, so just remove.

Suggested-by: Ville Syrjälä 
Signed-off-by: Jani Nikula 
---

Reviewed-by: Andrzej Hajda 

Regards
Andrzej

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/crt: remove BUG_ON()

2022-08-31 Thread Ville Syrjälä 
On Tue, Aug 30, 2022 at 12:34:07PM +0300, Jani Nikula wrote:
> Avoid BUG_ON(). We don't have such checks on output type anywhere else
> either, so just remove.
> 
> Suggested-by: Ville Syrjälä 
> Signed-off-by: Jani Nikula 

Reviewed-by: Ville Syrjälä 

> ---
>  drivers/gpu/drm/i915/display/intel_crt.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_crt.c 
> b/drivers/gpu/drm/i915/display/intel_crt.c
> index 6a3893c8ff22..d766c506b235 100644
> --- a/drivers/gpu/drm/i915/display/intel_crt.c
> +++ b/drivers/gpu/drm/i915/display/intel_crt.c
> @@ -643,8 +643,6 @@ static bool intel_crt_detect_ddc(struct drm_connector 
> *connector)
>   struct i2c_adapter *i2c;
>   bool ret = false;
>  
> - BUG_ON(crt->base.type != INTEL_OUTPUT_ANALOG);
> -
>   i2c = intel_gmbus_get_adapter(dev_priv, dev_priv->vbt.crt_ddc_pin);
>   edid = intel_crt_get_edid(connector, i2c);
>  
> -- 
> 2.34.1

-- 
Ville Syrjälä
Intel