Re: [Intel-gfx] [PATCH v3] drm/i915: Fix forcewake active domain tracking

2017-03-10 Thread Tvrtko Ursulin 


On 10/03/2017 10:54, Chris Wilson wrote:

On Fri, Mar 10, 2017 at 09:32:49AM +, Tvrtko Ursulin wrote:

From: Tvrtko Ursulin 

In commit 003342a50021 ("drm/i915: Keep track of active
forcewake domains in a bitmask") I forgot to adjust the
newly introduce fw_domains_active state across reset.

This caused the assert_forcewakes_inactive to trigger
during suspend and resume if there were user held
forcewakes.

v2: Bitmask checks are required since vfuncs are not
always present.

v3: Move bitmask tracking to get/put vfunc for simplicity.
(Chris Wilson)

Signed-off-by: Tvrtko Ursulin 
Fixes: 003342a50021 ("drm/i915: Keep track of active forcewake domains in a 
bitmask")
Testcase: igt/drv_suspend/forcewake
Cc: Tvrtko Ursulin 
Cc: "Paneri, Praveen" 
Cc: Chris Wilson 
Cc: Daniel Vetter 
Cc: Jani Nikula 
Cc: intel-gfx@lists.freedesktop.org
Cc: v4.10+ 


After being a chicken and waiting for CI,
Reviewed-by: Chris Wilson 


I know the feeling! Thanks, I also hope I haven't missed anything.

Pushed now.

Regards,

Tvrtko
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3] drm/i915: Fix forcewake active domain tracking

2017-03-10 Thread Chris Wilson 
On Fri, Mar 10, 2017 at 09:32:49AM +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin 
> 
> In commit 003342a50021 ("drm/i915: Keep track of active
> forcewake domains in a bitmask") I forgot to adjust the
> newly introduce fw_domains_active state across reset.
> 
> This caused the assert_forcewakes_inactive to trigger
> during suspend and resume if there were user held
> forcewakes.
> 
> v2: Bitmask checks are required since vfuncs are not
> always present.
> 
> v3: Move bitmask tracking to get/put vfunc for simplicity.
> (Chris Wilson)
> 
> Signed-off-by: Tvrtko Ursulin 
> Fixes: 003342a50021 ("drm/i915: Keep track of active forcewake domains in a 
> bitmask")
> Testcase: igt/drv_suspend/forcewake
> Cc: Tvrtko Ursulin 
> Cc: "Paneri, Praveen" 
> Cc: Chris Wilson 
> Cc: Daniel Vetter 
> Cc: Jani Nikula 
> Cc: intel-gfx@lists.freedesktop.org
> Cc: v4.10+ 

After being a chicken and waiting for CI,
Reviewed-by: Chris Wilson 
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx