Re: [Intel-gfx] [PATCH v4] drm/i915: Compare GGTT view structs instead of types
Hi, On 03/27/2015 11:09 AM, Joonas Lahtinen wrote: To allow for views where the view type is not defined by the view type only, like it is in stereo or rotated 90 degree view, change the semantic to require the whole view structure for comparison when we match a GGTT view. This allows including parameters like offset to be included in the view which is useful for eg. partial views. v3: - Rely on ggtt_view type being 0 for non-GGTT vma's, which equals to I915_GGTT_VIEW_NORMAL. (Daniel Vetter) - Do not use potentially slower comparison when we only want to know if something is or is not a normal view. - Rebase on top of rotated view patches. Add rotated view singleton. - If one view is missing in comparison they're equal only if both are missing. v4: - Use comparison helper in obj_to_ggtt_view too. (Tvrtko Ursulin) - Do WARN_ON if one view is NULL. (Tvrtko Ursulin) Cc: Daniel Vetter Reviewed-by: Tvrtko Ursulin (v2) Signed-off-by: Joonas Lahtinen Reviewed-by: Tvrtko Ursulin Regards, Tvrtko ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4] drm/i915: Compare GGTT view structs instead of types
On Fri, Mar 27, 2015 at 11:46:24AM +, Tvrtko Ursulin wrote: > > Hi, > > On 03/27/2015 11:09 AM, Joonas Lahtinen wrote: > >To allow for views where the view type is not defined by the view type only, > >like it is in stereo or rotated 90 degree view, change the semantic to > >require > >the whole view structure for comparison when we match a GGTT view. > > > >This allows including parameters like offset to be included in the view which > >is useful for eg. partial views. > > > >v3: > >- Rely on ggtt_view type being 0 for non-GGTT vma's, which equals to > > I915_GGTT_VIEW_NORMAL. (Daniel Vetter) > >- Do not use potentially slower comparison when we only want to know if > > something is or is not a normal view. > >- Rebase on top of rotated view patches. Add rotated view singleton. > >- If one view is missing in comparison they're equal only if both are > >missing. > > > >v4: > >- Use comparison helper in obj_to_ggtt_view too. (Tvrtko Ursulin) > >- Do WARN_ON if one view is NULL. (Tvrtko Ursulin) > > > >Cc: Daniel Vetter > >Reviewed-by: Tvrtko Ursulin (v2) > >Signed-off-by: Joonas Lahtinen > > Reviewed-by: Tvrtko Ursulin Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v4] drm/i915: Compare GGTT view structs instead of types
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6076 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 276/276 276/276 ILK 303/303 303/303 SNB 304/304 304/304 IVB -2 330/330 328/330 BYT 287/287 287/287 HSW 361/361 361/361 BDW 309/309 309/309 -Detailed- Platform Testdrm-intel-nightly Series Applied *IVB igt@gem_storedw_batches_loop@normal PASS(5) DMESG_WARN(2) (dmesg patch applied)drm:i915_hangcheck_elapsed[i915]]*ERROR*Hangcheck_timer_elapsed...blitter_ring_idle@Hangcheck timer elapsed... blitter ring idle *IVB igt@gem_storedw_batches_loop@secure-dispatch PASS(2) DMESG_WARN(1)PASS(1) (dmesg patch applied)drm:i915_hangcheck_elapsed[i915]]*ERROR*Hangcheck_timer_elapsed...blitter_ring_idle@Hangcheck timer elapsed... blitter ring idle Note: You need to pay more attention to line start with '*' ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
