Re: [Intel-gfx] [PATCH v4 00/41] drm/i915: Implement HDCP2.2
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, May 29, 2018 2:01 PM > To: C, Ramalingam > Cc: Daniel Vetter ; intel-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; seanp...@chromium.org; chris@chris- > wilson.co.uk; jani.nik...@linux.intel.com; Winkler, Tomas > ; Usyskin, Alexander > ; Shankar, Uma ; > Sharma, Shashank > Subject: Re: [PATCH v4 00/41] drm/i915: Implement HDCP2.2 > > On Tue, May 29, 2018 at 07:51:56AM +, C, Ramalingam wrote: > > > -Original Message- > > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of > > > Daniel Vetter > > > Sent: Tuesday, May 29, 2018 12:27 PM > > > To: C, Ramalingam > > > Cc: intel-gfx@lists.freedesktop.org; > > > dri-de...@lists.freedesktop.org; seanp...@chromium.org; > > > dan...@ffwll.ch; ch...@chris-wilson.co.uk; > > > jani.nik...@linux.intel.com; Winkler, Tomas > > > ; Usyskin, Alexander > > > ; Shankar, Uma ; > > > Sharma, Shashank > > > Subject: Re: [PATCH v4 00/41] drm/i915: Implement HDCP2.2 > > > > > > On Mon, May 21, 2018 at 06:23:19PM +0530, Ramalingam C wrote: > > > > The sequence for HDCP2.2 authentication and encryption is > > > > implemented in I915. Encoder specific implementations are moved into > hdcp_shim. > > > > > > > > Intel HWs supports HDCP2.2 through ME FW. Hence this series > > > > introduces a client driver for mei bus, so that for HDCP2.2 > > > > authentication, > > > > HDCP2.2 stack in I915 can avail the services from ME FW. > > > > > > > > DRM_I915 selects INTEL_MEI_HDCP, which selects INTEL_MEI_ME and > > > > INTEL_MEI. If we are interested in disabling the MEI_HDCP and MEI > > > > Bus then we need an option to disable the HDCP2.2 in I915 (like > > > > DRM_I915_HDCP2.2!?). Till then they are binded. > > > > > > > > Userspace interface remains unchanged as version agnostic. When > > > > userspace request for HDCP enable, Kernel will detect the HDCP > > > > source and sink's HDCP version(1.4/2.2)capability and enable the > > > > best capable version for that combination. > > > > > > > > This series enables the HDCP2.2 for Type0 content streams. > > > > > > > > Thanks a lot for Usyskin, Alexander and Uma shankar for the review of > > > > v3. > > > > Thanks Daniel vetter for guiding me to test and confirm that there > > > > is no locking issue with respect to notifier usage between I915 and > MEI_HDCP. > > > > > > > > Major Changes in v4: > > > > - GMBus Changes to implement the burst read as generic > > > > [Jani, Ville and Daniel] > > > > - Polling is added for extra Notifier notification when I915 and > > > > MEI_HDCP are modules. > > > > - Comment and style issues and typos are fixed [Uma and Alexander] > > > > - INTEL_MEI_HDCP, INTEL_MEI_ME and INTEL_MEI are selected by I915. > > > > - Fixed the #if in include/linux/mei_hdcp.h for build issues. > > > > > > > > GMBus changes are added here for completeness of the series. They > > > > are in review at https://patchwork.freedesktop.org/series/41632/ also. > > > > > > Please reply with a link to your github here (and include it in your > > > next cover letter too). I can't ever find it when I need it :-/ > > > > You can find a github repo for HDCP2.2 v4 series at > > https://github.com/ramalingampc2008/drm-tip > > Even nicer if you directly supply what I need to feed to git fetch (like a > git pull > request over email): > > https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v4 > > Then I can do a git fetch && git checkout FETCH_HEAD. Ok. Sure. Thanks, Ram. > > Thanks, Daniel > > > > > Thanks, > > Ram > > > > > > > > Thanks, Daniel > > > > > > > > > > > Ramalingam C (40): > > > > drm: hdcp2.2 authentication msg definitions > > > > drm: HDMI and DP specific HDCP2.2 defines > > > > misc/mei/hdcp: Client driver for HDCP application > > > > misc/mei/hdcp: Notifier chain for mei cldev state change > > > > misc/mei/hdcp: Define ME FW interface for HDCP2.2 > > > > linux/mei: Header for mei_hdcp driver interface > > > > misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session > > > > misc/mei/hdcp: Verify Receiver Cert and prepare km > > > > misc/mei/hdcp: Verify H_prime > > > > misc/mei/hdcp: Store the HDCP Pairing info > > > > misc/mei/hdcp: Initiate Locality check > > > > misc/mei/hdcp: Verify L_prime > > > > misc/mei/hdcp: Prepare Session Key > > > > misc/mei/hdcp: Repeater topology verification and ack > > > > misc/mei/hdcp: Verify M_prime > > > > misc/mei/hdcp: Enabling the HDCP authentication > > > > misc/mei/hdcp: Closing wired HDCP2.2 Tx Session > > > > drm/i915: wrapping all hdcp var into intel_hdcp > > > > drm/i915: Define HDCP2.2 related variables > > > > drm/i915: Define Intel HDCP2.2 registers > > > > drm/i915: Wrappers for mei HDCP2.2 services > > > > drm/i915: Implement HDCP2.2 receiver authentication > > > > drm/i915: Implement HDCP2.2 repeater authentication > > > > drm/i915
Re: [Intel-gfx] [PATCH v4 00/41] drm/i915: Implement HDCP2.2
On Tue, May 29, 2018 at 07:51:56AM +, C, Ramalingam wrote: > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Vetter > > Sent: Tuesday, May 29, 2018 12:27 PM > > To: C, Ramalingam > > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > > seanp...@chromium.org; dan...@ffwll.ch; ch...@chris-wilson.co.uk; > > jani.nik...@linux.intel.com; Winkler, Tomas ; > > Usyskin, Alexander ; Shankar, Uma > > ; Sharma, Shashank > > Subject: Re: [PATCH v4 00/41] drm/i915: Implement HDCP2.2 > > > > On Mon, May 21, 2018 at 06:23:19PM +0530, Ramalingam C wrote: > > > The sequence for HDCP2.2 authentication and encryption is implemented > > > in I915. Encoder specific implementations are moved into hdcp_shim. > > > > > > Intel HWs supports HDCP2.2 through ME FW. Hence this series introduces > > > a client driver for mei bus, so that for HDCP2.2 authentication, > > > HDCP2.2 stack in I915 can avail the services from ME FW. > > > > > > DRM_I915 selects INTEL_MEI_HDCP, which selects INTEL_MEI_ME and > > > INTEL_MEI. If we are interested in disabling the MEI_HDCP and MEI Bus > > > then we need an option to disable the HDCP2.2 in I915 (like > > > DRM_I915_HDCP2.2!?). Till then they are binded. > > > > > > Userspace interface remains unchanged as version agnostic. When > > > userspace request for HDCP enable, Kernel will detect the HDCP source > > > and sink's HDCP version(1.4/2.2)capability and enable the best capable > > > version for that combination. > > > > > > This series enables the HDCP2.2 for Type0 content streams. > > > > > > Thanks a lot for Usyskin, Alexander and Uma shankar for the review of v3. > > > Thanks Daniel vetter for guiding me to test and confirm that there is > > > no locking issue with respect to notifier usage between I915 and MEI_HDCP. > > > > > > Major Changes in v4: > > > - GMBus Changes to implement the burst read as generic > > > [Jani, Ville and Daniel] > > > - Polling is added for extra Notifier notification when I915 and > > > MEI_HDCP are modules. > > > - Comment and style issues and typos are fixed [Uma and Alexander] > > > - INTEL_MEI_HDCP, INTEL_MEI_ME and INTEL_MEI are selected by I915. > > > - Fixed the #if in include/linux/mei_hdcp.h for build issues. > > > > > > GMBus changes are added here for completeness of the series. They are > > > in review at https://patchwork.freedesktop.org/series/41632/ also. > > > > Please reply with a link to your github here (and include it in your next > > cover > > letter too). I can't ever find it when I need it :-/ > > You can find a github repo for HDCP2.2 v4 series at > https://github.com/ramalingampc2008/drm-tip Even nicer if you directly supply what I need to feed to git fetch (like a git pull request over email): https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v4 Then I can do a git fetch && git checkout FETCH_HEAD. Thanks, Daniel > > Thanks, > Ram > > > > > Thanks, Daniel > > > > > > > > Ramalingam C (40): > > > drm: hdcp2.2 authentication msg definitions > > > drm: HDMI and DP specific HDCP2.2 defines > > > misc/mei/hdcp: Client driver for HDCP application > > > misc/mei/hdcp: Notifier chain for mei cldev state change > > > misc/mei/hdcp: Define ME FW interface for HDCP2.2 > > > linux/mei: Header for mei_hdcp driver interface > > > misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session > > > misc/mei/hdcp: Verify Receiver Cert and prepare km > > > misc/mei/hdcp: Verify H_prime > > > misc/mei/hdcp: Store the HDCP Pairing info > > > misc/mei/hdcp: Initiate Locality check > > > misc/mei/hdcp: Verify L_prime > > > misc/mei/hdcp: Prepare Session Key > > > misc/mei/hdcp: Repeater topology verification and ack > > > misc/mei/hdcp: Verify M_prime > > > misc/mei/hdcp: Enabling the HDCP authentication > > > misc/mei/hdcp: Closing wired HDCP2.2 Tx Session > > > drm/i915: wrapping all hdcp var into intel_hdcp > > > drm/i915: Define HDCP2.2 related variables > > > drm/i915: Define Intel HDCP2.2 registers > > > drm/i915: Wrappers for mei HDCP2.2 services > > > drm/i915: Implement HDCP2.2 receiver authentication > > > drm/i915: Implement HDCP2.2 repeater authentication > > > drm/i915: Enable and Disable HDCP2.2 port encryption > > > drm/i915: Implement HDCP2.2 En/Dis-able > > > drm/i915: Implement HDCP2.2 link integrity check > > > drm/i915: Handle HDCP2.2 downstream topology change > > > drm/i915: Pullout the bksv read and validation > > > drm/i915: Initialize HDCP2.2 and its MEI interface > > > drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable > > > drm/i915: Enable superior HDCP ver that is capable > > > drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure > > > drm/i915: hdcp_check_link only on CP_IRQ > > > drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ > > > drm/i915/gmbus: Increase the Bytes per Rd/Wr Op > > > drm/i915/gmbus: Enable burst read > > > drm/i915: Implem
Re: [Intel-gfx] [PATCH v4 00/41] drm/i915: Implement HDCP2.2
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Tuesday, May 29, 2018 12:27 PM > To: C, Ramalingam > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > seanp...@chromium.org; dan...@ffwll.ch; ch...@chris-wilson.co.uk; > jani.nik...@linux.intel.com; Winkler, Tomas ; > Usyskin, Alexander ; Shankar, Uma > ; Sharma, Shashank > Subject: Re: [PATCH v4 00/41] drm/i915: Implement HDCP2.2 > > On Mon, May 21, 2018 at 06:23:19PM +0530, Ramalingam C wrote: > > The sequence for HDCP2.2 authentication and encryption is implemented > > in I915. Encoder specific implementations are moved into hdcp_shim. > > > > Intel HWs supports HDCP2.2 through ME FW. Hence this series introduces > > a client driver for mei bus, so that for HDCP2.2 authentication, > > HDCP2.2 stack in I915 can avail the services from ME FW. > > > > DRM_I915 selects INTEL_MEI_HDCP, which selects INTEL_MEI_ME and > > INTEL_MEI. If we are interested in disabling the MEI_HDCP and MEI Bus > > then we need an option to disable the HDCP2.2 in I915 (like > > DRM_I915_HDCP2.2!?). Till then they are binded. > > > > Userspace interface remains unchanged as version agnostic. When > > userspace request for HDCP enable, Kernel will detect the HDCP source > > and sink's HDCP version(1.4/2.2)capability and enable the best capable > > version for that combination. > > > > This series enables the HDCP2.2 for Type0 content streams. > > > > Thanks a lot for Usyskin, Alexander and Uma shankar for the review of v3. > > Thanks Daniel vetter for guiding me to test and confirm that there is > > no locking issue with respect to notifier usage between I915 and MEI_HDCP. > > > > Major Changes in v4: > > - GMBus Changes to implement the burst read as generic > > [Jani, Ville and Daniel] > > - Polling is added for extra Notifier notification when I915 and > > MEI_HDCP are modules. > > - Comment and style issues and typos are fixed [Uma and Alexander] > > - INTEL_MEI_HDCP, INTEL_MEI_ME and INTEL_MEI are selected by I915. > > - Fixed the #if in include/linux/mei_hdcp.h for build issues. > > > > GMBus changes are added here for completeness of the series. They are > > in review at https://patchwork.freedesktop.org/series/41632/ also. > > Please reply with a link to your github here (and include it in your next > cover > letter too). I can't ever find it when I need it :-/ You can find a github repo for HDCP2.2 v4 series at https://github.com/ramalingampc2008/drm-tip Thanks, Ram > > Thanks, Daniel > > > > > Ramalingam C (40): > > drm: hdcp2.2 authentication msg definitions > > drm: HDMI and DP specific HDCP2.2 defines > > misc/mei/hdcp: Client driver for HDCP application > > misc/mei/hdcp: Notifier chain for mei cldev state change > > misc/mei/hdcp: Define ME FW interface for HDCP2.2 > > linux/mei: Header for mei_hdcp driver interface > > misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session > > misc/mei/hdcp: Verify Receiver Cert and prepare km > > misc/mei/hdcp: Verify H_prime > > misc/mei/hdcp: Store the HDCP Pairing info > > misc/mei/hdcp: Initiate Locality check > > misc/mei/hdcp: Verify L_prime > > misc/mei/hdcp: Prepare Session Key > > misc/mei/hdcp: Repeater topology verification and ack > > misc/mei/hdcp: Verify M_prime > > misc/mei/hdcp: Enabling the HDCP authentication > > misc/mei/hdcp: Closing wired HDCP2.2 Tx Session > > drm/i915: wrapping all hdcp var into intel_hdcp > > drm/i915: Define HDCP2.2 related variables > > drm/i915: Define Intel HDCP2.2 registers > > drm/i915: Wrappers for mei HDCP2.2 services > > drm/i915: Implement HDCP2.2 receiver authentication > > drm/i915: Implement HDCP2.2 repeater authentication > > drm/i915: Enable and Disable HDCP2.2 port encryption > > drm/i915: Implement HDCP2.2 En/Dis-able > > drm/i915: Implement HDCP2.2 link integrity check > > drm/i915: Handle HDCP2.2 downstream topology change > > drm/i915: Pullout the bksv read and validation > > drm/i915: Initialize HDCP2.2 and its MEI interface > > drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable > > drm/i915: Enable superior HDCP ver that is capable > > drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure > > drm/i915: hdcp_check_link only on CP_IRQ > > drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ > > drm/i915/gmbus: Increase the Bytes per Rd/Wr Op > > drm/i915/gmbus: Enable burst read > > drm/i915: Implement the HDCP2.2 support for DP > > drm/i915: Implement the HDCP2.2 support for HDMI > > drm/i915: Add HDCP2.2 support for DP connectors > > drm/i915: Add HDCP2.2 support for HDMI connectors > > > > Tomas Winkler (1): > > mei: bus: whitelist hdcp client > > > > drivers/gpu/drm/i915/Kconfig |1 + > > drivers/gpu/drm/i915/i915_drv.h |3 + > > drivers/gpu/drm/i915/i915_reg.h | 34 ++ > > drivers/gpu/drm/i915/intel_display.c |7 +- > > drivers/gpu/drm/i915/int
Re: [Intel-gfx] [PATCH v4 00/41] drm/i915: Implement HDCP2.2
On Mon, May 21, 2018 at 06:23:19PM +0530, Ramalingam C wrote: > The sequence for HDCP2.2 authentication and encryption is implemented > in I915. Encoder specific implementations are moved into hdcp_shim. > > Intel HWs supports HDCP2.2 through ME FW. Hence this series > introduces a client driver for mei bus, so that for HDCP2.2 > authentication, HDCP2.2 stack in I915 can avail the services from > ME FW. > > DRM_I915 selects INTEL_MEI_HDCP, which selects INTEL_MEI_ME and > INTEL_MEI. If we are interested in disabling the MEI_HDCP and MEI Bus > then we need an option to disable the HDCP2.2 in I915 > (like DRM_I915_HDCP2.2!?). Till then they are binded. > > Userspace interface remains unchanged as version agnostic. When > userspace request for HDCP enable, Kernel will detect the HDCP source > and sink's HDCP version(1.4/2.2)capability and enable the best capable > version for that combination. > > This series enables the HDCP2.2 for Type0 content streams. > > Thanks a lot for Usyskin, Alexander and Uma shankar for the review of v3. > Thanks Daniel vetter for guiding me to test and confirm that there is no > locking issue with respect to notifier usage between I915 and MEI_HDCP. > > Major Changes in v4: > - GMBus Changes to implement the burst read as generic > [Jani, Ville and Daniel] > - Polling is added for extra Notifier notification when I915 and > MEI_HDCP are modules. > - Comment and style issues and typos are fixed [Uma and Alexander] > - INTEL_MEI_HDCP, INTEL_MEI_ME and INTEL_MEI are selected by I915. > - Fixed the #if in include/linux/mei_hdcp.h for build issues. > > GMBus changes are added here for completeness of the series. They are > in review at https://patchwork.freedesktop.org/series/41632/ also. Please reply with a link to your github here (and include it in your next cover letter too). I can't ever find it when I need it :-/ Thanks, Daniel > > Ramalingam C (40): > drm: hdcp2.2 authentication msg definitions > drm: HDMI and DP specific HDCP2.2 defines > misc/mei/hdcp: Client driver for HDCP application > misc/mei/hdcp: Notifier chain for mei cldev state change > misc/mei/hdcp: Define ME FW interface for HDCP2.2 > linux/mei: Header for mei_hdcp driver interface > misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session > misc/mei/hdcp: Verify Receiver Cert and prepare km > misc/mei/hdcp: Verify H_prime > misc/mei/hdcp: Store the HDCP Pairing info > misc/mei/hdcp: Initiate Locality check > misc/mei/hdcp: Verify L_prime > misc/mei/hdcp: Prepare Session Key > misc/mei/hdcp: Repeater topology verification and ack > misc/mei/hdcp: Verify M_prime > misc/mei/hdcp: Enabling the HDCP authentication > misc/mei/hdcp: Closing wired HDCP2.2 Tx Session > drm/i915: wrapping all hdcp var into intel_hdcp > drm/i915: Define HDCP2.2 related variables > drm/i915: Define Intel HDCP2.2 registers > drm/i915: Wrappers for mei HDCP2.2 services > drm/i915: Implement HDCP2.2 receiver authentication > drm/i915: Implement HDCP2.2 repeater authentication > drm/i915: Enable and Disable HDCP2.2 port encryption > drm/i915: Implement HDCP2.2 En/Dis-able > drm/i915: Implement HDCP2.2 link integrity check > drm/i915: Handle HDCP2.2 downstream topology change > drm/i915: Pullout the bksv read and validation > drm/i915: Initialize HDCP2.2 and its MEI interface > drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable > drm/i915: Enable superior HDCP ver that is capable > drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure > drm/i915: hdcp_check_link only on CP_IRQ > drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ > drm/i915/gmbus: Increase the Bytes per Rd/Wr Op > drm/i915/gmbus: Enable burst read > drm/i915: Implement the HDCP2.2 support for DP > drm/i915: Implement the HDCP2.2 support for HDMI > drm/i915: Add HDCP2.2 support for DP connectors > drm/i915: Add HDCP2.2 support for HDMI connectors > > Tomas Winkler (1): > mei: bus: whitelist hdcp client > > drivers/gpu/drm/i915/Kconfig |1 + > drivers/gpu/drm/i915/i915_drv.h |3 + > drivers/gpu/drm/i915/i915_reg.h | 34 ++ > drivers/gpu/drm/i915/intel_display.c |7 +- > drivers/gpu/drm/i915/intel_dp.c | 370 +++- > drivers/gpu/drm/i915/intel_drv.h | 88 ++- > drivers/gpu/drm/i915/intel_hdcp.c| 1096 > -- > drivers/gpu/drm/i915/intel_hdmi.c| 189 +- > drivers/gpu/drm/i915/intel_i2c.c | 71 ++- > drivers/misc/mei/Kconfig |7 + > drivers/misc/mei/Makefile|2 + > drivers/misc/mei/bus-fixup.c | 16 + > drivers/misc/mei/hdcp/Makefile |6 + > drivers/misc/mei/hdcp/mei_hdcp.c | 817 + > drivers/misc/mei/hdcp/mei_hdcp.h | 415 + > include/drm/drm_dp_helper.h | 51 ++ > include/drm/drm_hdcp.h | 232 +++ > include/linux/mei_hdcp.h | 232 +++
