Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3 (rev5)

2023-10-19 Thread Andi Shyti
Hi Nirmoy,

> > > > Possible regressions
> > > > 
> > > >    • igt@gem_exec_nop@basic-series:
> > > > 
> > > >    □ shard-glk: PASS -> INCOMPLETE +1 other test incomplete
> > > >    •
> > > > igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
> > > > 
> > > >    □ shard-dg2: PASS -> TIMEOUT
> > > >    • igt@kms_cursor_crc@cursor-onscreen-64x21@pipe-d-hdmi-a-1:
> > > > 
> > > >    □ shard-tglu: PASS -> INCOMPLETE
> > > >    • igt@kms_psr@psr2_suspend:
> > > > 
> > > >    □ shard-mtlp: NOTRUN -> FAIL
> > > 
> > > these failures look unrelated and besides they are not related to
> > > MTL.
> > 
> > There is something new on the shards which _seems_ to be implicating
> > this patch.
> > 
> > This previously all green test started failing in a bad way:
> > 
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13775/shard-mtlp-6/igt@sysfs_preempt_timeout@time...@vecs0.html
> > 
> > 
> > <5> [97.816201] Fence expiration time out
> > i915-:00:02.0:sysfs_preempt_t[1166]:2!
> > <3> [187.682308] INFO: task kworker/0:3:165 blocked for more than 61
> > seconds.
> > <3> [187.689294]   Tainted: G    W
> > 6.6.0-rc6-CI_DRM_13775-ge69e078f7bef+ #1
> > <3> [187.697375] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs"
> > disables this message.
> > <6> [187.705354] task:kworker/0:3 state:D stack:13504 pid:165  
> > ppid:2  flags:0x4000
> > <6> [187.705375] Workqueue: i915-unordered intel_gt_watchdog_work [i915]
> > <6> [187.705671] Call Trace:
> > <6> [187.705675]  
> > <6> [187.705683]  __schedule+0x3a0/0xd70
> > <6> [187.705704]  schedule+0x5c/0xd0
> > <6> [187.705713]  guc_context_cancel_request+0x45e/0x9f0 [i915]
> > <6> [187.706078]  ? __pfx_autoremove_wake_function+0x10/0x10
> > <6> [187.706091]  ? intel_gt_watchdog_work+0x20/0x260 [i915]
> > <6> [187.706377]  intel_gt_watchdog_work+0xd1/0x260 [i915]
> > <6> [187.706624]  ? process_scheduled_works+0x264/0x530
> > <6> [187.706635]  process_scheduled_works+0x2db/0x530
> > <6> [187.706650]  ? __pfx_worker_thread+0x10/0x10
> > <6> [187.706656]  worker_thread+0x18c/0x350
> > <6> [187.706664]  ? __pfx_worker_thread+0x10/0x10
> > <6> [187.706670]  kthread+0xfe/0x130
> > <6> [187.706678]  ? __pfx_kthread+0x10/0x10
> > <6> [187.706687]  ret_from_fork+0x2c/0x50
> > <6> [187.706696]  ? __pfx_kthread+0x10/0x10
> > <6> [187.706704]  ret_from_fork_asm+0x1b/0x30
> > <6> [187.706724]  
> > 
> > I am not claiming it is at fault but the transition from green to timing
> > out looks clear.
> 
> https://jira.devtools.intel.com/browse/VLK-52300 This happening for a while
> as per the filter.
> 
> (machines are broken so cibuglog will not work till Tuesday)

Thanks, that's what I thought, but I haven't had the chance to
verify it.

Andi


Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3 (rev5)

2023-10-19 Thread Nirmoy Das



On 10/19/2023 10:14 AM, Tvrtko Ursulin wrote:


On 18/10/2023 17:43, Andi Shyti wrote:

Hi Vinay,


Possible regressions

   • igt@gem_exec_nop@basic-series:

   □ shard-glk: PASS -> INCOMPLETE +1 other test incomplete
   • 
igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:


   □ shard-dg2: PASS -> TIMEOUT
   • igt@kms_cursor_crc@cursor-onscreen-64x21@pipe-d-hdmi-a-1:

   □ shard-tglu: PASS -> INCOMPLETE
   • igt@kms_psr@psr2_suspend:

   □ shard-mtlp: NOTRUN -> FAIL


these failures look unrelated and besides they are not related to
MTL.


There is something new on the shards which _seems_ to be implicating 
this patch.


This previously all green test started failing in a bad way:

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13775/shard-mtlp-6/igt@sysfs_preempt_timeout@time...@vecs0.html 



<5> [97.816201] Fence expiration time out 
i915-:00:02.0:sysfs_preempt_t[1166]:2!
<3> [187.682308] INFO: task kworker/0:3:165 blocked for more than 61 
seconds.
<3> [187.689294]   Tainted: G    W 
6.6.0-rc6-CI_DRM_13775-ge69e078f7bef+ #1
<3> [187.697375] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" 
disables this message.
<6> [187.705354] task:kworker/0:3 state:D stack:13504 pid:165   
ppid:2  flags:0x4000

<6> [187.705375] Workqueue: i915-unordered intel_gt_watchdog_work [i915]
<6> [187.705671] Call Trace:
<6> [187.705675]  
<6> [187.705683]  __schedule+0x3a0/0xd70
<6> [187.705704]  schedule+0x5c/0xd0
<6> [187.705713]  guc_context_cancel_request+0x45e/0x9f0 [i915]
<6> [187.706078]  ? __pfx_autoremove_wake_function+0x10/0x10
<6> [187.706091]  ? intel_gt_watchdog_work+0x20/0x260 [i915]
<6> [187.706377]  intel_gt_watchdog_work+0xd1/0x260 [i915]
<6> [187.706624]  ? process_scheduled_works+0x264/0x530
<6> [187.706635]  process_scheduled_works+0x2db/0x530
<6> [187.706650]  ? __pfx_worker_thread+0x10/0x10
<6> [187.706656]  worker_thread+0x18c/0x350
<6> [187.706664]  ? __pfx_worker_thread+0x10/0x10
<6> [187.706670]  kthread+0xfe/0x130
<6> [187.706678]  ? __pfx_kthread+0x10/0x10
<6> [187.706687]  ret_from_fork+0x2c/0x50
<6> [187.706696]  ? __pfx_kthread+0x10/0x10
<6> [187.706704]  ret_from_fork_asm+0x1b/0x30
<6> [187.706724]  

I am not claiming it is at fault but the transition from green to 
timing out looks clear.


https://jira.devtools.intel.com/browse/VLK-52300 This happening for a 
while as per the filter.


(machines are broken so cibuglog will not work till Tuesday)



Regards,

Tvrtko


Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3 (rev5)

2023-10-19 Thread Andi Shyti
On Thu, Oct 19, 2023 at 09:14:13AM +0100, Tvrtko Ursulin wrote:
> 
> On 18/10/2023 17:43, Andi Shyti wrote:
> > Hi Vinay,
> > 
> > > Possible regressions
> > > 
> > >• igt@gem_exec_nop@basic-series:
> > > 
> > >□ shard-glk: PASS -> INCOMPLETE +1 other test incomplete
> > >• igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
> > > 
> > >□ shard-dg2: PASS -> TIMEOUT
> > >• igt@kms_cursor_crc@cursor-onscreen-64x21@pipe-d-hdmi-a-1:
> > > 
> > >□ shard-tglu: PASS -> INCOMPLETE
> > >• igt@kms_psr@psr2_suspend:
> > > 
> > >□ shard-mtlp: NOTRUN -> FAIL
> > 
> > these failures look unrelated and besides they are not related to
> > MTL.
> 
> There is something new on the shards which _seems_ to be implicating this 
> patch.
> 
> This previously all green test started failing in a bad way:
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13775/shard-mtlp-6/igt@sysfs_preempt_timeout@time...@vecs0.html
> 
> <5> [97.816201] Fence expiration time out 
> i915-:00:02.0:sysfs_preempt_t[1166]:2!
> <3> [187.682308] INFO: task kworker/0:3:165 blocked for more than 61 seconds.
> <3> [187.689294]   Tainted: GW  
> 6.6.0-rc6-CI_DRM_13775-ge69e078f7bef+ #1
> <3> [187.697375] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables 
> this message.
> <6> [187.705354] task:kworker/0:3 state:D stack:13504 pid:165   ppid:2
>   flags:0x4000
> <6> [187.705375] Workqueue: i915-unordered intel_gt_watchdog_work [i915]
> <6> [187.705671] Call Trace:
> <6> [187.705675]  
> <6> [187.705683]  __schedule+0x3a0/0xd70
> <6> [187.705704]  schedule+0x5c/0xd0
> <6> [187.705713]  guc_context_cancel_request+0x45e/0x9f0 [i915]
> <6> [187.706078]  ? __pfx_autoremove_wake_function+0x10/0x10
> <6> [187.706091]  ? intel_gt_watchdog_work+0x20/0x260 [i915]
> <6> [187.706377]  intel_gt_watchdog_work+0xd1/0x260 [i915]
> <6> [187.706624]  ? process_scheduled_works+0x264/0x530
> <6> [187.706635]  process_scheduled_works+0x2db/0x530
> <6> [187.706650]  ? __pfx_worker_thread+0x10/0x10
> <6> [187.706656]  worker_thread+0x18c/0x350
> <6> [187.706664]  ? __pfx_worker_thread+0x10/0x10
> <6> [187.706670]  kthread+0xfe/0x130
> <6> [187.706678]  ? __pfx_kthread+0x10/0x10
> <6> [187.706687]  ret_from_fork+0x2c/0x50
> <6> [187.706696]  ? __pfx_kthread+0x10/0x10
> <6> [187.706704]  ret_from_fork_asm+0x1b/0x30
> <6> [187.706724]  
> 
> I am not claiming it is at fault but the transition from green to timing out 
> looks clear.

This looks an unrelated failure to me... Before merging this
patch I did consult with Vinay.

Vinay, could you please double check here?

Andi


Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3 (rev5)

2023-10-19 Thread Tvrtko Ursulin



On 18/10/2023 17:43, Andi Shyti wrote:

Hi Vinay,


Possible regressions

   • igt@gem_exec_nop@basic-series:

   □ shard-glk: PASS -> INCOMPLETE +1 other test incomplete
   • igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:

   □ shard-dg2: PASS -> TIMEOUT
   • igt@kms_cursor_crc@cursor-onscreen-64x21@pipe-d-hdmi-a-1:

   □ shard-tglu: PASS -> INCOMPLETE
   • igt@kms_psr@psr2_suspend:

   □ shard-mtlp: NOTRUN -> FAIL


these failures look unrelated and besides they are not related to
MTL.


There is something new on the shards which _seems_ to be implicating this patch.

This previously all green test started failing in a bad way:

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13775/shard-mtlp-6/igt@sysfs_preempt_timeout@time...@vecs0.html

<5> [97.816201] Fence expiration time out 
i915-:00:02.0:sysfs_preempt_t[1166]:2!
<3> [187.682308] INFO: task kworker/0:3:165 blocked for more than 61 seconds.
<3> [187.689294]   Tainted: GW  
6.6.0-rc6-CI_DRM_13775-ge69e078f7bef+ #1
<3> [187.697375] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables 
this message.
<6> [187.705354] task:kworker/0:3 state:D stack:13504 pid:165   ppid:2  
flags:0x4000
<6> [187.705375] Workqueue: i915-unordered intel_gt_watchdog_work [i915]
<6> [187.705671] Call Trace:
<6> [187.705675]  
<6> [187.705683]  __schedule+0x3a0/0xd70
<6> [187.705704]  schedule+0x5c/0xd0
<6> [187.705713]  guc_context_cancel_request+0x45e/0x9f0 [i915]
<6> [187.706078]  ? __pfx_autoremove_wake_function+0x10/0x10
<6> [187.706091]  ? intel_gt_watchdog_work+0x20/0x260 [i915]
<6> [187.706377]  intel_gt_watchdog_work+0xd1/0x260 [i915]
<6> [187.706624]  ? process_scheduled_works+0x264/0x530
<6> [187.706635]  process_scheduled_works+0x2db/0x530
<6> [187.706650]  ? __pfx_worker_thread+0x10/0x10
<6> [187.706656]  worker_thread+0x18c/0x350
<6> [187.706664]  ? __pfx_worker_thread+0x10/0x10
<6> [187.706670]  kthread+0xfe/0x130
<6> [187.706678]  ? __pfx_kthread+0x10/0x10
<6> [187.706687]  ret_from_fork+0x2c/0x50
<6> [187.706696]  ? __pfx_kthread+0x10/0x10
<6> [187.706704]  ret_from_fork_asm+0x1b/0x30
<6> [187.706724]  

I am not claiming it is at fault but the transition from green to timing out 
looks clear.

Regards,

Tvrtko


Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3 (rev5)

2023-10-18 Thread Andi Shyti
Hi Vinay,

> Possible regressions
> 
>   • igt@gem_exec_nop@basic-series:
> 
>   □ shard-glk: PASS -> INCOMPLETE +1 other test incomplete
>   • igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
> 
>   □ shard-dg2: PASS -> TIMEOUT
>   • igt@kms_cursor_crc@cursor-onscreen-64x21@pipe-d-hdmi-a-1:
> 
>   □ shard-tglu: PASS -> INCOMPLETE
>   • igt@kms_psr@psr2_suspend:
> 
>   □ shard-mtlp: NOTRUN -> FAIL

these failures look unrelated and besides they are not related to
MTL.

Andi