Re: [Interest] Qt 6.4.3 compiler warnings in QTaggedPointer

2023-03-23 Thread Thiago Macieira
On Thursday, 23 March 2023 00:03:24 HST Hamish Moffatt via Interest wrote:
> OK. There's a similar issue in QtConcurrent (unchanged since 5.15
> actually) also driving me mad - __int64 resulting from std::distance is
> assigned to int.

In Qt 6, that should just be qsizetype or plain auto.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Cloud Software Architect - Intel DCAI Cloud Engineering


smime.p7s
Description: S/MIME cryptographic signature
___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Qt 6.4.3 compiler warnings in QTaggedPointer

2023-03-23 Thread Hamish Moffatt via Interest

On 23/3/23 18:15, Thiago Macieira wrote:

On Wednesday, 22 March 2023 18:19:59 HST Hamish Moffatt via Interest wrote:

static constexpr quint8 tagBits =
QtPrivate::qConstexprCountTrailingZeroBits(alignment);

So would you fix it with a cast, or by changing the variable type to int
to match the function?

Either solution is fine. I was thinking of simply adding a quint8() cast around
the result, but changing to uint also works too. The latter is a smaller
change anyway.

OK. There's a similar issue in QtConcurrent (unchanged since 5.15 
actually) also driving me mad - __int64 resulting from std::distance is 
assigned to int.



Hamish

___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest


Re: [Interest] Qt 6.4.3 compiler warnings in QTaggedPointer

2023-03-23 Thread Thiago Macieira
On Wednesday, 22 March 2023 18:19:59 HST Hamish Moffatt via Interest wrote:
> static constexpr quint8 tagBits =
> QtPrivate::qConstexprCountTrailingZeroBits(alignment);
> 
> So would you fix it with a cast, or by changing the variable type to int
> to match the function?

Either solution is fine. I was thinking of simply adding a quint8() cast around 
the result, but changing to uint also works too. The latter is a smaller 
change anyway.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Cloud Software Architect - Intel DCAI Cloud Engineering


smime.p7s
Description: S/MIME cryptographic signature
___
Interest mailing list
Interest@qt-project.org
https://lists.qt-project.org/listinfo/interest