Re: [PHP-DEV] Re: 5.0.1RC2
Okay :) By the way, Andi, do you know anything about the OpenSSL segfault I wrote about in this list on August 9th? If it's unknown, I'll test it thoroughly (isolate the problem) and write a bugreport... Ron "Andi Gutmans" <[EMAIL PROTECTED]> schreef in bericht news:[EMAIL PROTECTED] > NEWS in the package. Anyway, as this is a minor version for bug fixes, this > is an internal RC release unlike the 5.0.0 RCs. > > At 08:51 AM 8/12/2004 +0200, Ron Korving wrote: > >Are there no changelogs of RC's ? > > > >Ron > > > >"Andi Gutmans" <[EMAIL PROTECTED]> schreef in bericht > >news:[EMAIL PROTECTED] > > > Hey, > > > > > > 5.0.1RC2 is at http://snaps.php.net/~andi > > > Planning on release tomorrow (before I go away on a long weekend). > > > > > > Andi > > > >-- > >PHP Internals - PHP Runtime Development Mailing List > >To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] PHP_EOL exposed to scripts?
On Wed, 11 Aug 2004, Andi Gutmans wrote: > I think it's a good idea. Personally I think that making this EOL would > make it even easier to use. We can't do that because I bet it's a constant that many people have done in their own scripts. So IMO PHP_EOL is the way to go. I already patch 5.0.x and 5.1.x for this, just need to commit it (when I hear more opinions of course). Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_compile.c zend_execute.c (fwd)
Hey,
is it possibleto port this back to PHP 4.3?
Derick
-- Forwarded message --
Date: Thu, 12 Aug 2004 05:41:02 -
From: Andi Gutmans <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_compile.c zend_execute.c
andiThu Aug 12 01:41:02 2004 EDT
Modified files:
/ZendEngine2zend_compile.c zend_execute.c
Log:
- Significantly improve performance of foreach($arr as $data). (Marcus)
http://cvs.php.net/diff.php/ZendEngine2/zend_compile.c?r1=1.574&r2=1.575&ty=u
Index: ZendEngine2/zend_compile.c
diff -u ZendEngine2/zend_compile.c:1.574 ZendEngine2/zend_compile.c:1.575
--- ZendEngine2/zend_compile.c:1.574Mon Aug 2 18:41:34 2004
+++ ZendEngine2/zend_compile.c Thu Aug 12 01:41:01 2004
@@ -17,7 +17,7 @@
+--+
*/
-/* $Id: zend_compile.c,v 1.574 2004/08/02 22:41:34 helly Exp $ */
+/* $Id: zend_compile.c,v 1.575 2004/08/12 05:41:01 andi Exp $ */
#include "zend_language_parser.h"
#include "zend.h"
@@ -3340,7 +3340,7 @@
void zend_do_foreach_cont(znode *value, znode *key, znode *as_token, znode
*foreach_token TSRMLS_DC)
{
- zend_op *opline = get_next_op(CG(active_op_array) TSRMLS_CC);
+ zend_op *opline;
znode result_value, result_key, dummy;
zend_bool assign_by_ref=0;
@@ -3351,6 +3351,9 @@
tmp = key;
key = value;
value = tmp;
+
+ /* Mark extended_value in case both key and value are being used */
+
CG(active_op_array)->opcodes[foreach_token->u.opline_num].extended_value |= 2;
}
if ((key->op_type != IS_UNUSED) && (key->u.EA.type &
ZEND_PARSED_REFERENCE_VARIABLE)) {
@@ -3362,20 +3365,10 @@
if
(!CG(active_op_array)->opcodes[foreach_token->u.opline_num-1].extended_value) {
zend_error(E_COMPILE_ERROR, "Cannot create references to
elements of a temporary array expression");
}
-
CG(active_op_array)->opcodes[foreach_token->u.opline_num].extended_value = 1;
+ /* Mark extended_value for assign-by-reference */
+
CG(active_op_array)->opcodes[foreach_token->u.opline_num].extended_value |= 1;
}
- opline->opcode = ZEND_FETCH_DIM_TMP_VAR;
- opline->result.op_type = IS_VAR;
- opline->result.u.EA.type = 0;
- opline->result.u.opline_num = get_temporary_variable(CG(active_op_array));
- opline->op1 = *as_token;
- opline->op2.op_type = IS_CONST;
- opline->op2.u.constant.type = IS_LONG;
- opline->op2.u.constant.value.lval = 0;
- opline->extended_value = ZEND_FETCH_STANDARD; /* ignored in fetch_dim_tmp_var,
but what the hell. */
- result_value = opline->result;
-
if (key->op_type != IS_UNUSED) {
opline = get_next_op(CG(active_op_array) TSRMLS_CC);
opline->opcode = ZEND_FETCH_DIM_TMP_VAR;
@@ -3385,13 +3378,33 @@
opline->op1 = *as_token;
opline->op2.op_type = IS_CONST;
opline->op2.u.constant.type = IS_LONG;
+ opline->op2.u.constant.value.lval = 0;
+ opline->extended_value = ZEND_FETCH_STANDARD; /* ignored in
fetch_dim_tmp_var, but what the hell. */
+ result_value = opline->result;
+
+ opline = get_next_op(CG(active_op_array) TSRMLS_CC);
+ opline->opcode = ZEND_FETCH_DIM_TMP_VAR;
+ opline->result.op_type = IS_VAR;
+ opline->result.u.EA.type = 0;
+ opline->result.u.opline_num =
get_temporary_variable(CG(active_op_array));
+ opline->op1 = *as_token;
+ opline->op2.op_type = IS_CONST;
+ opline->op2.u.constant.type = IS_LONG;
opline->op2.u.constant.value.lval = 1;
opline->extended_value = ZEND_FETCH_STANDARD; /* ignored in
fetch_dim_tmp_var, but what the hell. */
result_key = opline->result;
+ } else {
+ result_value =
CG(active_op_array)->opcodes[foreach_token->u.opline_num].result;
}
if (assign_by_ref) {
- zend_do_assign_ref(&dummy, value, &result_value TSRMLS_CC);
+ if (key->op_type == IS_UNUSED) {
+ /* Mark FE_FETCH as IS_VAR as it holds the data directly as a
value */
+
CG(active_op_array)->opcodes[foreach_token->u.opline_num].result.op_type = IS_VAR;
+ zend_do_assign_ref(NULL, value,
&CG(active_op_array)->opcodes[foreach_token->u.opline_num].result TSRMLS_CC);
+ } else {
+ zend_do_assign_ref(NULL, value, &result_value TSRMLS_CC);
+ }
} else {
zend_do_assign(&dummy, value, &result_value TSRMLS_CC);
}
@@ -3399,8 +3412,8 @@
if (key->op_type != IS_UNUSED) {
Re: [PHP-DEV] Re: 5.0.1RC2
Nope no idea. Does it also happen with 5.0.0? At 09:00 AM 8/12/2004 +0200, Ron Korving wrote: Okay :) By the way, Andi, do you know anything about the OpenSSL segfault I wrote about in this list on August 9th? If it's unknown, I'll test it thoroughly (isolate the problem) and write a bugreport... Ron "Andi Gutmans" <[EMAIL PROTECTED]> schreef in bericht news:[EMAIL PROTECTED] > NEWS in the package. Anyway, as this is a minor version for bug fixes, this > is an internal RC release unlike the 5.0.0 RCs. > > At 08:51 AM 8/12/2004 +0200, Ron Korving wrote: > >Are there no changelogs of RC's ? > > > >Ron > > > >"Andi Gutmans" <[EMAIL PROTECTED]> schreef in bericht > >news:[EMAIL PROTECTED] > > > Hey, > > > > > > 5.0.1RC2 is at http://snaps.php.net/~andi > > > Planning on release tomorrow (before I go away on a long weekend). > > > > > > Andi > > > >-- > >PHP Internals - PHP Runtime Development Mailing List > >To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: 5.0.1RC2
It happened on PHP5 (maybe it was the last RC, and not the final) and didn't try it on PHP4. I can't seem to reproduce it anymore, but in the near future I will give it my best shot. Ron "Andi Gutmans" <[EMAIL PROTECTED]> schreef in bericht news:[EMAIL PROTECTED] > Nope no idea. Does it also happen with 5.0.0? > At 09:00 AM 8/12/2004 +0200, Ron Korving wrote: > >Okay :) By the way, Andi, do you know anything about the OpenSSL segfault I > >wrote about in this list on August 9th? If it's unknown, I'll test it > >thoroughly (isolate the problem) and write a bugreport... > > > >Ron > > > >"Andi Gutmans" <[EMAIL PROTECTED]> schreef in bericht > >news:[EMAIL PROTECTED] > > > NEWS in the package. Anyway, as this is a minor version for bug fixes, > >this > > > is an internal RC release unlike the 5.0.0 RCs. > > > > > > At 08:51 AM 8/12/2004 +0200, Ron Korving wrote: > > > >Are there no changelogs of RC's ? > > > > > > > >Ron > > > > > > > >"Andi Gutmans" <[EMAIL PROTECTED]> schreef in bericht > > > >news:[EMAIL PROTECTED] > > > > > Hey, > > > > > > > > > > 5.0.1RC2 is at http://snaps.php.net/~andi > > > > > Planning on release tomorrow (before I go away on a long weekend). > > > > > > > > > > Andi > > > > > > > >-- > > > >PHP Internals - PHP Runtime Development Mailing List > > > >To unsubscribe, visit: http://www.php.net/unsub.php > > > >-- > >PHP Internals - PHP Runtime Development Mailing List > >To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: 5.0.1RC2
Ron Korving wrote: Okay :) By the way, Andi, do you know anything about the OpenSSL segfault I wrote about in this list on August 9th? If it's unknown, I'll test it thoroughly (isolate the problem) and write a bugreport... I had similiar problems (I think) when I was using mod_ssl with PHP and was loading certain modules at startup; unfortunately this is all I remember. Are you using mod_ssl, too? regards, - Markus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: 5.0.1RC2
You mean mod_ssl for apache? The problem occured in php5-cli :) Ron "Markus Fischer" <[EMAIL PROTECTED]> schreef in bericht news:[EMAIL PROTECTED] > Ron Korving wrote: > > > Okay :) By the way, Andi, do you know anything about the OpenSSL segfault I > > wrote about in this list on August 9th? If it's unknown, I'll test it > > thoroughly (isolate the problem) and write a bugreport... > > I had similiar problems (I think) when I was using mod_ssl with PHP and > was loading certain modules at startup; unfortunately this is all I > remember. Are you using mod_ssl, too? > > regards, > - Markus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: PHP 4.3.9RC1 Released
Do you know when fixes in PHP4.3.9 will find its way to PHP5? Ron "Ilia Alshanetsky" <[EMAIL PROTECTED]> schreef in bericht news:[EMAIL PROTECTED] > Here goes the long overdue RC1 of 4.3.9 that will hopefully soon be followed > by the final release. While this release only fixes bugs, I'd still like to > ask everyone to test it to make sure no new bugs were introduced. > > The sources & Windows binaries can be found at their usual location, > http://qa.php.net/. > > > Ilia Alshanetsky -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] is_a() vs. instanceof
I agree, that's the exact behavior I would like as well and what most
people would expect.
Al
On Wed, 2004-08-11 at 23:52 -0400, Hans Lellelid wrote:
> Alan Knowles wrote:
>
> > I think he's referening to something like this (which is common in pear):
> >
> > $x = $someobj->somemethod();
> > if ($x instanceOf PEAR_Error) {
> > ...
> > }
> >
> > while that code is redundant in the case of exceptions, it is still a
> > valid situation.. that $x may be a valid return, and PEAR_Error was
> > never loaded..
>
>
> Yup, that's exactly what I'm talking about.
>
> I want to be able to do this:
>
> if ($db instanceof DBPostgres) {
>/// do something funky specific to Postgres
> }
>
> If My DB adapter is DBMySQL, I don't want to load the DBPostgres adapter
> just so I can test whether my object is of that type ...
>
> and checking first whether class_exists('DBPostgres') just seems kinda
> kludgy & straying from the "problem domain" ... especially since $db
> instanceof DBPostgres would *always* be false if DBPostgres isn't loaded.
>
> Hans
>
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-DEV] Re: 5.0.1RC2
There's a (closed, not enough info) bug report on this: http://bugs.php.net/bug.php?id=29227 (just to confirm that there's an issue there at all) > -Original Message- > From: Markus Fischer [mailto:[EMAIL PROTECTED] > Sent: 12 August 2004 09:13 > To: [EMAIL PROTECTED] > Subject: Re: [PHP-DEV] Re: 5.0.1RC2 > > > Ron Korving wrote: > > > Okay :) By the way, Andi, do you know anything about the > OpenSSL segfault I > > wrote about in this list on August 9th? If it's unknown, I'll test it > > thoroughly (isolate the problem) and write a bugreport... > > I had similiar problems (I think) when I was using mod_ssl with PHP and > was loading certain modules at startup; unfortunately this is all I > remember. Are you using mod_ssl, too? > > regards, > - Markus > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: 5.0.1RC2
yes, this is apache related.. the segfault i experienced wasn't, because it occured in cli mode, so it must be something different. Ron "Steph" <[EMAIL PROTECTED]> schreef in bericht news:[EMAIL PROTECTED] > There's a (closed, not enough info) bug report on this: > http://bugs.php.net/bug.php?id=29227 > (just to confirm that there's an issue there at all) > > > -Original Message- > > From: Markus Fischer [mailto:[EMAIL PROTECTED] > > Sent: 12 August 2004 09:13 > > To: [EMAIL PROTECTED] > > Subject: Re: [PHP-DEV] Re: 5.0.1RC2 > > > > > > Ron Korving wrote: > > > > > Okay :) By the way, Andi, do you know anything about the > > OpenSSL segfault I > > > wrote about in this list on August 9th? If it's unknown, I'll test it > > > thoroughly (isolate the problem) and write a bugreport... > > > > I had similiar problems (I think) when I was using mod_ssl with PHP and > > was loading certain modules at startup; unfortunately this is all I > > remember. Are you using mod_ssl, too? > > > > regards, > > - Markus > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] is_a() vs. instanceof
What about:
if (get_class($obj) == "unloadedclass") {
// blah
}
Jevon
- Original Message -
From: "Al Baker" <[EMAIL PROTECTED]>
To: "Hans Lellelid" <[EMAIL PROTECTED]>
Cc: "Dan Ostrowski" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
Sent: Thursday, August 12, 2004 9:58 PM
Subject: Re: [PHP-DEV] is_a() vs. instanceof
> I agree, that's the exact behavior I would like as well and what most
> people would expect.
>
> Al
>
> On Wed, 2004-08-11 at 23:52 -0400, Hans Lellelid wrote:
> > Alan Knowles wrote:
> >
> > > I think he's referening to something like this (which is common in
pear):
> > >
> > > $x = $someobj->somemethod();
> > > if ($x instanceOf PEAR_Error) {
> > > ...
> > > }
> > >
> > > while that code is redundant in the case of exceptions, it is still a
> > > valid situation.. that $x may be a valid return, and PEAR_Error was
> > > never loaded..
> >
> >
> > Yup, that's exactly what I'm talking about.
> >
> > I want to be able to do this:
> >
> > if ($db instanceof DBPostgres) {
> >/// do something funky specific to Postgres
> > }
> >
> > If My DB adapter is DBMySQL, I don't want to load the DBPostgres adapter
> > just so I can test whether my object is of that type ...
> >
> > and checking first whether class_exists('DBPostgres') just seems kinda
> > kludgy & straying from the "problem domain" ... especially since $db
> > instanceof DBPostgres would *always* be false if DBPostgres isn't
loaded.
> >
> > Hans
> >
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: 5.0.1RC2
http://bugs.php.net/how-to-report.php On Thu, 12 Aug 2004 11:02:13 +0200, Ron Korving <[EMAIL PROTECTED]> wrote: > yes, this is apache related.. > the segfault i experienced wasn't, because it occured in cli mode, so it > must be something different. > > Ron > > "Steph" <[EMAIL PROTECTED]> schreef in bericht > news:[EMAIL PROTECTED] > > > > There's a (closed, not enough info) bug report on this: > > http://bugs.php.net/bug.php?id=29227 > > (just to confirm that there's an issue there at all) > > > > > -Original Message- > > > From: Markus Fischer [mailto:[EMAIL PROTECTED] > > > Sent: 12 August 2004 09:13 > > > To: [EMAIL PROTECTED] > > > Subject: Re: [PHP-DEV] Re: 5.0.1RC2 > > > > > > > > > Ron Korving wrote: > > > > > > > Okay :) By the way, Andi, do you know anything about the > > > OpenSSL segfault I > > > > wrote about in this list on August 9th? If it's unknown, I'll test it > > > > thoroughly (isolate the problem) and write a bugreport... > > > > > > I had similiar problems (I think) when I was using mod_ssl with PHP and > > > was loading certain modules at startup; unfortunately this is all I > > > remember. Are you using mod_ssl, too? > > > > > > regards, > > > - Markus > > > > > > -- > > > PHP Internals - PHP Runtime Development Mailing List > > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] new PHP extension: newt
Hi, I'm developing a new PHP extension for CLI/CGI, that may be very useful in administrative day-to-day work. If you find it useful, please give me instructions how I can merge it to the CVS. Status of the project: 80% written, not tested (quite) Homepage: http://php-newt.sourceforge.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] [PATCH] Bug #14924 (The POSIX access(2) function is not available)
Hello!
Here's a patch that adds posix_access function to the posix extension.
This function will report correct permissions when an ACL system is in use,
is_writeable, etc do not.
Is it ok to commit to head ?
/Magnus
--
"I'm a mean green mother from outer space"
-- Audrey II, The Little Shop of Horrors
Index: php_posix.h
===
RCS file: /repository/php-src/ext/posix/php_posix.h,v
retrieving revision 1.14
diff -u -r1.14 php_posix.h
--- php_posix.h 8 Jan 2004 17:32:41 - 1.14
+++ php_posix.h 12 Aug 2004 10:36:33 -
@@ -90,6 +90,9 @@
PHP_FUNCTION(posix_mkfifo);
#endif
+/* POSIX.1, 5.6 */
+PHP_FUNCTION(posix_access);
+
/* POSIX.1, 9.2 */
PHP_FUNCTION(posix_getgrnam);
PHP_FUNCTION(posix_getgrgid);
Index: posix.c
===
RCS file: /repository/php-src/ext/posix/posix.c,v
retrieving revision 1.60
diff -u -r1.60 posix.c
--- posix.c 18 Apr 2004 21:49:10 - 1.60
+++ posix.c 12 Aug 2004 10:36:33 -
@@ -108,6 +108,8 @@
PHP_FE(posix_mkfifo,NULL)
#endif
+ /* POSIX.1, 5.6 */
+ PHP_FE(posix_access,NULL)
/* POSIX.1, 9.2 */
PHP_FE(posix_getgrnam, NULL)
PHP_FE(posix_getgrgid, NULL)
@@ -146,6 +148,10 @@
static PHP_MINIT_FUNCTION(posix)
{
ZEND_INIT_MODULE_GLOBALS(posix, php_posix_init_globals, NULL);
+ REGISTER_LONG_CONSTANT("POSIX_F_OK", F_OK, CONST_CS | CONST_PERSISTENT);
+ REGISTER_LONG_CONSTANT("POSIX_X_OK", X_OK, CONST_CS | CONST_PERSISTENT);
+ REGISTER_LONG_CONSTANT("POSIX_W_OK", W_OK, CONST_CS | CONST_PERSISTENT);
+ REGISTER_LONG_CONSTANT("POSIX_R_OK", R_OK, CONST_CS | CONST_PERSISTENT);
return SUCCESS;
}
/* }}} */
@@ -638,15 +644,46 @@
POSIX.1, 5.5.1 unlink()
POSIX.1, 5.5.2 rmdir()
POSIX.1, 5.5.3 rename()
- POSIX.1, 5.6.x stat(), access(), chmod(), utime()
- already supported by PHP (access() not supported, because it is
- braindead and dangerous and gives outdated results).
+ POSIX.1, 5.6.x stat(), chmod(), utime() already supported by PHP.
+*/
+
+/* {{{ proto bool posix_access(string file [, int mode])
+ Determine accessibility of a file (POSIX.1 5.6.3) */
+PHP_FUNCTION(posix_access)
+{
+ long mode = 0;
+ int filename_len, ret;
+ char *filename, *path;
+
+ if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|l", &filename,
&filename_len, &mode) == FAILURE)
+ return;
+
+ path = expand_filepath(filename, NULL TSRMLS_CC);
+
+ if (php_check_open_basedir_ex(path, 0 TSRMLS_CC)) {
+ efree(path);
+ POSIX_G(last_error) = EPERM;
+ RETURN_FALSE;
+ }
+
+ ret = access(path, mode);
+ efree(path);
+
+ if (ret) {
+ POSIX_G(last_error) = errno;
+ RETURN_FALSE;
+ }
+
+ RETURN_TRUE;
+}
+/* }}} */
+/*
POSIX.1, 6.x most I/O functions already supported by PHP.
POSIX.1, 7.x tty functions, TODO
POSIX.1, 8.x interactions with other C language functions
- POSIX.1, 9.x system database access
- */
+ POSIX.1, 9.x system database access
+*/
/* {{{ proto array posix_getgrnam(string groupname)
Group database access (POSIX.1, 9.2.1) */
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
Ilia Alshanetsky wrote: iliaa Wed Jul 21 17:57:03 2004 EDT Modified files: /php-src/ext/imap php_imap.c Log: Fixed bug #29209 (imap_fetchbody() doesn't check message index). # Initial Patch by tony2001 at phpclub dot net http://cvs.php.net/diff.php/php-src/ext/imap/php_imap.c?r1=1.184&r2=1.185&ty=u This "fix" breaks retrieving message bodies if not using the sequence number in imap_fetchbody() but the UID instead. imap_fetchbody($stream, 1, 1, FT_UID) doesn't work anymore, while imap_fetchbody($stream, imap_msgno($stream, 1), 1) works. Jan. P.S.: this patch has been committed to all branches. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: PHP 4.3.9RC1 Released
On August 12, 2004 04:55 am, Ron Korving wrote: > Do you know when fixes in PHP4.3.9 will find its way to PHP5? All of the patches applicable 5.X tree are applied at the same time as they are to 4.3.X tree. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] new PHP extension: newt
* Thus wrote Michael Spector: > Hi, > > I'm developing a new PHP extension for CLI/CGI, that may be very useful in > administrative > day-to-day work. If you find it useful, please give me instructions how I can merge > it to the CVS. Extensions are handled over in http://pecl.php.net/ Curt -- First, let me assure you that this is not one of those shady pyramid schemes you've been hearing about. No, sir. Our model is the trapezoid! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] snaps.php.net - STABLE snapshot for PHP5
Looking on snaps.php.net I cannot find a PHP5-STABLE release, only latest HEAD and PHP4-STABLE. I think the branch PHP_5_0 should also be available via snaps.php.net - Uwe Schindler [EMAIL PROTECTED] - http://www.php.net NSAPI SAPI developer Erlangen, Germany -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] snaps.php.net - STABLE snapshot for PHP5
On Thu, 12 Aug 2004, Uwe Schindler wrote: > Looking on snaps.php.net I cannot find a PHP5-STABLE release, only latest > HEAD and PHP4-STABLE. I think the branch PHP_5_0 should also be available > via snaps.php.net I will fix that tomorrow. Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
Zitat von Jan Schneider <[EMAIL PROTECTED]>: Ilia Alshanetsky wrote: iliaa Wed Jul 21 17:57:03 2004 EDT Modified files: /php-src/ext/imap php_imap.c Log: Fixed bug #29209 (imap_fetchbody() doesn't check message index). # Initial Patch by tony2001 at phpclub dot net http://cvs.php.net/diff.php/php-src/ext/imap/php_imap.c?r1=1.184&r2=1.185&ty=u This "fix" breaks retrieving message bodies if not using the sequence number in imap_fetchbody() but the UID instead. imap_fetchbody($stream, 1, 1, FT_UID) doesn't work anymore, while imap_fetchbody($stream, imap_msgno($stream, 1), 1) works. Jan. P.S.: this patch has been committed to all branches. Just in case I wasn't clear: this is a showstopper for 4.3.9 and 5.0.1 as it breaks every second application using the imap extension to retrieve messages, including IMP. Jan. -- Do you need professional PHP or Horde consulting? http://horde.org/consulting.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
Quit complaining and fix the patch properly then. --Wez. On Thu, 12 Aug 2004 17:55:33 +0200, Jan Schneider <[EMAIL PROTECTED]> wrote: > Zitat von Jan Schneider <[EMAIL PROTECTED]>: > > > Ilia Alshanetsky wrote: > >> iliaaWed Jul 21 17:57:03 2004 EDT > >> > >> Modified files: /php-src/ext/imap php_imap.c Log: > >> Fixed bug #29209 (imap_fetchbody() doesn't check message index). > >> # Initial Patch by tony2001 at phpclub dot net > >> > >> http://cvs.php.net/diff.php/php-src/ext/imap/php_imap.c?r1=1.184&r2=1.185&ty=u > > > > This "fix" breaks retrieving message bodies if not using the sequence > > number in imap_fetchbody() but the UID instead. > > > > imap_fetchbody($stream, 1, 1, FT_UID) > > doesn't work anymore, while > > imap_fetchbody($stream, imap_msgno($stream, 1), 1) > > works. > > > > Jan. > > > > P.S.: this patch has been committed to all branches. > > Just in case I wasn't clear: this is a showstopper for 4.3.9 and 5.0.1 as it > breaks every second application using the imap extension to retrieve > messages, including IMP. > > Jan. > > -- > Do you need professional PHP or Horde consulting? > http://horde.org/consulting.php > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
At 05:55 PM 8/12/2004 +0200, Jan Schneider wrote: Zitat von Jan Schneider <[EMAIL PROTECTED]>: Ilia Alshanetsky wrote: iliaa Wed Jul 21 17:57:03 2004 EDT Modified files: /php-src/ext/imapphp_imap.c Log: Fixed bug #29209 (imap_fetchbody() doesn't check message index). # Initial Patch by tony2001 at phpclub dot net http://cvs.php.net/diff.php/php-src/ext/imap/php_imap.c?r1=1.184&r2=1.185&ty=u This "fix" breaks retrieving message bodies if not using the sequence number in imap_fetchbody() but the UID instead. imap_fetchbody($stream, 1, 1, FT_UID) doesn't work anymore, while imap_fetchbody($stream, imap_msgno($stream, 1), 1) works. Jan. P.S.: this patch has been committed to all branches. Just in case I wasn't clear: this is a showstopper for 4.3.9 and 5.0.1 as it breaks every second application using the imap extension to retrieve messages, including IMP. Ilia, Tony, Any idea? We should probably revert this patch and make imap behave in the previous manner until a real fix is found. Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
On Thu, Aug 12, 2004 at 05:38:33PM +0100, Wez Furlong wrote: > Quit complaining and fix the patch properly then. Be nice. The patch, as committed, breaks backwards compatibility in a point release. The proper "fix" is to revert it unless someone has a version that actually works. Jan doesn't have php-src commit privileges, so he can't fix it himself. -- Jon Parise (jon of php.net) :: The PHP Project (http://www.php.net/) -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
Chuck already applied a patch that should resolve the problem that Jan had reported. Ilia On August 12, 2004 02:21 pm, Andi Gutmans wrote: > At 05:55 PM 8/12/2004 +0200, Jan Schneider wrote: > >Zitat von Jan Schneider <[EMAIL PROTECTED]>: > >>Ilia Alshanetsky wrote: > >>>iliaa Wed Jul 21 17:57:03 2004 EDT > >>> > >>> Modified files: /php-src/ext/imapphp_imap.c > >>> Log: Fixed bug #29209 (imap_fetchbody() doesn't check message index). # > >>> Initial Patch by tony2001 at phpclub dot net > >>> > >>>http://cvs.php.net/diff.php/php-src/ext/imap/php_imap.c?r1=1.184&r2=1.18 > >>>5&ty=u > >> > >>This "fix" breaks retrieving message bodies if not using the sequence > >>number in imap_fetchbody() but the UID instead. > >> > >>imap_fetchbody($stream, 1, 1, FT_UID) > >>doesn't work anymore, while > >>imap_fetchbody($stream, imap_msgno($stream, 1), 1) > >>works. > >> > >>Jan. > >> > >>P.S.: this patch has been committed to all branches. > > > >Just in case I wasn't clear: this is a showstopper for 4.3.9 and 5.0.1 as > > it breaks every second application using the imap extension to retrieve > > messages, including IMP. > > Ilia, Tony, > > Any idea? We should probably revert this patch and make imap behave in the > previous manner until a real fix is found. > > Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
Quoting Jon Parise <[EMAIL PROTECTED]>: The patch, as committed, breaks backwards compatibility in a point release. The proper "fix" is to revert it unless someone has a version that actually works. I committed a change that should avoid the range check if the FT_UID flag is set. If someone could test it that'd be great. -chuck -- "Regard my poor demoralized mule!" - Juan Valdez -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
On Thu, 12 Aug 2004 14:28:44 -0400, Jon Parise <[EMAIL PROTECTED]> wrote: > On Thu, Aug 12, 2004 at 05:38:33PM +0100, Wez Furlong wrote: > > Quit complaining and fix the patch properly then. > Be nice. > Jan doesn't have php-src commit privileges, so he can't fix it > himself. The wonder of OpenSource allows Jan to write the patch on his machine and post it here so that someone can commit it for him, rather than keep bellyaching about the problem. We got the message the first time. --Wez. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
OK guys. I'd like to roll so please check this problem and give me an ack if it's OK. At 02:38 PM 8/12/2004 -0400, Ilia Alshanetsky wrote: Chuck already applied a patch that should resolve the problem that Jan had reported. Ilia On August 12, 2004 02:21 pm, Andi Gutmans wrote: > At 05:55 PM 8/12/2004 +0200, Jan Schneider wrote: > >Zitat von Jan Schneider <[EMAIL PROTECTED]>: > >>Ilia Alshanetsky wrote: > >>>iliaa Wed Jul 21 17:57:03 2004 EDT > >>> > >>> Modified files: /php-src/ext/imapphp_imap.c > >>> Log: Fixed bug #29209 (imap_fetchbody() doesn't check message index). # > >>> Initial Patch by tony2001 at phpclub dot net > >>> > >>>http://cvs.php.net/diff.php/php-src/ext/imap/php_imap.c?r1=1.184&r2=1.18 > >>>5&ty=u > >> > >>This "fix" breaks retrieving message bodies if not using the sequence > >>number in imap_fetchbody() but the UID instead. > >> > >>imap_fetchbody($stream, 1, 1, FT_UID) > >>doesn't work anymore, while > >>imap_fetchbody($stream, imap_msgno($stream, 1), 1) > >>works. > >> > >>Jan. > >> > >>P.S.: this patch has been committed to all branches. > > > >Just in case I wasn't clear: this is a showstopper for 4.3.9 and 5.0.1 as > > it breaks every second application using the imap extension to retrieve > > messages, including IMP. > > Ilia, Tony, > > Any idea? We should probably revert this patch and make imap behave in the > previous manner until a real fix is found. > > Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
Quoting Andi Gutmans <[EMAIL PROTECTED]>: OK guys. I'd like to roll so please check this problem and give me an ack if it's OK. I believe with Ilia's correction it should be fine now. -chuck -- "Regard my poor demoralized mule!" - Juan Valdez -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
On August 12, 2004 03:47 pm, Andi Gutmans wrote: > OK guys. I'd like to roll so please check this problem and give me an ack > if it's OK. Should be ok now. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
Thanks! At 03:50 PM 8/12/2004 -0400, Ilia Alshanetsky wrote: On August 12, 2004 03:47 pm, Andi Gutmans wrote: > OK guys. I'd like to roll so please check this problem and give me an ack > if it's OK. Should be ok now. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
On Thu, Aug 12, 2004 at 07:59:39PM +0100, Wez Furlong wrote: > > > Quit complaining and fix the patch properly then. > > Be nice. > > Jan doesn't have php-src commit privileges, so he can't fix it > > himself. > > The wonder of OpenSource allows Jan to write the patch on his > machine and post it here so that someone can commit it for him, > rather than keep bellyaching about the problem. And what if Jan doesn't know C or feel comfortable writing PHP extension code, for example? > We got the message the first time. Good, but the wonder of OpenSource doesn't give you the right to be an ass. I'm glad the code problem is fixed. I hope the attitude problem will be fixed as expediently. -- Jon Parise (jon of php.net) :: The PHP Project (http://www.php.net/) -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c
On Thu, 12 Aug 2004 16:16:51 -0400, Jon Parise <[EMAIL PROTECTED]> wrote: > And what if Jan doesn't know C or feel comfortable writing PHP > extension code, for example? Even more reason to stop complaining and wait for someone with the appropriate skill to get home from work and give the problem the investigation it deserves. > Good, but the wonder of OpenSource doesn't give you the right to be an > ass. I may have been a little blunt, but do you seriously have a problem with me telling someone (that should know better) to be patient? > I'm glad the code problem is fixed. I hope the attitude problem will > be fixed as expediently. Likewise, for all three of you. Any further problems you have with me can be directed to me in private email. --Wez. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] zend_list_addref and object resources
- Original Message - From: "Marshall A. Greenblatt" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, August 09, 2004 11:38 PM Subject: [PHP-DEV] zend_list_addref and object resources [snip] > When assigning an object resource to either 'getThis()' or 'return_value' as > shown below, is it necessary to manually increment the reference count? > > For example, /ext/ming/ming.c (version 1.70) contains many code fragments > like the following where zend_list_addref() is used with 'getThis()', and > not used with 'return_value': > > > ret = zend_list_insert(action, le_swfactionp); > > object_init_ex(getThis(), action_class_entry_ptr); > add_property_resource(getThis(), "action", ret); > zend_list_addref(ret); > [snip] In answer to my own question: No, at least not with PHP4.3.1. In either case, irregardless of whether zend_list_addref() is explicitly called for the resource ID, output (via print_zval) is as follows: Addr:[9F75D0] is_ref:[0] refcount:[2] Type:[OBJECT] Class:[myobj] Val:[ Name:[value] => Addr:[9F7798] is_ref:[0] refcount:[1] Type:[RESOURCE] Val:[1] ] Addr:[9F7638] is_ref:[0] refcount:[2] Type:[OBJECT] Class:[myobj] Val:[ Name:[value] => Addr:[9F79B8] is_ref:[0] refcount:[1] Type:[RESOURCE] Val:[2] ] If anyone is interested in playing with this, email me and I'll make the source code available online. - Marshall Note: The print_zval function takes any type of variable and displays the value, similar to print_r, but in a more useful debugging format. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] PHP_EOL exposed to scripts?
At 09:23 AM 8/12/2004 +0200, Derick Rethans wrote: On Wed, 11 Aug 2004, Andi Gutmans wrote: > I think it's a good idea. Personally I think that making this EOL would > make it even easier to use. We can't do that because I bet it's a constant that many people have done in their own scripts. So IMO PHP_EOL is the way to go. You have a point that probably many people already have EOL defined. Well I guess that if someone doesn't like the "too" verbose PHP_EOL they can always re-define it to EOL in their prepend. Most important is that this constant exists as it's very useful. I already patch 5.0.x and 5.1.x for this, just need to commit it (when I hear more opinions of course). Sounds good to me. Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: PHP 4.3.9RC1 Released
Ilia Alshanetsky wrote: > On August 12, 2004 04:55 am, Ron Korving wrote: >> Do you know when fixes in PHP4.3.9 will find its way to PHP5? > > All of the patches applicable 5.X tree are applied at the same time as > they are to 4.3.X tree. An additional note: PHP 5.0.1, including the same fixes (plus some PHP5 fixes) is going to be released soon (maybe tomorrow...) johannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] 5.0.1RC2
* Thus wrote Andi Gutmans: > Hey, > > 5.0.1RC2 is at http://snaps.php.net/~andi > Planning on release tomorrow (before I go away on a long weekend). pertaining to bug 26737 (http://bugs.php.net/26737) I've been trying to come up with a patch to this but my lack of knowledge with zend and object behaviour is crippling me. I've narrowed it down to php_var_serialize_class() not properly finding the properly scoped variable, it only is looking for public scope vars. I'm not sure if this should hold up a release for RC2 but, probably should get fixed before the final version comes out. Curt -- First, let me assure you that this is not one of those shady pyramid schemes you've been hearing about. No, sir. Our model is the trapezoid! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] 5.0.1RC2
* Thus wrote Curt Zirzow: > > I'm not sure if this should hold up a release for RC2 but, probably > should get fixed before the final version comes out. Dont mind me.. I'm a bit behind the times! Curt -- First, let me assure you that this is not one of those shady pyramid schemes you've been hearing about. No, sir. Our model is the trapezoid! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
