[Fwd: [PHP-DEV] [PATCH] php.ini-(recommended|dist) whitespace noise and typo fix]

2005-01-13 Thread Daniel Lorch
Hi
It seems that this patch has been overlooked somehow. This is only a cosmetic 
patch (but a useful one, I believe) which doesn't change any functionality. It 
shouldn't take long to verify/apply.

Daniel
 Original Message 
Subject: [PHP-DEV] [PATCH] php.ini-(recommended|dist) whitespace noise and typo 
fix
Date: Tue, 21 Dec 2004 01:00:59 +0100
From: Daniel Lorch <[EMAIL PROTECTED]>
To: internals@lists.php.net
Hi
I did a `diff -u php.ini-dist php.ini-recommended` to see which settings
differ. I discovered a lot of 'whitespace noise' and some typos in
comments. No big deal but I'd be glad if someone could apply the patch
attached to this mail.
Daniel
diff -ur php-4.3.10-dist/php.ini-dist php-4.3.10/php.ini-dist
--- php-4.3.10-dist/php.ini-distWed Aug 18 07:05:23 2004
+++ php-4.3.10/php.ini-dist Tue Dec 21 00:54:26 2004
@@ -108,7 +108,7 @@
 ; Transparent output compression using the zlib library
 ; Valid values for this option are 'off', 'on', or a specific buffer size
 ; to be used for compression (default is 4KB)
-; Note: Resulting chunk size may vary due to nature of compression. PHP 
+; Note: Resulting chunk size may vary due to nature of compression. PHP
 ;   outputs chunks that are few hundreds bytes each as a result of 
 ;   compression. If you prefer a larger chunk size for better 
 ;   performance, enable output_buffering in addition.
@@ -153,6 +153,7 @@
 ; reference).
 allow_call_time_pass_reference = On
 
+;
 ; Safe Mode
 ;
 safe_mode = Off
@@ -231,6 +232,7 @@
 max_input_time = 60; Maximum amount of time each script may spend parsing 
request data
 memory_limit = 8M  ; Maximum amount of memory a script may consume (8MB)
 
+
 ;;
 ; Error handling and logging ;
 ;;
@@ -309,7 +311,7 @@
 
 ; Disable the inclusion of HTML tags in error messages.
 ;html_errors = Off
-  
+
 ; If html_errors is set On PHP produces clickable error messages that direct 
 ; to a page describing the error or function causing the error in detail.
 ; You can download a copy of the PHP manual from http://www.php.net/docs.php 
@@ -469,7 +471,7 @@
 ; RFC2616 compliant header.
 ; Default is zero.
 ;cgi.rfc2616_headers = 0 
- 
+
 
 
 ; File Uploads ;
@@ -692,7 +694,7 @@
 pgsql.allow_persistent = On
 
 ; Detect broken persistent links always with pg_pconnect(). Need a little 
overhead.
-pgsql.auto_reset_persistent = Off 
+pgsql.auto_reset_persistent = Off
 
 ; Maximum number of persistent links.  -1 means no limit.
 pgsql.max_persistent = -1
@@ -701,6 +703,7 @@
 pgsql.max_links = -1
 
 ; Ignore PostgreSQL backends Notice message or not.
+; Notice message logging requires a little overhead.
 pgsql.ignore_notice = 0
 
 ; Log PostgreSQL backends Noitce message or not.
@@ -892,7 +895,7 @@
 
 ;session.entropy_file = /dev/urandom
 
-; Set to {nocache,private,public,} to determine HTTP caching aspects
+; Set to {nocache,private,public,} to determine HTTP caching aspects.
 ; or leave this empty to avoid sending anti-caching headers.
 session.cache_limiter = nocache
 
@@ -900,7 +903,7 @@
 session.cache_expire = 180
 
 ; trans sid support is disabled by default.
-; Use of trans sid may risk your users security. 
+; Use of trans sid may risk your users security.
 ; Use this option with caution.
 ; - User may send URL contains active session ID
 ;   to other person via. email/irc/etc.
@@ -936,7 +939,7 @@
 ; Compatability mode with old versions of PHP 3.0.
 mssql.compatability_mode = Off
 
-; Connec timeout
+; Connect timeout
 ;mssql.connect_timeout = 5
 
 ; Query timeout
diff -ur php-4.3.10-dist/php.ini-recommended php-4.3.10/php.ini-recommended
--- php-4.3.10-dist/php.ini-recommended Wed Aug 18 07:05:23 2004
+++ php-4.3.10/php.ini-recommended  Tue Dec 21 00:54:55 2004
@@ -121,12 +121,12 @@
 ; Transparent output compression using the zlib library
 ; Valid values for this option are 'off', 'on', or a specific buffer size
 ; to be used for compression (default is 4KB)
-; Note: Resulting chunk size may vary due to nature of compression. PHP 
-;   outputs chunks that are few handreds bytes each as a result of 
compression. 
-;   If you want larger chunk size for better performence, enable 
output_buffering 
-;   also. 
-; Note: output_handler must be empty if this is set 'On' 
-;   Instead you must use zlib.output_handler.
+; Note: Resulting chunk size may vary due to nature of compression. PHP
+;   outputs chunks that are few hundreds bytes each as a result of 
+;   compression. If you prefer a larger chunk size for better 
+;   performance, enable output_buffering in addition.
+; Note: You need to use zlib.output_handler instead of the standard
+;   output_handler, or otherwise the output will be corrupted.
 zlib.output_compression = Off
 
 ; You cannot specify additional output handlers if zlib.output_compression
@@ -414,7 +414,7 @@
 default_mimetype = "text/html"
 ;default_charset = "is

[PHP-DEV] Re: #31098 [Csd]: isset false positive

2005-01-13 Thread Moriyoshi Koizumi
On 2005/01/13, at 15:21, <[EMAIL PROTECTED]> wrote:
I don't quite agree with you. Indeed it's semantically wrong,
yet I think we leave it to behave as in ZE1, in terms of
backwards compatibility.
I don't think we must make compatibility for bugs.
Users don't consider a certain behaviour that lasts for years
the way we do to be a bug, even if it is inconsistent and
rationally wrong, since they often got used to it and supposedly
developed some workaround for it while we can rarely predict
how they code with it and cope with it.
Thus we should think of what the word "backwards compatibility"
does actually mean.
Moriyoshi
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php


[PHP-DEV] RE: Get name of extending class with static method call (PHP5)

2005-01-13 Thread Torsten Roehr
> -Original Message-
> From: Christian Schneider [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, January 12, 2005 9:05 PM
> To: Torsten Roehr
> Cc: internals@lists.php.net
> Subject: Re: Get name of extending class with static method call (PHP5)
>
>
> Hey Torsten,
>
> Torsten Roehr wrote:
> > $persons = Person::load($sql); // returns collection of Person objects
> > $cars= Car::load($sql);// returns collection of Car objects
>
> Simple solutions:
> 1) $persons = DB::load('Person', $sql); foreach ($persons as $person)...
> 2) $person = new Person($sql); while ($person->iterate())...
> 3) Adding get_class() to all DB classes (like Person) as suggested by
> Daniel Convissor.
>
> Solution 1) is IMHO close enough to your solution. Personally I prefer
> (and we are using) solution 2) here as it also is more space efficient
> for large number of results returned from the DB (only one Person object
> is needed). On top of that we create classes automatically at runtime
> from DB tables which removed the need to write stub classes (and makes
> solution 3) feasible again).
>
> I suggest that we take this discussion off-line now as it is not really
> an internals discussion anymore.
>
> - Chris

Hi Chris,

thank you very much for the proposed solutions - I will take them into
consideration. But the problem still persists and will come up in different
situations, not just in mine.

I am keen to hear some more opinions from other gurus on this list. Thank
you in advance!

Best regards, Torsten Roehr

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-DEV] [PATCH] PHP5 and LDAP SASL support

2005-01-13 Thread Quanah Gibson-Mount
It seems impossible to subscribe to this list via the web interface, so I'm 
going to see if I can just send a direct email...

PHP5 introduced LDAP SASL binds.  However, it failed to actually implement 
them, other than to create a dummy function that does nothing.  I've 
written a patch that correctly implements LDAP SASL binds in PHP.  I filed 
bug #30819 for this.

I have an updated patch (against 5.0.3) available at:

--Quanah
--
Quanah Gibson-Mount
Principal Software Developer
ITSS/Shared Services
Stanford University
GnuPG Public Key: http://www.stanford.edu/~quanah/pgp.html

QA Engineer
OpenLDAP Core Team
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php


Re: [PHP-DEV] php4.3.11/5.0.4

2005-01-13 Thread Quanah Gibson-Mount
In article <[EMAIL PROTECTED]>, [EMAIL PROTECTED] 
says...
> Short update:
> Seems there are 2-3 bugs that need attending so I think it'll take about a 
> week to 10 days for an RC1.
> 
> Andi
> 
> At 05:50 PM 12/29/2004 -0800, Andi Gutmans wrote:
> >Ilia and I decided to roll in the beginning of January when people are 
> >back from vacation and we get some beta testers. We could RC1 next week if 
> >no one has any pending patches.
> >
> >Andi
> >
> >At 08:47 AM 12/30/2004 +0800, Alan Knowles wrote:
> >>any updates on the plan to release of these - I'm getting 1-2 emails/bug 
> >>reports a day reporting the same problems with code broken by  both 
> >>4.3.10 / 5.0.3
> >>
> >>Regards
> >>Alan

PHP 5 was supposed to add SASL support for LDAP.  However, the LDAP SASL 
implementation for PHP 5 is completely broken, and does nothing.  I've 
written a working patch for this, available at:



This is also bug #30819.  The above patch is updated against 5.0.3.

I think it would be great to see LDAP SASL binds working in PHP.

Thanks!

--Quanah

--
Quanah Gibson-Mount
Principal Software Developer
ITSS/Shared Services
Stanford University
GnuPG Public Key: http://www.stanford.edu/~quanah/pgp.html

QA Engineer
OpenLDAP Core Team

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php