Re: [PHP-DEV] include bug in 5.3
This behavior is already implemented in "improved" patch that I sent on
Saturday.
Thanks. Dmitry.
Rasmus Lerdorf wrote:
Stefan Esser wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hello Dmitry,
while you are at fixing realpath() it might be a good idea to fix the
../ nonsense.
What I mean is:
fopen("this_is_not_a_dir_but_a_file/../../../../../../../../etc/passwd",
"r");
works because of realpath() and PHP's wrapper.
Same for
fopen("this_is_not_existing/../../../../../../../../etc/passwd", "r");
Dmitry, I think this is a good suggestion. If any component of the
path, other than the final one is not a directory, or if a component of
the path doesn't exist, the realpath call should fail. We're doing the
stat on each one anyway, so checking the entry type shouldn't be an issue.
-Rasmus
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] include bug in 5.3
This test failure is expected, but only this one. Thanks. Dmitry. Antony Dovgal wrote: On 09.08.2008 19:28, Dmitry Stogov wrote: The improved patch fixes all the issues I found during testing. However I wasn't able to test it on NETWARE and on Solaris with relative paths. Please test it as much as possible. I'm going to commit it on Tuesday in case of no objections. ext/standard/tests/file/clearstatcache_001.phpt fails with the patch applied. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: #45265 - Very slow performance on Windows for tolower
Hmm, maybe we could give a try to Windows implementation of _tolower_l and see if by giving ourselves the _locale_t, it's faster or not... Pierre any idea about that? -- Cordialement. -- Nicolas Chaillan | GROUPAKT.fr | UIN : 16549830 [EMAIL PROTECTED] | [EMAIL PROTECTED] | http://www.groupakt.fr http://www.fmsakt.fr | http://www.prospecttel.com Directeur général. ""Nicolas Chaillan"" <[EMAIL PROTECTED]> a écrit dans le message de groupe de discussion : [EMAIL PROTECTED] Hello, The bug #45265 ( http://bugs.php.net/bug.php?id=45265 ) seems quite Critical to me (not that I use PHP on Windows that much but...). Can anyone take a look at Pierre's comment, it seems really interesting but it could tend to BC and maybe undefined behaviours, but actually I don't see anything else that could fix it. What do you think guys? Thanks for your time. -- Regards. -- Nicolas Chaillan | GROUPAKT.fr | UIN : 16549830 [EMAIL PROTECTED] | [EMAIL PROTECTED] | http://www.groupakt.fr http://www.fmsakt.fr | http://www.prospecttel.com Directeur général. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] #45265 - Very slow performance on Windows for tolower
Hello, The bug #45265 ( http://bugs.php.net/bug.php?id=45265 ) seems quite Critical to me (not that I use PHP on Windows that much but...). Can anyone take a look at Pierre's comment, it seems really interesting but it could tend to BC and maybe undefined behaviours, but actually I don't see anything else that could fix it. What do you think guys? Thanks for your time. -- Regards. -- Nicolas Chaillan | GROUPAKT.fr | UIN : 16549830 [EMAIL PROTECTED] | [EMAIL PROTECTED] | http://www.groupakt.fr http://www.fmsakt.fr | http://www.prospecttel.com Directeur général. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] include bug in 5.3
""Pierre Joye"" <[EMAIL PROTECTED]> a écrit dans le message de groupe de discussion : [EMAIL PROTECTED] hi all! Hello all, On Sat, Aug 9, 2008 at 12:41 PM, Hannes Magnusson <[EMAIL PROTECTED]> wrote: On Sat, Aug 9, 2008 at 12:31, Dmitry Stogov <[EMAIL PROTECTED]> wrote: Where is it documented? http://php.net/realpath http://www.ipnom.com/FreeBSD-Man-Pages/realpath.3.html "On BSD systems realpath() doesn't fail if only the last path component doesn't exist, while other systems will return FALSE." This behavior has genearated enough pain in the past to be dropped. The key problem in php application is portability. I'm in favor of dropping this BSD specific thing in 5.3+. +1, drop this BSD specific thing. It's impossible to write a portable code since PHP offers no internal function to test if it's BSD compatible or not. Does it? Doing a stat on the entry type would be a good idea as a security improvement too. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- Regards. -- Nicolas Chaillan | GROUPAKT.fr | UIN : 16549830 [EMAIL PROTECTED] | [EMAIL PROTECTED] | http://www.groupakt.fr http://www.fmsakt.fr | http://www.prospecttel.com Directeur général. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] clearstatcache change
On Sunday 10 August 2008 17:46:20 Arnaud Le Blanc wrote: > On Sunday 10 August 2008 17:14:52 Pierre Joye wrote: > > hi Arnaud! > > > > On Sat, Aug 9, 2008 at 4:20 PM, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: > > >> Commited :) > > > > Do you have a windows dev box? It seems that something is broken on > > Windows. One reproduce case is > > ext\standard\tests\file\copy_variation4-win32.phpt which fails using > > current 5.3-cvs. > > > > Let me know if you do not have a win box, I can try to fix it later this > > week. > > > > Cheers, > > Hi Pierre, > > No, I do not have a windows box here. > Does this test pass without this change ? http://news.php.net/php.cvs/52079 > > Regards, > > Arnaud Just readden the test, actually it seems it just needs to be updated (changing clearstatcache() by clearstatcache(true)). Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] clearstatcache change
On Sunday 10 August 2008 17:14:52 Pierre Joye wrote: > hi Arnaud! > > On Sat, Aug 9, 2008 at 4:20 PM, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: > >> Commited :) > > Do you have a windows dev box? It seems that something is broken on > Windows. One reproduce case is > ext\standard\tests\file\copy_variation4-win32.phpt which fails using > current 5.3-cvs. > > Let me know if you do not have a win box, I can try to fix it later this > week. > > Cheers, Hi Pierre, No, I do not have a windows box here. Does this test pass without this change ? http://news.php.net/php.cvs/52079 Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] run-tests.php esacapeshellarg, portability
hi! While fixing broken tests (linux or win), I found that shell arguments are manually escaped. Using escapeshellargs is more portable and avoid duplicate tests only to fix shell argument issues (& usage for example). Here is a patch to add escapeshellarg usage: http://pierre.libgd.org/patches/runtests_5_3_escapeshellarg.patch.txt A couple of tests need changes, like: inisetting="foo" will become inisetting=foo or inisetting="" to inisetting= Please test the patch or let me know if you have any objection :) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] clearstatcache change
hi Arnaud! On Sat, Aug 9, 2008 at 4:20 PM, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: >> Commited :) Do you have a windows dev box? It seems that something is broken on Windows. One reproduce case is ext\standard\tests\file\copy_variation4-win32.phpt which fails using current 5.3-cvs. Let me know if you do not have a win box, I can try to fix it later this week. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] include bug in 5.3
On Saturday 09 August 2008 23:16:30 Antony Dovgal wrote: > On 09.08.2008 19:28, Dmitry Stogov wrote: > > The improved patch fixes all the issues I found during testing. > > However I wasn't able to test it on NETWARE and on Solaris with relative > > paths. > > > > Please test it as much as possible. > > I'm going to commit it on Tuesday in case of no objections. > > ext/standard/tests/file/clearstatcache_001.phpt fails with the patch > applied. > > -- > Wbr, > Antony Dovgal Hi, The test was wrong, I fixed it. Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] CVS Account Request: eyal
Summiting phpt's -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
