[PHP-DEV] Borked SKIPIFs (PHP_5_4)
Hi,
annoyed by run-tests.php ignoring borked SKIPIF sections, I hacked it to
bail out at me if something seemed suspicious. Maintainers may want to
have a look at:
Fatal/Parse error @ SKIPIF = SKIPIF non functional
BORK 883/9126 [Zend/tests/bug31683.phpt]
BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt
BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]
Warnings/Notices @ SKIPIF = SKIPIF should work fine
BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]
BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]
BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]
BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]
My PHP was built with pretty much nothing but MySQL stuff enabled. A
fair number of tests has probably been skipped.
The run-tests.php hack I used is not worth sharing. All I did was check
if SKIPIF returns any output after removal of -d display_errors=0. In
other words I made the assumption that SKIPIF sections must not output
anything but skip message or the like, which causes false positives.
Ulf
Details:
BORK 883/9126 [Zend/tests/bug31683.phpt]
Warning: require_once(skipif.inc): failed to open stream: No such file
or directory in
/home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php
on line 1
Fatal error: require_once(): Failed opening required 'skipif.inc'
(include_path='.:/usr/local/lib/php') in
/home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php
on line 1
BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt
Fatal error: Call to undefined function php_version() in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/phar/tests/fopen_edgecases2.skip.php
on line 2
BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]
Notice: Use of undefined constant posix_getpgid - assumed
'posix_getpgid' in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_error.skip.php
on line 2
[] ext/posix/tests/posix_getpgid_error.phpt
BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]
Notice: Use of undefined constant posix_getpgid - assumed
'posix_getpgid' in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_variation.skip.php
on line 2
BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]
Warning: PHP Startup: session.upload_progress.freq must be greater than
or equal to zero in Unknown on line 0
BORK 4866/9248 [ext/session/tests/rfc1867_invalid_settings_2.phpt]
Warning: PHP Startup: session.upload_progress.freq cannot be over 100%
in Unknown on line 0
BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]
Warning: include(skipif.inc): failed to open stream: No such file or
directory in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd_wrapper_04.skip.php
on line 1
Warning: include(): Failed opening 'skipif.inc' for inclusion
(include_path='.:/usr/local/lib/php') in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd_wrapper_04.skip.php
in line 1
BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
Parse error: syntax error, unexpected '!', expecting '(' in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/md5_file.skip.php
on line 6
BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]
Parse error: syntax error, unexpected '!', expecting '(' in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/sha1_file.skip.php
on line 6
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Borked SKIPIFs (PHP_5_4)
hi Ulf,
I fixed two. Feel free to fix the other as well if you have time.
On Tue, Sep 6, 2011 at 4:40 PM, Ulf Wendel ulf.wen...@oracle.com wrote:
Hi,
annoyed by run-tests.php ignoring borked SKIPIF sections, I hacked it to
bail out at me if something seemed suspicious. Maintainers may want to have
a look at:
Fatal/Parse error @ SKIPIF = SKIPIF non functional
BORK 883/9126 [Zend/tests/bug31683.phpt]
BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt
BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]
Warnings/Notices @ SKIPIF = SKIPIF should work fine
BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]
BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]
BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]
BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]
My PHP was built with pretty much nothing but MySQL stuff enabled. A fair
number of tests has probably been skipped.
The run-tests.php hack I used is not worth sharing. All I did was check if
SKIPIF returns any output after removal of -d display_errors=0. In other
words I made the assumption that SKIPIF sections must not output anything
but skip message or the like, which causes false positives.
Ulf
Details:
BORK 883/9126 [Zend/tests/bug31683.phpt]
Warning: require_once(skipif.inc): failed to open stream: No such file or
directory in
/home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php on
line 1
Fatal error: require_once(): Failed opening required 'skipif.inc'
(include_path='.:/usr/local/lib/php') in
/home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php on
line 1
BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt
Fatal error: Call to undefined function php_version() in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/phar/tests/fopen_edgecases2.skip.php
on line 2
BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]
Notice: Use of undefined constant posix_getpgid - assumed 'posix_getpgid' in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_error.skip.php
on line 2
[] ext/posix/tests/posix_getpgid_error.phpt
BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]
Notice: Use of undefined constant posix_getpgid - assumed 'posix_getpgid' in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_variation.skip.php
on line 2
BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]
Warning: PHP Startup: session.upload_progress.freq must be greater than or
equal to zero in Unknown on line 0
BORK 4866/9248 [ext/session/tests/rfc1867_invalid_settings_2.phpt]
Warning: PHP Startup: session.upload_progress.freq cannot be over 100% in
Unknown on line 0
BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]
Warning: include(skipif.inc): failed to open stream: No such file or
directory in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd_wrapper_04.skip.php
on line 1
Warning: include(): Failed opening 'skipif.inc' for inclusion
(include_path='.:/usr/local/lib/php') in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd_wrapper_04.skip.php
in line 1
BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
Parse error: syntax error, unexpected '!', expecting '(' in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/md5_file.skip.php
on line 6
BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]
Parse error: syntax error, unexpected '!', expecting '(' in
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/sha1_file.skip.php
on line 6
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Borked SKIPIFs (PHP_5_4)
Hi Pierre, hi all, those three should be left: BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt] BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt] BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt] They might take more than 1 second (verbally) to fix. Leaving to someone else to have a 30 seconds look... ;-) Ulf -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Borked SKIPIFs (PHP_5_4)
On Tue, Sep 6, 2011 at 6:53 PM, Ulf Wendel ulf.wen...@oracle.com wrote: Hi Pierre, hi all, those three should be left: BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt] BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt] those are fixed already :) BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt] They might take more than 1 second (verbally) to fix. Leaving to someone else to have a 30 seconds look... ;-) Ulf -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
