[PHP-DEV] Breaking APIs for no good reason is a bad thing. (tm)

[Sara Golemon]

Now, I'll take some blame here for not being involved over the past
couple years and having not noticed this inanity sooner, but could
someone explain this cluster-f?

http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/Zend/zend_API.h?r1=268281r2=269153

This breaks the existing module API because any rational extension
developer has been putting 'static' in front of
ZEND_BEGIN_ARG_INFO_EX() _where appropriate_ for the better part of a
decade and it does ABSOLUTELY NOTHING more than the very /minor/
optimization of cleaning up the symbol space of poorly written
modules.  Worse, it breaks the ability of extension developers to keep
arg_info structures next to the functions they belong to while still
keeping those functions in separate files.

Someone give me a good reason not to revert this.

-Sara

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Breaking APIs for no good reason is a bad thing. (tm)

[Jani Taskinen]

On 12/09/2009 08:37 PM, Sara Golemon wrote:

Now, I'll take some blame here for not being involved over the past
couple years and having not noticed this inanity sooner, but could
someone explain this cluster-f?


It's also bad thing to abandon code like some people tend to do.
And to ignore bug reports assigned to them. Need I go on?


http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/Zend/zend_API.h?r1=268281r2=269153

[snip rant]

Someone give me a good reason not to revert this.


It's too late now.

--Jani



--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php