Re: [PHP-DEV] Bug 44383 in ext/soap
David Zülke wrote: On 25.03.2010, at 22:05, Michael Maclean wrote: Did you also succeed in compiling it as a standalone extension? Could you try? There were some dependencies on ext/date symbols that gave me a hard time when trying that back then... and I lack(ed) the C-fu to fix that. Oh, I hadn't tried that, I'll give it a go. The updated version of David's patch is available here: http://mgdm.net/~michael/patches/bug44383.txt (I noticed a couple of problems with the schema tests, 089 and 091 - it seemed that the test originally expected the timezone offsets to be applied in the wrong direction - I could do with a second opinion on this.) Yes, I think I remember something in that direction. Some timezone offsets behaved weird; back then I think I concluded that the tests must have been wrong as a bug related to that in ext/date was unlikely. Could you list the tested values with expected and actual results? It's only a few IIRC, and it'd make it easier to discuss. Sure, there were only two, as I recall. I'll dig them out and mail back. -- Cheers, Michael -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Bug 44383 in ext/soap
On 25.03.2010, at 22:05, Michael Maclean wrote: Currently, DateTime objects aren't properly mapped to and from xsd:datetime objects when sending them via ext/soap. David Zülke wrote a patch to fix this, and filed it under bug 44383, and mailed the list with it - http://article.gmane.org/gmane.comp.php.devel/ 57369 - but it seems not to have been applied. I tried it earlier on current trunk and noticed it had a couple of problems compiling on a ZTS PHP, which led me to my anti-TSRMLS_FETCH() rampage earlier on today. I've now updated the patch and applied it to my trunk, and it appears to work and pass the tests - does anyone have a problem with me applying it to trunk? Did you also succeed in compiling it as a standalone extension? Could you try? There were some dependencies on ext/date symbols that gave me a hard time when trying that back then... and I lack(ed) the C-fu to fix that. The updated version of David's patch is available here: http://mgdm.net/~michael/patches/bug44383.txt (I noticed a couple of problems with the schema tests, 089 and 091 - it seemed that the test originally expected the timezone offsets to be applied in the wrong direction - I could do with a second opinion on this.) Yes, I think I remember something in that direction. Some timezone offsets behaved weird; back then I think I concluded that the tests must have been wrong as a bug related to that in ext/date was unlikely. Could you list the tested values with expected and actual results? It's only a few IIRC, and it'd make it easier to discuss. - David smime.p7s Description: S/MIME cryptographic signature
[PHP-DEV] Bug 44383 in ext/soap
Currently, DateTime objects aren't properly mapped to and from xsd:datetime objects when sending them via ext/soap. David Zülke wrote a patch to fix this, and filed it under bug 44383, and mailed the list with it - http://article.gmane.org/gmane.comp.php.devel/57369 - but it seems not to have been applied. I tried it earlier on current trunk and noticed it had a couple of problems compiling on a ZTS PHP, which led me to my anti-TSRMLS_FETCH() rampage earlier on today. I've now updated the patch and applied it to my trunk, and it appears to work and pass the tests - does anyone have a problem with me applying it to trunk? The updated version of David's patch is available here: http://mgdm.net/~michael/patches/bug44383.txt (I noticed a couple of problems with the schema tests, 089 and 091 - it seemed that the test originally expected the timezone offsets to be applied in the wrong direction - I could do with a second opinion on this.) -- Cheers, Michael -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
