[PHP-DEV] Bug 60596 - With Patch
Hey all, I found a superfluous if statement while investigating another issue. I submitted a bug to clean it up and attached a patch: https://bugs.php.net/bug.php?id=60596 It's on line 56 of /ext/spl/spl_engine.c : http://lxr.php.net/xref/PHP_TRUNK/ext/spl/spl_engine.c#56 It's really simple, and would likely be optimized away by the compiler anyway, but I figured it was worth cleaning up... Thanks, Anthony -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Bug 60596 - With Patch
On 24/12/11 18:22, Anthony Ferrara wrote: It's really simple, and would likely be optimized away by the compiler anyway, but I figured it was worth cleaning up... Yep, it's straightforward. I'm not sure if it makes a difference or not. IS_DOUBLE is between IS_LONG and IS_BOOL so the compiler could be choosing in the range instead, with the if. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
