Re: [PHP-DEV] Bug in interbase.c "invalid BLOB ID"
Last question: Is there something to do for me, or is everything clear and i can wait for the next release? marius popa schrieb: On Sat, Dec 6, 2008 at 5:54 PM, Benjamin Schwarze wrote: I dont understand your comment clearly. Have you tested the current official code or my patch? I have applied the patch and there was no error with the blob tests marius popa schrieb: On Fri, Nov 28, 2008 at 5:56 PM, Benjamin Schwarze wrote: There is already a bug report: http://bugs.php.net/42089 I saw that someone commented to the bug , i think he must open an new one and 42089 should be closed i will double check to be sure is good to be killed My last comment contains the patch. And sorry for the false title of this thread. In real it is the file ibase_blobs.c. :) I tested on my machine (64 bit ubuntu) and seems ok TEST 1575/4542 [ext/interbase/tests/004.phpt]^MPASS InterBase: BLOB test [ext/interbase/tests/004.phpt] make test for php5.3 got only one failed test to be fixed TEST 1577/4542 [ext/interbase/tests/006.phpt]^MFAIL InterBase: binding (may take a while) [ext/interbase/tests/006.phpt] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Bug in interbase.c "invalid BLOB ID"
On Sat, Dec 6, 2008 at 5:54 PM, Benjamin Schwarze wrote: > I dont understand your comment clearly. > Have you tested the current official code or my patch? I have applied the patch and there was no error with the blob tests > > marius popa schrieb: >> >> On Fri, Nov 28, 2008 at 5:56 PM, Benjamin Schwarze >> wrote: >>> >>> There is already a bug report: http://bugs.php.net/42089 >> >> I saw that someone commented to the bug , i think he must open an new >> one and 42089 should be closed >> i will double check to be sure is good to be killed >>> >>> My last comment contains the patch. >>> >>> And sorry for the false title of this thread. In real it is the file >>> ibase_blobs.c. :) >> >> I tested on my machine (64 bit ubuntu) and seems ok >> TEST 1575/4542 [ext/interbase/tests/004.phpt]^MPASS InterBase: BLOB >> test [ext/interbase/tests/004.phpt] >> >> make test for php5.3 got only one >> failed test to be fixed >> TEST 1577/4542 [ext/interbase/tests/006.phpt]^MFAIL InterBase: binding >> (may take a while) [ext/interbase/tests/006.phpt] >> >> >>> -- >>> PHP Internals - PHP Runtime Development Mailing List >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >>> >> >> >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- developer flamerobin.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Bug in interbase.c "invalid BLOB ID"
I dont understand your comment clearly. Have you tested the current official code or my patch? marius popa schrieb: On Fri, Nov 28, 2008 at 5:56 PM, Benjamin Schwarze <[EMAIL PROTECTED]> wrote: There is already a bug report: http://bugs.php.net/42089 I saw that someone commented to the bug , i think he must open an new one and 42089 should be closed i will double check to be sure is good to be killed My last comment contains the patch. And sorry for the false title of this thread. In real it is the file ibase_blobs.c. :) I tested on my machine (64 bit ubuntu) and seems ok TEST 1575/4542 [ext/interbase/tests/004.phpt]^MPASS InterBase: BLOB test [ext/interbase/tests/004.phpt] make test for php5.3 got only one failed test to be fixed TEST 1577/4542 [ext/interbase/tests/006.phpt]^MFAIL InterBase: binding (may take a while) [ext/interbase/tests/006.phpt] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Bug in interbase.c "invalid BLOB ID"
On Fri, Nov 28, 2008 at 5:56 PM, Benjamin Schwarze <[EMAIL PROTECTED]> wrote: > There is already a bug report: http://bugs.php.net/42089 I saw that someone commented to the bug , i think he must open an new one and 42089 should be closed i will double check to be sure is good to be killed > > My last comment contains the patch. > > And sorry for the false title of this thread. In real it is the file > ibase_blobs.c. :) I tested on my machine (64 bit ubuntu) and seems ok TEST 1575/4542 [ext/interbase/tests/004.phpt]^MPASS InterBase: BLOB test [ext/interbase/tests/004.phpt] make test for php5.3 got only one failed test to be fixed TEST 1577/4542 [ext/interbase/tests/006.phpt]^MFAIL InterBase: binding (may take a while) [ext/interbase/tests/006.phpt] > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- developer flamerobin.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Bug in interbase.c "invalid BLOB ID"
There is already a bug report: http://bugs.php.net/42089 My last comment contains the patch. And sorry for the false title of this thread. In real it is the file ibase_blobs.c. :) -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Bug in interbase.c "invalid BLOB ID"
On 28.11.2008, at 06:15, Benjamin Schwarze wrote: Hi! As some other users recognized, there is a bug in the implementation of the function "_php_ibase_quad_to_string". (imho since version 5.2.1) The line "spprintf(&result, BLOB_ID_LEN+1, "0x%0*" LL_MASK "x", 16, *(ISC_UINT64*)(void *) &qd);" doesnt work as estimated. The result stored inside qd isnt the value convertet from the string, but something else. Normally this should work, but it doesnt. One possible solution is, to change the line into "spprintf(&result, BLOB_ID_LEN+1, "0x%0*x%0*x", 8, qd.gds_quad_low, 8, qd.gds_quad_high);" Of course, there might be a smarter way, but this solution worked for me. My system is a Fedora Core 8 64bit. is there a bug opened for this? if not please open one. also please add your patch regards, Lukas Kahwe Smith [EMAIL PROTECTED] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Bug in interbase.c "invalid BLOB ID"
Hi! As some other users recognized, there is a bug in the implementation of the function "_php_ibase_quad_to_string". (imho since version 5.2.1) The line "spprintf(&result, BLOB_ID_LEN+1, "0x%0*" LL_MASK "x", 16, *(ISC_UINT64*)(void *) &qd);" doesnt work as estimated. The result stored inside qd isnt the value convertet from the string, but something else. Normally this should work, but it doesnt. One possible solution is, to change the line into "spprintf(&result, BLOB_ID_LEN+1, "0x%0*x%0*x", 8, qd.gds_quad_low, 8, qd.gds_quad_high);" Of course, there might be a smarter way, but this solution worked for me. My system is a Fedora Core 8 64bit. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
