Re: [PHP-DEV] Can someone merge `Catchable "Call to a member function bar() on a non-object"`?
Hi! On 16 Sep 2014, at 01:42, Timm Friebe wrote: > Hi everyone, > >> Timm Friebe hat am 16. August 2014 um 18:09 geschrieben: >> two weeks ago, the RFC `Catchable "Call to a member function bar() on a >> non-object"` was accepted by a vote. I don't have commit access to >> php-src/Zend, >> so I can't commit this myself. Back from my summer vacation, I thought I'd >> whip >> up this email (after bringing the pull request up-to-date and making it >> mergeable once again) and ask whether someone here can review[1] and then >> merge >> the PR https://github.com/php/php-src/pull/647? >> >> Thanks in advance! > > Any news on this? Is there anything left I need to do to get this merged? > Should > I apply for Zend/ karma? It’s been merged; due to my deceptive eyes and the similarity between the PR numbers (647 vs 847), I’ve merged 647 instead and then added the test cases that were written for 847. The end result should be the same and certainly all test cases passed (safe for those involving mysql tests); I’ll check the Travis results when they come back. My apologies on the somewhat messy push for this :( > > -Timm > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Can someone merge `Catchable "Call to a member function bar() on a non-object"`?
Hi, > Sara Golemon hat am 16. August 2014 um 19:39 geschrieben: > > On Aug 16, 2014, at 9:09, Timm Friebe wrote: > > two weeks ago, the RFC `Catchable "Call to a member function bar() on a > > non-object"` was accepted by a vote. I don't have commit access to > > php-src/Zend, > > If it's not sorted by someone else, I land this when I get back home later > today. Any news on this, Sara? Timm -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Can someone merge `Catchable "Call to a member function bar() on a non-object"`?
> On Aug 16, 2014, at 9:09, Timm Friebe wrote: > two weeks ago, the RFC `Catchable "Call to a member function bar() on a > non-object"` was accepted by a vote. I don't have commit access to > php-src/Zend, If it's not sorted by someone else, I land this when I get back home later today. -Sara -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Can someone merge `Catchable "Call to a member function bar() on a non-object"`?
Hi, two weeks ago, the RFC `Catchable "Call to a member function bar() on a non-object"` was accepted by a vote. I don't have commit access to php-src/Zend, so I can't commit this myself. Back from my summer vacation, I thought I'd whip up this email (after bringing the pull request up-to-date and making it mergeable once again) and ask whether someone here can review[1] and then merge the PR https://github.com/php/php-src/pull/647? Thanks in advance! - Timm 1: The essence of this PR is a patch to Zend/zend_vm_def.h: https://gist.github.com/thekid/3f8270d0554f1a3903f5 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
