Re: [PHP-DEV] Changelog / upgrading notes for promoted warnings
On Thu, 19 Dec 2019, 21:17 Rowan Tommins, wrote: > Hi all, > > Earlier, I was writing an application-specific wrapper around the > password_hash function, and was surprised that it could return false, > rather than throwing an error. > > I then found this commit to master making it throw errors for PHP 8.0: > https://github.com/php/php-src/commit/37c11714 > > That's great! But ... it is a breaking change, and I can't see any note > in UPGRADING. Is there a running list of the Warnings that have been > promoted to Errors anywhere, and if not, should we create one before we > forget? > > Regards, > > -- > Rowan Tommins (né Collins) > [IMSoP] > As there are a lot more of these promotion, from what I recall, is that a general upgrading note will be added. As the promotions cover case which are clear programming/logic errors and thus shouldn't arise in production code. An example of a promotion is an invalid flag value (e.g. a mode with fopen which does not exist) or out of bound values (usually integer value which need to be greater than zero). Moreover, I'm not sure it's helpful to have a massive list of functions where some warnings have been promoted and others not. But this is only my opinion. Best regards George P. Banyard >
[PHP-DEV] Changelog / upgrading notes for promoted warnings
Hi all, Earlier, I was writing an application-specific wrapper around the password_hash function, and was surprised that it could return false, rather than throwing an error. I then found this commit to master making it throw errors for PHP 8.0: https://github.com/php/php-src/commit/37c11714 That's great! But ... it is a breaking change, and I can't see any note in UPGRADING. Is there a running list of the Warnings that have been promoted to Errors anywhere, and if not, should we create one before we forget? Regards, -- Rowan Tommins (né Collins) [IMSoP] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] ChangeLog
Zitat von Pierre Joye : 2010/5/29 Johannes Schlüter : Hey, On Fri, 2010-05-28 at 23:50 +0200, Pierre Joye wrote: I'd to add that unless we add everything in the NEWS file, the ChangeLog remains the only way to have a list of all changes (without doing manually). Having the file is absolutely fine with me, while I can fulfill my needs with svn annotate and svn log. But if we ship it, it should be correct and at least since 5.2.0 we ship a wrong (not updated) file. And that I consider bad. So I ask somebody to either remove it or make sure it's updated (automatically or by adding instructions to README.RELEASE_PROCESS) in all places. Maybe simply do it at release time? Having the changelog updated automatically used to be a really useful thing, because there also existed a mailing list that sent daily (or weekly?) diffs to the changelog file. This way you could easily follow development of PHP without having to subscribe to the commits mailing list. Jan. -- Do you need professional PHP or Horde consulting? http://horde.org/consulting/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] ChangeLog
Hey, On Fri, 2010-05-28 at 23:50 +0200, Pierre Joye wrote: > I'd to add that unless we add everything in the NEWS file, the > ChangeLog remains the only way to have a list of all changes (without > doing manually). Having the file is absolutely fine with me, while I can fulfill my needs with svn annotate and svn log. But if we ship it, it should be correct and at least since 5.2.0 we ship a wrong (not updated) file. And that I consider bad. So I ask somebody to either remove it or make sure it's updated (automatically or by adding instructions to README.RELEASE_PROCESS) in all places. johannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] ChangeLog
2010/5/29 Johannes Schlüter : > Hey, > > On Fri, 2010-05-28 at 23:50 +0200, Pierre Joye wrote: >> I'd to add that unless we add everything in the NEWS file, the >> ChangeLog remains the only way to have a list of all changes (without >> doing manually). > > Having the file is absolutely fine with me, while I can fulfill my needs > with svn annotate and svn log. But if we ship it, it should be correct > and at least since 5.2.0 we ship a wrong (not updated) file. And that I > consider bad. So I ask somebody to either remove it or make sure it's updated > (automatically or by adding instructions to README.RELEASE_PROCESS) in > all places. Maybe simply do it at release time? Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: Commit messages and ChangeLog (Re: [PHP-DEV] ChangeLog)
hi Gwynne, On Sat, May 29, 2010 at 10:39 AM, Gwynne Raskind wrote: >> By "without doing it manually", I meant when one fetches a release or >> a snapshot. > > > The ChangeLog files aren't updated because no one ever ported the ChangeLog > crons from CVS to SVN. It wouldn't be very difficult - in fact one of the > open-source scripts already out there for the purpose would seem appropos, it > just hasn't been done. They seem to be standard fare in FOSS projects, so I'm > -1 for removing the functionality, but +1 for removing the useless archives > from all active branches. > > I wish I could volunteer to do the port, but I have too much on my plate > right now :( http://arthurdejong.org/svn2cl/ should be enough? Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: Commit messages and ChangeLog (Re: [PHP-DEV] ChangeLog)
On May 28, 2010, at 7:43 PM, Pierre Joye wrote: Is anybody using this file? If this is thee case could somebody then make sure it's being updated (and maybe take care of ChangeLog-200[6-9].gz being created) else I'd suggest dropping them. An outdated file might be confusing for users expecting content like we have in the NEWS file there. >>> >>> I do, what's about only changing how it is generated to generated >>> changes since last release instead? >>> >>> I'd to add that unless we add everything in the NEWS file, the >>> ChangeLog remains the only way to have a list of all changes (without >>> doing manually). >> >> Isn't that what "svn log -v" now provides? The format is slightly >> different of course, but it does provide the same info. > > By "without doing it manually", I meant when one fetches a release or > a snapshot. The ChangeLog files aren't updated because no one ever ported the ChangeLog crons from CVS to SVN. It wouldn't be very difficult - in fact one of the open-source scripts already out there for the purpose would seem appropos, it just hasn't been done. They seem to be standard fare in FOSS projects, so I'm -1 for removing the functionality, but +1 for removing the useless archives from all active branches. I wish I could volunteer to do the port, but I have too much on my plate right now :( -- Gwynne smime.p7s Description: S/MIME cryptographic signature
[PHP-DEV] Re: Commit messages and ChangeLog (Re: [PHP-DEV] ChangeLog)
2010/5/29 Derick Rethans : > On Fri, 28 May 2010, Pierre Joye wrote: > >> 2010/5/28 Johannes Schlüter : >> >> > Is anybody using this file? If this is thee case could somebody then >> > make sure it's being updated (and maybe take care of >> > ChangeLog-200[6-9].gz being created) else I'd suggest dropping them. An >> > outdated file might be confusing for users expecting content like we >> > have in the NEWS file there. >> >> I do, what's about only changing how it is generated to generated >> changes since last release instead? >> >> I'd to add that unless we add everything in the NEWS file, the >> ChangeLog remains the only way to have a list of all changes (without >> doing manually). > > Isn't that what "svn log -v" now provides? The format is slightly > different of course, but it does provide the same info. By "without doing it manually", I meant when one fetches a release or a snapshot. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Commit messages and ChangeLog (Re: [PHP-DEV] ChangeLog)
On Fri, 28 May 2010, Pierre Joye wrote: > 2010/5/28 Johannes Schlüter : > > > Is anybody using this file? If this is thee case could somebody then > > make sure it's being updated (and maybe take care of > > ChangeLog-200[6-9].gz being created) else I'd suggest dropping them. An > > outdated file might be confusing for users expecting content like we > > have in the NEWS file there. > > I do, what's about only changing how it is generated to generated > changes since last release instead? > > I'd to add that unless we add everything in the NEWS file, the > ChangeLog remains the only way to have a list of all changes (without > doing manually). Isn't that what "svn log -v" now provides? The format is slightly different of course, but it does provide the same info. Although it does seem that we need to get ourselves more diciplined into writing the commit messages according to the prefered format[1] again. [1] http://svn.php.net/viewvc/php/php-src/trunk/README.SVN-RULES?view=annotate#l90 with kind regards, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] ChangeLog
hi Johannes, 2010/5/28 Johannes Schlüter : > Is anybody using this file? If this is thee case could somebody then > make sure it's being updated (and maybe take care of > ChangeLog-200[6-9].gz being created) else I'd suggest dropping them. An > outdated file might be confusing for users expecting content like we > have in the NEWS file there. I do, what's about only changing how it is generated to generated changes since last release instead? I'd to add that unless we add everything in the NEWS file, the ChangeLog remains the only way to have a list of all changes (without doing manually). Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] ChangeLog
2010/5/28 Johannes Schlüter : > Is anybody using this file? If this is thee case could somebody then > make sure it's being updated (and maybe take care of > ChangeLog-200[6-9].gz being created) else I'd suggest dropping them. An > outdated file might be confusing for users expecting content like we > have in the NEWS file there. +1 on removing the ChangeLog and its archives, particularly since they're taking up over a meg in a PHP 5.3 checkout, most of which is already gzipped. NEWS and the migration guides in the manual cover the needs of users these days, and there's always svn log for anyone who wants more detailed changeset information. Adam -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] ChangeLog
2010/5/28 Johannes Schlüter : > Hey, > > I know type hints are more fun to discuss but anyways: In trunk > ChangeLog lists entries up till 2005 (when 5.2 was branched of, from > which 5.3 was branched from which the current trunk was branched of) In > the old trunk the file lasts until 2009-07-08 (when we switched from CVS > to svn) > > Is anybody using this file? If this is thee case could somebody then > make sure it's being updated (and maybe take care of > ChangeLog-200[6-9].gz being created) else I'd suggest dropping them. An > outdated file might be confusing for users expecting content like we > have in the NEWS file there. +1 for dropping it, it is confusing and why do we need that aside the NEWS file ? > johannes > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] ChangeLog
Hey, I know type hints are more fun to discuss but anyways: In trunk ChangeLog lists entries up till 2005 (when 5.2 was branched of, from which 5.3 was branched from which the current trunk was branched of) In the old trunk the file lasts until 2009-07-08 (when we switched from CVS to svn) Is anybody using this file? If this is thee case could somebody then make sure it's being updated (and maybe take care of ChangeLog-200[6-9].gz being created) else I'd suggest dropping them. An outdated file might be confusing for users expecting content like we have in the NEWS file there. johannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
